mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Woodhouse <dwmw2@infradead.org>
To: Sean Christopherson <seanjc@google.com>
Cc: Like Xu <like.xu.linux@gmail.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Oliver Upton <oliver.upton@linux.dev>,
	kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] KVM: x86/tsc: Don't sync user changes to TSC with KVM-initiated change
Date: Wed, 13 Sep 2023 17:05:53 +0200	[thread overview]
Message-ID: <b83a52bf72b951e69d3df23fff144899b0d6c11d.camel@infradead.org> (raw)
In-Reply-To: <ZQHMM8/7xXReZHdD@google.com>

[-- Attachment #1: Type: text/plain, Size: 1985 bytes --]

On Wed, 2023-09-13 at 07:50 -0700, Sean Christopherson wrote:
> On Wed, Sep 13, 2023, David Woodhouse wrote:
> > Userspace used to be able to force a sync by writing zero. You are
> > removing that from the ABI without any explanation about why;
> 
> No, my suggestion did not remove that from the ABI.  A @user_value of '0' would
> still force synchronization.

Ah, OK. Yes, you're right. Thanks.

> It's necessary for "user_set_tsc" to be an accurate name.  The code in v6 yields
> "user_set_tsc_to_non_zero_value".  And I don't think it's just a naming issue,

In another thread, you said that the sync code doesn't differentiate
between userspace initializing the TSC And userspace attempting to
synchronize the TSC. I responded that *I* don't differentiate the two
and couldn't see the difference.

I think we were both wrong. Userspace does *explicitly* synchronize the
TSC by writing zero, and the sync code *does* explicitly handle that,
yes?

And the reason I mention it here is that we could perhaps reasonable
say that userspace *syncing* the TSC like that is not the same as
userspace *setting* the TSC, and that it's OK for user_set_tsc to
remain false? It saves adding another argument to kvm_synchronize_tsc()
making it even more complex for a use case that just doesn't make sense
anyway...

> e.g. if userspace writes '0' immediately after creating, and then later writes a
> small delta, the v6 code wouldn't trigger synchronization because "user_set_tsc"
> would be left unseft by the write of '0'.

True, but that's the existing behaviour, and it doesn't make much sense
for the user to write 0 to trigger a sync immediately after creating,
because the *kernel* does that anyway.

I don't feel particularly strongly. Having a commit message and code
comments which clearly set out the reasoning for the 1-second slop and
the reasons why we want to *stop* doing it in this case, is the
important part. That had got lost.

[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5965 bytes --]

  reply	other threads:[~2023-09-13 15:06 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-01  3:45 Like Xu
2023-08-11 22:59 ` Sean Christopherson
2023-09-13  8:10   ` David Woodhouse
2023-09-13  8:41     ` Like Xu
2023-09-13  8:44       ` David Woodhouse
2023-09-13  8:31   ` David Woodhouse
2023-09-13 14:50     ` Sean Christopherson
2023-09-13 15:05       ` David Woodhouse [this message]
2023-09-13 15:15         ` Sean Christopherson
2023-09-13 15:24           ` David Woodhouse
2023-09-14  3:24             ` Like Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b83a52bf72b951e69d3df23fff144899b0d6c11d.camel@infradead.org \
    --to=dwmw2@infradead.org \
    --cc=kvm@vger.kernel.org \
    --cc=like.xu.linux@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oliver.upton@linux.dev \
    --cc=pbonzini@redhat.com \
    --cc=seanjc@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®