[PATCH] ASoC: amd: add ACPI dependency check

[PATCH] ASoC: amd: add ACPI dependency check

[Vijendar Mukunda]

Add ACPI dependency for evaluating DMIC hardware
runtime.

Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
---
 sound/soc/amd/renoir/rn-pci-acp3x.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/sound/soc/amd/renoir/rn-pci-acp3x.c b/sound/soc/amd/renoir/rn-pci-acp3x.c
index d1faea5..165c93f 100644
--- a/sound/soc/amd/renoir/rn-pci-acp3x.c
+++ b/sound/soc/amd/renoir/rn-pci-acp3x.c
@@ -218,6 +218,7 @@ static int snd_rn_acp_probe(struct pci_dev *pci,
 		ret = -ENODEV;
 		goto de_init;
 	} else if (dmic_acpi_check == ACP_DMIC_AUTO) {
+#if defined(CONFIG_ACPI)
 		handle = ACPI_HANDLE(&pci->dev);
 		ret = acpi_evaluate_integer(handle, "_WOV", NULL, &dmic_status);
 		if (ACPI_FAILURE(ret)) {
@@ -228,6 +229,7 @@ static int snd_rn_acp_probe(struct pci_dev *pci,
 			ret = -ENODEV;
 			goto de_init;
 		}
+#endif
 	}
 
 	adata->res = devm_kzalloc(&pci->dev,
-- 
2.7.4

Re: [PATCH] ASoC: amd: add ACPI dependency check

[Mark Brown]

On Tue, 7 Jul 2020 16:16:41 +0530, Vijendar Mukunda wrote:
> Add ACPI dependency for evaluating DMIC hardware
> runtime.

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: amd: add ACPI dependency check
      commit: 68d1abe186d1c865923d3b97414906f4697daf58

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

Re: [PATCH] ASoC: amd: add ACPI dependency check

[Randy Dunlap]

On 7/7/20 7:17 AM, Mark Brown wrote:
> On Tue, 7 Jul 2020 16:16:41 +0530, Vijendar Mukunda wrote:
>> Add ACPI dependency for evaluating DMIC hardware
>> runtime.
> 
> Applied to
> 
>    https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
> 
> Thanks!
> 
> [1/1] ASoC: amd: add ACPI dependency check
>       commit: 68d1abe186d1c865923d3b97414906f4697daf58
> 
> All being well this means that it will be integrated into the linux-next
> tree (usually sometime in the next 24 hours) and sent to Linus during
> the next merge window (or sooner if it is a bug fix), however if
> problems are discovered then the patch may be dropped or reverted.
> 
> You may get further e-mails resulting from automated or manual testing
> and review of the tree, please engage with people reporting problems and
> send followup patches addressing any issues that are reported if needed.
> 
> If any updates are required or you are submitting further changes they
> should be sent as incremental updates against current git, existing
> patches will not be replaced.
> 
> Please add any relevant lists and maintainers to the CCs when replying
> to this mail.


Vijendar, you should have Cc-ed me on the patch and you should have
added this line to the patch:

Reported-by: Randy Dunlap <rdunlap@infradead.org>

Also, now
Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested

although there are now 2 warnings:

../sound/soc/amd/renoir/rn-pci-acp3x.c: In function ‘snd_rn_acp_probe’:
../sound/soc/amd/renoir/rn-pci-acp3x.c:172:15: warning: unused variable ‘dmic_status’ [-Wunused-variable]
  acpi_integer dmic_status;
               ^~~~~~~~~~~
../sound/soc/amd/renoir/rn-pci-acp3x.c:171:14: warning: unused variable ‘handle’ [-Wunused-variable]
  acpi_handle handle;
              ^~~~~~



thanks.
-- 
~Randy

Re: [PATCH] ASoC: amd: add ACPI dependency check

[Mukunda,Vijendar]

On 07/07/20 9:05 pm, Randy Dunlap wrote:
> On 7/7/20 7:17 AM, Mark Brown wrote:
>> On Tue, 7 Jul 2020 16:16:41 +0530, Vijendar Mukunda wrote:
>>> Add ACPI dependency for evaluating DMIC hardware
>>> runtime.
>>
>> Applied to
>>
>>     https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.kernel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Fbroonie%2Fsound.git&data=02%7C01%7CVijendar.Mukunda%40amd.com%7C208d9cc8e38b4dce718608d8228b70af%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637297329610560875&sdata=NrNkECQoF2k0BO2NEQVON%2BE%2BP0clg4nPqH285c7HHzU%3D&reserved=0 for-next
>>
>> Thanks!
>>
>> [1/1] ASoC: amd: add ACPI dependency check
>>        commit: 68d1abe186d1c865923d3b97414906f4697daf58
>>
>> All being well this means that it will be integrated into the linux-next
>> tree (usually sometime in the next 24 hours) and sent to Linus during
>> the next merge window (or sooner if it is a bug fix), however if
>> problems are discovered then the patch may be dropped or reverted.
>>
>> You may get further e-mails resulting from automated or manual testing
>> and review of the tree, please engage with people reporting problems and
>> send followup patches addressing any issues that are reported if needed.
>>
>> If any updates are required or you are submitting further changes they
>> should be sent as incremental updates against current git, existing
>> patches will not be replaced.
>>
>> Please add any relevant lists and maintainers to the CCs when replying
>> to this mail.
> 
> 
> Vijendar, you should have Cc-ed me on the patch and you should have
> added this line to the patch:
> 
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> 
Sorry Randy. I have forgot to add you in cc.
will fix the kernel warnings and upload a fresh patchset.
> Also, now
> Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
> 
> although there are now 2 warnings:
> 
> ../sound/soc/amd/renoir/rn-pci-acp3x.c: In function ‘snd_rn_acp_probe’:
> ../sound/soc/amd/renoir/rn-pci-acp3x.c:172:15: warning: unused variable ‘dmic_status’ [-Wunused-variable]
>    acpi_integer dmic_status;
>                 ^~~~~~~~~~~
> ../sound/soc/amd/renoir/rn-pci-acp3x.c:171:14: warning: unused variable ‘handle’ [-Wunused-variable]
>    acpi_handle handle;
>                ^~~~~~
> 
> 
> 
> thanks.
>