[PATCH 0/2] mmc: sdhci-pic32: allow driver to be compiled with COMPILE_TEST

[PATCH 0/2] mmc: sdhci-pic32: allow driver to be compiled with COMPILE_TEST

[Brian Masney]

While migrating a pic32 clk driver off of a legacy API, I mistakenly
broke one of the drivers, and the issue could have been caught with a
simple compile test. Now that the dependent patches have been merged
into Linus's tree via the MIPS tree, we can now enable COMPILE_TEST
for pic32 driver in this subsystem.

While changes are being made to this driver, let's also fix a single
outstanding checkpatch.pl error with this driver.

Signed-off-by: Brian Masney <bmasney@redhat.com>
---
Brian Masney (2):
      mmc: sdhci-pic32: add SPDX license identifier
      mmc: sdhci-pic32: allow driver to be compiled with COMPILE_TEST

 drivers/mmc/host/Kconfig       | 2 +-
 drivers/mmc/host/sdhci-pic32.c | 5 +----
 2 files changed, 2 insertions(+), 5 deletions(-)
---
base-commit: 6de23f81a5e08be8fbf5e8d7e9febc72a5b5f27f
change-id: 20260222-mmc-pic32-137b3eae8e66

Best regards,
-- 
Brian Masney <bmasney@redhat.com>

[PATCH 1/2] mmc: sdhci-pic32: add SPDX license identifier

[Brian Masney]

Add the missing SPDX license identifier to the top of the file, and drop
the boiler plate license text.

Signed-off-by: Brian Masney <bmasney@redhat.com>
Cc: linux-spdx@vger.kernel.org
---
 drivers/mmc/host/sdhci-pic32.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/mmc/host/sdhci-pic32.c b/drivers/mmc/host/sdhci-pic32.c
index 2cc632e91fe454bf29c1da22e45135d5d0267f54..6899cf6c65e7df2461c9534b51b8edfd0d6bf7d9 100644
--- a/drivers/mmc/host/sdhci-pic32.c
+++ b/drivers/mmc/host/sdhci-pic32.c
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-only
 /*
  * Support of SDHCI platform devices for Microchip PIC32.
  *
@@ -5,10 +6,6 @@
  * Andrei Pistirica, Paul Thacker
  *
  * Inspired by sdhci-pltfm.c
- *
- * This file is licensed under the terms of the GNU General Public
- * License version 2. This program is licensed "as is" without any
- * warranty of any kind, whether express or implied.
  */
 
 #include <linux/clk.h>

-- 
2.53.0

[PATCH 2/2] mmc: sdhci-pic32: allow driver to be compiled with COMPILE_TEST

[Brian Masney]

This driver currently only supports builds against a PIC32 target. Now
that commit d6618d277c1a ("mmc: sdhci-pic32: update include to use
pic32.h from platform_data") is merged, it's possible to compile this
driver on other architectures.

To avoid future breakage of this driver in the future, let's update the
Kconfig so that it can be built with COMPILE_TEST enabled on all
architectures.

Signed-off-by: Brian Masney <bmasney@redhat.com>
---
 drivers/mmc/host/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
index 6d79cc9a79e22d80bdb8977a8182d814ab91927f..4ca55c025159ee4c6b70dfff0ea3a44ecad98ff3 100644
--- a/drivers/mmc/host/Kconfig
+++ b/drivers/mmc/host/Kconfig
@@ -1044,7 +1044,7 @@ config MMC_MTK
 
 config MMC_SDHCI_MICROCHIP_PIC32
 	tristate "Microchip PIC32MZDA SDHCI support"
-	depends on MMC_SDHCI && PIC32MZDA && MMC_SDHCI_PLTFM
+	depends on MMC_SDHCI && MMC_SDHCI_PLTFM && (PIC32MZDA || COMPILE_TEST)
 	help
 	  This selects the Secure Digital Host Controller Interface (SDHCI)
 	  for PIC32MZDA platform.

-- 
2.53.0

Re: [PATCH 1/2] mmc: sdhci-pic32: add SPDX license identifier

[Adrian Hunter]

On 23/02/2026 01:39, Brian Masney wrote:
> Add the missing SPDX license identifier to the top of the file, and drop
> the boiler plate license text.
> 
> Signed-off-by: Brian Masney <bmasney@redhat.com>
> Cc: linux-spdx@vger.kernel.org

Acked-by: Adrian Hunter <adrian.hunter@intel.com>

> ---
>  drivers/mmc/host/sdhci-pic32.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/mmc/host/sdhci-pic32.c b/drivers/mmc/host/sdhci-pic32.c
> index 2cc632e91fe454bf29c1da22e45135d5d0267f54..6899cf6c65e7df2461c9534b51b8edfd0d6bf7d9 100644
> --- a/drivers/mmc/host/sdhci-pic32.c
> +++ b/drivers/mmc/host/sdhci-pic32.c
> @@ -1,3 +1,4 @@
> +// SPDX-License-Identifier: GPL-2.0-only
>  /*
>   * Support of SDHCI platform devices for Microchip PIC32.
>   *
> @@ -5,10 +6,6 @@
>   * Andrei Pistirica, Paul Thacker
>   *
>   * Inspired by sdhci-pltfm.c
> - *
> - * This file is licensed under the terms of the GNU General Public
> - * License version 2. This program is licensed "as is" without any
> - * warranty of any kind, whether express or implied.
>   */
>  
>  #include <linux/clk.h>
> 

Re: [PATCH 2/2] mmc: sdhci-pic32: allow driver to be compiled with COMPILE_TEST

[Adrian Hunter]

On 23/02/2026 01:39, Brian Masney wrote:
> This driver currently only supports builds against a PIC32 target. Now
> that commit d6618d277c1a ("mmc: sdhci-pic32: update include to use
> pic32.h from platform_data") is merged, it's possible to compile this
> driver on other architectures.
> 
> To avoid future breakage of this driver in the future, let's update the
> Kconfig so that it can be built with COMPILE_TEST enabled on all
> architectures.
> 
> Signed-off-by: Brian Masney <bmasney@redhat.com>

Acked-by: Adrian Hunter <adrian.hunter@intel.com>

> ---
>  drivers/mmc/host/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> index 6d79cc9a79e22d80bdb8977a8182d814ab91927f..4ca55c025159ee4c6b70dfff0ea3a44ecad98ff3 100644
> --- a/drivers/mmc/host/Kconfig
> +++ b/drivers/mmc/host/Kconfig
> @@ -1044,7 +1044,7 @@ config MMC_MTK
>  
>  config MMC_SDHCI_MICROCHIP_PIC32
>  	tristate "Microchip PIC32MZDA SDHCI support"
> -	depends on MMC_SDHCI && PIC32MZDA && MMC_SDHCI_PLTFM
> +	depends on MMC_SDHCI && MMC_SDHCI_PLTFM && (PIC32MZDA || COMPILE_TEST)
>  	help
>  	  This selects the Secure Digital Host Controller Interface (SDHCI)
>  	  for PIC32MZDA platform.
> 

Re: [PATCH 0/2] mmc: sdhci-pic32: allow driver to be compiled with COMPILE_TEST

[Ulf Hansson]

On Mon, 23 Feb 2026 at 00:39, Brian Masney <bmasney@redhat.com> wrote:
>
> While migrating a pic32 clk driver off of a legacy API, I mistakenly
> broke one of the drivers, and the issue could have been caught with a
> simple compile test. Now that the dependent patches have been merged
> into Linus's tree via the MIPS tree, we can now enable COMPILE_TEST
> for pic32 driver in this subsystem.
>
> While changes are being made to this driver, let's also fix a single
> outstanding checkpatch.pl error with this driver.
>
> Signed-off-by: Brian Masney <bmasney@redhat.com>
> ---
> Brian Masney (2):
>       mmc: sdhci-pic32: add SPDX license identifier
>       mmc: sdhci-pic32: allow driver to be compiled with COMPILE_TEST
>
>  drivers/mmc/host/Kconfig       | 2 +-
>  drivers/mmc/host/sdhci-pic32.c | 5 +----
>  2 files changed, 2 insertions(+), 5 deletions(-)
> ---
> base-commit: 6de23f81a5e08be8fbf5e8d7e9febc72a5b5f27f
> change-id: 20260222-mmc-pic32-137b3eae8e66
>
> Best regards,
> --
> Brian Masney <bmasney@redhat.com>

The series applied for next, thanks!

Kind regards
Uffe