From: "Arnd Bergmann" <arnd@arndb.de>
To: "Jiri Slaby" <jirislaby@kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/6] char/mwave: cleanup
Date: Wed, 19 Nov 2025 13:54:54 +0100 [thread overview]
Message-ID: <b8834e5d-fdde-4b1a-8757-288dddc507a9@app.fastmail.com> (raw)
In-Reply-To: <20251119091949.825958-1-jirislaby@kernel.org>
On Wed, Nov 19, 2025, at 10:19, Jiri Slaby (SUSE) wrote:
> Hi,
>
> the driver is in a bad shape -- this is a minimal cleanup, so that it is
> more or less readable.
>
> Jiri Slaby (SUSE) (6):
> char/mwave: remove dead code
> char/mwave: remove MWAVE_FUTZ_WITH_OTHER_DEVICES ifdeffery
> char/mwave: remove unneeded fops
> char/mwave: remove printk tracing
> char/mwave: drop printk wrapper
> char/mwave: drop typedefs
The cleanups all look good to me,
Acked-by: Arnd Bergmann <arnd@arndb.de>
I assume you are not actually trying to use this driver, right?
According to thinkwiki.de, the 3780i modem was only used in a
couple of Thinkpad models that are now over 25 years old, using
Pentium II processors, and they all have a physical RS232 port
that can be used to connect an external modem instead.
Maybe we can just retire this driver?
Arnd
prev parent reply other threads:[~2025-11-19 12:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-19 9:19 Jiri Slaby (SUSE)
2025-11-19 9:19 ` [PATCH 1/6] char/mwave: remove dead code Jiri Slaby (SUSE)
2025-11-19 9:19 ` [PATCH 2/6] char/mwave: remove MWAVE_FUTZ_WITH_OTHER_DEVICES ifdeffery Jiri Slaby (SUSE)
2025-11-19 9:19 ` [PATCH 3/6] char/mwave: remove unneeded fops Jiri Slaby (SUSE)
2025-11-19 9:19 ` [PATCH 4/6] char/mwave: remove printk tracing Jiri Slaby (SUSE)
2025-11-19 9:19 ` [PATCH 5/6] char/mwave: drop printk wrapper Jiri Slaby (SUSE)
2025-11-19 9:19 ` [PATCH 6/6] char/mwave: drop typedefs Jiri Slaby (SUSE)
2025-11-19 12:54 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8834e5d-fdde-4b1a-8757-288dddc507a9@app.fastmail.com \
--to=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®