From: Markus Elfring <Markus.Elfring@web.de>
To: Anshuman Khandual <anshuman.khandual@arm.com>,
coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
James Clark <james.clark@linaro.org>,
Mike Leach <mike.leach@linaro.org>,
Suzuki K Poulose <suzuki.poulose@arm.com>
Cc: kernel-janitors@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>, Leo Yan <leo.yan@arm.com>,
Tamas Zsoldos <tamas.zsoldos@arm.com>
Subject: Re: [PATCH] coresight: trbe: Use scope-based resource management in arm_trbe_alloc_buffer()
Date: Fri, 12 Sep 2025 08:00:07 +0200 [thread overview]
Message-ID: <b89eda12-c930-43e8-92c0-c2e1699284f7@web.de> (raw)
In-Reply-To: <3f2137d5-5bfc-44e7-9269-3069e44eda31@arm.com>
>> Scope-based resource management became supported for some
>> programming interfaces by contributions of Peter Zijlstra on 2023-05-26.
>> See also the commit 54da6a0924311c7cf5015533991e44fb8eb12773 ("locking:
>
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>
> SHA ID here just needs first 12 digits not the entire string.
See also once more:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.17-rc5#n109
>> Introduce __cleanup() based infrastructure").
>>
>> * Thus use the attribute “__free(kfree)”.
>>
>> * Reduce the scopes for the local variables “buf” and “pglist”.
>
> What is that required ?
The needed variables should be defined in a succinct way.
>> * Omit four kfree() calls accordingly.
>
> Right.
>
> The commit message should be re-written with little more
> context from arm_trbe_alloc_buffer(), after describing
> the new scope-based resource management.
Which background information do you miss so far?
Regards,
Markus
next prev parent reply other threads:[~2025-09-12 6:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-09 12:28 Markus Elfring
2025-09-12 4:25 ` Anshuman Khandual
2025-09-12 6:00 ` Markus Elfring [this message]
2025-09-12 10:27 ` Leo Yan
2025-09-12 12:37 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b89eda12-c930-43e8-92c0-c2e1699284f7@web.de \
--to=markus.elfring@web.de \
--cc=alexander.shishkin@linux.intel.com \
--cc=anshuman.khandual@arm.com \
--cc=coresight@lists.linaro.org \
--cc=james.clark@linaro.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=leo.yan@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mike.leach@linaro.org \
--cc=suzuki.poulose@arm.com \
--cc=tamas.zsoldos@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®