From: Markus Elfring <Markus.Elfring@web.de>
To: Leo Yan <leo.yan@arm.com>,
Anshuman Khandual <anshuman.khandual@arm.com>,
coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>,
James Clark <james.clark@linaro.org>,
Mike Leach <mike.leach@linaro.org>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Tamas Zsoldos <tamas.zsoldos@arm.com>,
kernel-janitors@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] coresight: trbe: Use scope-based resource management in arm_trbe_alloc_buffer()
Date: Fri, 12 Sep 2025 14:37:58 +0200 [thread overview]
Message-ID: <ef091856-8803-4c68-a994-b995ddc0d4ab@web.de> (raw)
In-Reply-To: <20250912102743.GG12516@e132581.arm.com>
>> Seems like a good idea though. But please keep the local variable
>> declaration in the current place which is bit cleaner and reduces
>> code churn as well.
>
> Though include/linux/cleanup.h suggests to "always define and assign
> variables in one statement" to avoid potential interdependency problem
> with lock, this is not concerned in arm_trbe_alloc_buffer().
>
> So I bias to Anshuman's suggestion of declaring variables at the top
> of the function, as this is the style widely used in the kernel.
Does anything hinder you to follow the mentioned cleanup advice more?
Regards,
Markus
prev parent reply other threads:[~2025-09-12 12:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-09 12:28 Markus Elfring
2025-09-12 4:25 ` Anshuman Khandual
2025-09-12 6:00 ` Markus Elfring
2025-09-12 10:27 ` Leo Yan
2025-09-12 12:37 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef091856-8803-4c68-a994-b995ddc0d4ab@web.de \
--to=markus.elfring@web.de \
--cc=alexander.shishkin@linux.intel.com \
--cc=anshuman.khandual@arm.com \
--cc=coresight@lists.linaro.org \
--cc=james.clark@linaro.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=leo.yan@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mike.leach@linaro.org \
--cc=suzuki.poulose@arm.com \
--cc=tamas.zsoldos@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®