mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jeffrey Hugo <quic_jhugo@quicinc.com>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
	<davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
	<pabeni@redhat.com>
Cc: <mhi@lists.linux.dev>, <linux-arm-msm@vger.kernel.org>,
	<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<loic.poulain@linaro.org>
Subject: Re: [PATCH 3/3] net: mhi: Increase the default MTU from 16K to 32K
Date: Tue, 6 Jun 2023 07:50:23 -0600	[thread overview]
Message-ID: <b8a25a70-8781-8b82-96d8-bc1ecf2d5468@quicinc.com> (raw)
In-Reply-To: <20230606123119.57499-4-manivannan.sadhasivam@linaro.org>

On 6/6/2023 6:31 AM, Manivannan Sadhasivam wrote:
> Most of the Qualcomm endpoint devices are supporting 32K MTU for the
> UL (Uplink) and DL (Downlink) channels. So let's use the same value
> in the MHI NET driver also. This gives almost 2x increase in the throughput
> for the UL channel.
> 
> Below is the comparision:
> 
> iperf on the UL channel with 16K MTU:
> 
> [ ID] Interval       Transfer     Bandwidth
> [  3]  0.0-10.0 sec   353 MBytes   296 Mbits/sec
> 
> iperf on the UL channel with 32K MTU:
> 
> [ ID] Interval       Transfer     Bandwidth
> [  3]  0.0-10.0 sec   695 MBytes   583 Mbits/sec
> 
> Cc: Loic Poulain <loic.poulain@linaro.org>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
>   drivers/net/mhi_net.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/mhi_net.c b/drivers/net/mhi_net.c
> index 3d322ac4f6a5..eddc2c701da4 100644
> --- a/drivers/net/mhi_net.c
> +++ b/drivers/net/mhi_net.c
> @@ -14,7 +14,7 @@
>   
>   #define MHI_NET_MIN_MTU		ETH_MIN_MTU
>   #define MHI_NET_MAX_MTU		0xffff
> -#define MHI_NET_DEFAULT_MTU	0x4000
> +#define MHI_NET_DEFAULT_MTU	0x8000

Why not SZ_32K?

  reply	other threads:[~2023-06-06 13:51 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-06 12:31 [PATCH 0/3] Add MHI Endpoint network driver Manivannan Sadhasivam
2023-06-06 12:31 ` [PATCH 1/3] net: " Manivannan Sadhasivam
2023-06-07  8:20   ` Simon Horman
2023-06-07 11:21     ` Manivannan Sadhasivam
2023-06-06 12:31 ` [PATCH 2/3] MAINTAINERS: Add entry for MHI networking drivers under MHI bus Manivannan Sadhasivam
2023-06-06 12:31 ` [PATCH 3/3] net: mhi: Increase the default MTU from 16K to 32K Manivannan Sadhasivam
2023-06-06 13:50   ` Jeffrey Hugo [this message]
2023-06-07  6:58     ` Manivannan Sadhasivam
2023-06-07 12:25       ` Andrew Lunn
2023-06-07 14:56         ` Manivannan Sadhasivam
2023-06-07  8:21   ` Simon Horman
2023-06-06 12:59 ` [PATCH 0/3] Add MHI Endpoint network driver Andrew Lunn
2023-06-07  6:56   ` Manivannan Sadhasivam
2023-06-07  7:12     ` Loic Poulain
2023-06-07  7:41       ` Manivannan Sadhasivam
2023-06-07 12:28         ` Andrew Lunn
2023-06-07 14:19         ` Jeffrey Hugo
2023-06-06 21:22 ` Jakub Kicinski
2023-06-07  7:03   ` Manivannan Sadhasivam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b8a25a70-8781-8b82-96d8-bc1ecf2d5468@quicinc.com \
    --to=quic_jhugo@quicinc.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=loic.poulain@linaro.org \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=mhi@lists.linux.dev \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®