From: "H. Peter Anvin" <hpa@zytor.com>
To: Brice Goglin <brice.goglin@gmail.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
David Airlie <airlied@linux.ie>,
dri-devel@lists.freedesktop.org
Subject: Re: MTRR use in drivers
Date: Sun, 23 Jun 2013 07:07:46 -0700 [thread overview]
Message-ID: <b8bfa877-5663-4a93-94b4-6ea313e4d563@email.android.com> (raw)
In-Reply-To: <51C69732.1010906@gmail.com>
Why do you care about performance when PAT is disabled?
Brice Goglin <brice.goglin@gmail.com> wrote:
>Le 21/06/2013 07:00, H. Peter Anvin a écrit :
>> An awful lot of drivers, mostly DRI drivers, are still mucking with
>> MTRRs directly as opposed to using ioremap_wc() or similar
>interfaces.
>> In addition to the architecture dependency, this is really
>undesirable
>> because MTRRs are a limited resource, whereas page table attributes
>are not.
>>
>> Furthermore, this perpetuates the need for the horrific hack known as
>> "MTRR cleanup".
>>
>> What, if anything, can we do to clean up this mess?
>>
>> -hpa
>>
>
>The first network driver that used ioremap_wc() back in 2008 (myri10ge)
>had to keep using MTRR because ioremap_wc() silently falls back to
>ioremap_nocache() when PAT is disabled.
>
>I asked about this in https://lkml.org/lkml/2008/5/31/42 and there was
>some talk about putting the MTRR addition in the nocache fallback path
>but I guess nobody implemented the idea.
>
>Brice
--
Sent from my mobile phone. Please excuse brevity and lack of formatting.
next prev parent reply other threads:[~2013-06-23 14:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-21 5:00 H. Peter Anvin
2013-06-23 6:35 ` Brice Goglin
2013-06-23 14:07 ` H. Peter Anvin [this message]
2013-06-23 19:29 ` Henrique de Moraes Holschuh
2013-06-23 20:02 ` H. Peter Anvin
2013-06-23 20:30 ` Dave Airlie
2013-06-23 20:38 ` H. Peter Anvin
2013-06-23 20:54 ` Dave Airlie
2013-06-23 20:58 ` H. Peter Anvin
2013-06-23 21:27 ` Dave Airlie
2013-06-23 23:09 ` Andy Lutomirski
2013-06-23 21:56 ` Henrique de Moraes Holschuh
2013-06-23 22:10 ` H. Peter Anvin
2013-06-24 0:02 ` Henrique de Moraes Holschuh
2013-06-24 0:31 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8bfa877-5663-4a93-94b4-6ea313e4d563@email.android.com \
--to=hpa@zytor.com \
--cc=airlied@linux.ie \
--cc=brice.goglin@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®