From: Qing Wang <wangqing7171@gmail.com>
To: xiyou.wangcong@gmail.com
Cc: cwang@multikernel.io, linux-kernel@vger.kernel.org,
mathieu.desnoyers@efficios.com, peterz@infradead.org,
tglx@linutronix.de
Subject: Re: [PATCH] sched: Fix NULL mm dereference in sched_mm_cid_after_execve()
Date: Wed, 31 Dec 2025 01:03:28 +0800 [thread overview]
Message-ID: <b8ce5492-7dd8-4792-b134-b4ccb9187ed4@gmail.com> (raw)
In-Reply-To: <20251223215113.639686-1-xiyou.wangcong@gmail.com>
> void sched_mm_cid_after_execve(struct task_struct *t)
> {
> - sched_mm_cid_fork(t);
> + if (t->mm)
> + sched_mm_cid_fork(t);
> }
Hi,
It's a correct solution, but I have a small suggestion that putting the 'mm'
checking into sched_mm_cid_fork(), just like sched_mm_cid_exit().
Best regards,
Qing Wang
next prev parent reply other threads:[~2025-12-30 17:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-23 21:51 Cong Wang
2025-12-24 14:28 ` Mathieu Desnoyers
2025-12-30 17:03 ` Qing Wang [this message]
2026-01-07 18:00 ` Will Deacon
2026-01-08 15:28 ` Mathieu Desnoyers
2026-01-09 11:53 ` Thomas Gleixner
2026-01-09 13:23 ` Mathieu Desnoyers
2026-01-09 12:05 ` [tip: sched/urgent] sched/mm_cid: Prevent " tip-bot2 for Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8ce5492-7dd8-4792-b134-b4ccb9187ed4@gmail.com \
--to=wangqing7171@gmail.com \
--cc=cwang@multikernel.io \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®