From: "Simmons, James A." <simmonsja@ornl.gov>
To: "'Joe Perches'" <joe@perches.com>,
James Simmons <jsimmons@infradead.org>
Cc: "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
"HPDD-discuss@lists.01.org" <HPDD-discuss@ml01.01.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Oleg Drokin <oleg.drokin@intel.com>,
"lustre-devel@lists.lustre.org" <lustre-devel@lists.lustre.org>
Subject: RE: [lustre-devel] [PATCH v3 6/7] staging:lustre: style cleanups for lib-socket.c
Date: Wed, 3 Jun 2015 17:12:50 +0000 [thread overview]
Message-ID: <b8dcda1e71e843699993f689521336bf@EXCHCS32.ornl.gov> (raw)
In-Reply-To: <1433342574.4861.126.camel@perches.com>
>On Wed, 2015-06-03 at 10:32 -0400, James Simmons wrote:
>> Handle all the style issues reported by checkpatch.pl.
>> Remove general white spaces, spaces in function calls,
>> etc.
>[]
>> @@ -167,13 +164,14 @@ lnet_ipif_enumerate (char ***namesp)
>> if (nalloc * sizeof(*ifr) > PAGE_CACHE_SIZE) {
>> toobig = 1;
>> nalloc = PAGE_CACHE_SIZE/sizeof(*ifr);
>> - CWARN("Too many interfaces: only enumerating first %d\n",
>> - nalloc);
>> + CWARN("Too many interfaces: only enumerating "
>> + "first %d\n", nalloc);
>
>Please don't split single strings into multiple parts.
>
>For a patch like this it'd be nice to specify that both
>"git diff -w" and scripts/objdiff shows no differences.
>
>Unless it does...
Two patches have mistakes. Should I send a new series or do a in-reply instead.
next prev parent reply other threads:[~2015-06-03 17:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-03 14:32 [PATCH v3 0/7] staging:lustre: remove tcpip abstraction from libcfs James Simmons
2015-06-03 14:32 ` [PATCH v3 1/7] staging:lustre: move tcpip abstraction James Simmons
2015-06-03 14:32 ` [PATCH v3 2/7] staging:lustre: remove useless libcfs_sock_release James Simmons
2015-06-03 14:32 ` [PATCH v3 3/7] staging:lustre: remove useless libcfs_sock_abort_accept James Simmons
2015-06-03 14:32 ` [PATCH v3 4/7] staging:lustre: rename tcpip handling functions to lnet_* prefix James Simmons
2015-06-03 16:33 ` Sudip Mukherjee
2015-06-03 16:38 ` [lustre-devel] " Simmons, James A.
2015-06-03 16:42 ` Sudip Mukherjee
2015-06-03 14:32 ` [PATCH v3 5/7] staging:lustre: use available kernel wrappers in lib-socket.c James Simmons
2015-06-03 14:32 ` [PATCH v3 6/7] staging:lustre: style cleanups for lib-socket.c James Simmons
2015-06-03 14:42 ` Joe Perches
2015-06-03 17:12 ` Simmons, James A. [this message]
2015-06-03 17:16 ` [lustre-devel] " Joe Perches
2015-06-03 14:32 ` [PATCH v3 7/7] staging:lustre: Update license and copyright " James Simmons
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8dcda1e71e843699993f689521336bf@EXCHCS32.ornl.gov \
--to=simmonsja@ornl.gov \
--cc=HPDD-discuss@ml01.01.org \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=jsimmons@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lustre-devel@lists.lustre.org \
--cc=oleg.drokin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome