From: Logan Gunthorpe <logang@deltatee.com>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: linux-kernel@vger.kernel.org,
user-mode-linux-devel@lists.sourceforge.net,
Stephen Bates <sbates@raithlin.com>,
Jeff Dike <jdike@addtoit.com>,
Richard Weinberger <richard@nod.at>
Subject: Re: [PATCH] um: add dummy ioremap and iounmap functions
Date: Wed, 24 May 2017 16:09:06 -0600 [thread overview]
Message-ID: <b8de9b34-0f7c-1486-3a64-5b727cef7925@deltatee.com> (raw)
In-Reply-To: <20170524220510.GF390@ZenIV.linux.org.uk>
On 24/05/17 04:05 PM, Al Viro wrote:
>> I have designs to use these functions in scatterlist.c where they'd
>> almost certainly never be called on the um architecture but it does need
>> to compile.
>
> Then make it fail there.
Ok, will do. I'll send a v2 patch shortly.
> Incidentally, s390 has ioremap() only when CONFIG_PCI is set.
Hmm, ok, I'll take a peek. The kbuild robot never reported any build
issues with that architecture. I did see exactly this on the tile
architecture which I sent another patch for (that your feedback also
applies to).
Thanks for the quick review and feedback,
Logan
prev parent reply other threads:[~2017-05-24 22:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-24 22:00 Logan Gunthorpe
2017-05-24 22:05 ` Al Viro
2017-05-24 22:09 ` Logan Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8de9b34-0f7c-1486-3a64-5b727cef7925@deltatee.com \
--to=logang@deltatee.com \
--cc=jdike@addtoit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=richard@nod.at \
--cc=sbates@raithlin.com \
--cc=user-mode-linux-devel@lists.sourceforge.net \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®