From: Roger Quadros <quadros.roger@gmail.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: pHilipp Zabel <philipp.zabel@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regulator: Add GPIO enable control to fixed voltage regulator driver
Date: Fri, 31 Jul 2009 17:34:22 +0300 [thread overview]
Message-ID: <b90c0690907310734g626896e8weccea8acbfaeae30@mail.gmail.com> (raw)
In-Reply-To: <b90c0690907310722w100a6672h769212ddee840192@mail.gmail.com>
On Fri, Jul 31, 2009 at 5:22 PM, Roger Quadros<quadros.roger@gmail.com> wrote:
> On Fri, Jul 31, 2009 at 5:15 PM, Mark
> Brown<broonie@opensource.wolfsonmicro.com> wrote:
>> On Fri, Jul 31, 2009 at 05:13:23PM +0300, Roger Quadros wrote:
>>
>>> OK I got what you meant now. If we use the use_gpio_enable flag then there would
>>> not be any problem even if GPIO is set to 0 ignorantly. Because in
>>> that case use_gpio_enable will
>>> also be set to zero.
>>> So, I feel we should keep use_gpio_enable as it is in the original patch.
>>
>> There's no in-tree users to care about and the use_gpio_enable thing is
>> just ugly - it's not worth carrying it around for ever just for this.
>>
>
> OK. I will remove use_gpio_enable then.
>
Also, if regulator register fails then we should free the GPIO
before goto err_name
prev parent reply other threads:[~2009-07-31 14:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-31 12:55 Roger Quadros
2009-07-31 13:10 ` Mark Brown
2009-07-31 13:25 ` pHilipp Zabel
2009-07-31 13:34 ` Mark Brown
2009-07-31 13:43 ` Roger Quadros
2009-07-31 13:50 ` Mark Brown
[not found] ` <b90c0690907310713w5c8b7fe3l4253f03f78f06491@mail.gmail.com>
[not found] ` <20090731141547.GA6505@rakim.wolfsonmicro.main>
2009-07-31 14:22 ` Roger Quadros
2009-07-31 14:34 ` Roger Quadros [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b90c0690907310734g626896e8weccea8acbfaeae30@mail.gmail.com \
--to=quadros.roger@gmail.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=philipp.zabel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®