mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH 0/2] PM8350B LDO support
@ 2026-07-23 14:53 Esteban Urrutia via B4 Relay
  2026-07-23 14:53 ` [PATCH 1/2] regulator: dt-bindings: qcom,rpmh: Add support for PM8350B Esteban Urrutia via B4 Relay
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Esteban Urrutia via B4 Relay @ 2026-07-23 14:53 UTC (permalink / raw)
  To: Liam Girdwood, Mark Brown, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Bjorn Andersson
  Cc: Krzysztof Kozlowski, linux-arm-msm, linux-kernel, devicetree,
	phone-devel, Esteban Urrutia

The PM8350B PMIC has an LDO regulator which seems to be mostly used for
powering display driver ICs.
On my device's schematics, vdd-l1-supply is represented as VIN_DDIC, and
vdd-l1 is represented as VREG_DDIC.
Downstream this LDO is of type pmic5-ldo and I assume it should be of
type pmic5_nldo upstream, since this is the type of regulator with the
least margin error for the reference voltage, which is 1250-1296mV for
my device.

Signed-off-by: Esteban Urrutia <esteuwu@proton.me>
---
Esteban Urrutia (2):
      regulator: dt-bindings: qcom,rpmh: Add support for PM8350B
      regulator: qcom-rpmh: Add support for PM8350B

 .../devicetree/bindings/regulator/qcom,rpmh-regulator.yaml    | 11 +++++++++++
 drivers/regulator/qcom-rpmh-regulator.c                       |  9 +++++++++
 2 files changed, 20 insertions(+)
---
base-commit: b4515cf4156356e8f4fe6e0fdc17f59adab9772f
change-id: 20260723-pm8350b-ldo-7822bafd6e5c

Best regards,
--  
Esteban Urrutia <esteuwu@proton.me>



^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 1/2] regulator: dt-bindings: qcom,rpmh: Add support for PM8350B
  2026-07-23 14:53 [PATCH 0/2] PM8350B LDO support Esteban Urrutia via B4 Relay
@ 2026-07-23 14:53 ` Esteban Urrutia via B4 Relay
  2026-07-24  9:55   ` Krzysztof Kozlowski
  2026-07-23 14:53 ` [PATCH 2/2] regulator: qcom-rpmh: " Esteban Urrutia via B4 Relay
  2026-07-28 18:56 ` [PATCH 0/2] PM8350B LDO support Mark Brown
  2 siblings, 1 reply; 6+ messages in thread
From: Esteban Urrutia via B4 Relay @ 2026-07-23 14:53 UTC (permalink / raw)
  To: Liam Girdwood, Mark Brown, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Bjorn Andersson
  Cc: Krzysztof Kozlowski, linux-arm-msm, linux-kernel, devicetree,
	phone-devel, Esteban Urrutia

From: Esteban Urrutia <esteuwu@proton.me>

The PM8350B has only one LDO, which gets its power from a dedicated input.
Add support for it.

Signed-off-by: Esteban Urrutia <esteuwu@proton.me>
---
 .../devicetree/bindings/regulator/qcom,rpmh-regulator.yaml    | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml b/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml
index d93594304651..eed2ce7fa861 100644
--- a/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml
+++ b/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml
@@ -47,6 +47,7 @@ description: |
       For PM8150, smps1 - smps10, ldo1 - ldo18
       For PM8150L, smps1 - smps8, ldo1 - ldo11, bob, flash, rgb
       For PM8350, smps1 - smps12, ldo1 - ldo10
+      For PM8350B, ldo1
       For PM8350C, smps1 - smps10, ldo1 - ldo13, bob
       For PM8450, smps1 - smps6, ldo1 - ldo4
       For PM8550, smps1 - smps6, ldo1 - ldo17, bob1 - bob2
@@ -82,6 +83,7 @@ properties:
       - qcom,pm8150-rpmh-regulators
       - qcom,pm8150l-rpmh-regulators
       - qcom,pm8350-rpmh-regulators
+      - qcom,pm8350b-rpmh-regulators
       - qcom,pm8350c-rpmh-regulators
       - qcom,pm8450-rpmh-regulators
       - qcom,pm8550-rpmh-regulators
@@ -337,6 +339,15 @@ allOf:
       patternProperties:
         "^vdd-s([1-9]|1[0-2])-supply$": true
 
+  - if:
+      properties:
+        compatible:
+          enum:
+            - qcom,pm8350b-rpmh-regulators
+    then:
+      properties:
+        vdd-l1-supply: true
+
   - if:
       properties:
         compatible:

-- 
2.55.0



^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 2/2] regulator: qcom-rpmh: Add support for PM8350B
  2026-07-23 14:53 [PATCH 0/2] PM8350B LDO support Esteban Urrutia via B4 Relay
  2026-07-23 14:53 ` [PATCH 1/2] regulator: dt-bindings: qcom,rpmh: Add support for PM8350B Esteban Urrutia via B4 Relay
@ 2026-07-23 14:53 ` Esteban Urrutia via B4 Relay
  2026-07-24 11:57   ` Konrad Dybcio
  2026-07-28 18:56 ` [PATCH 0/2] PM8350B LDO support Mark Brown
  2 siblings, 1 reply; 6+ messages in thread
From: Esteban Urrutia via B4 Relay @ 2026-07-23 14:53 UTC (permalink / raw)
  To: Liam Girdwood, Mark Brown, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Bjorn Andersson
  Cc: Krzysztof Kozlowski, linux-arm-msm, linux-kernel, devicetree,
	phone-devel, Esteban Urrutia

From: Esteban Urrutia <esteuwu@proton.me>

The PM8350B has only one LDO, which gets its power from a dedicated input.
Add support for it.

Signed-off-by: Esteban Urrutia <esteuwu@proton.me>
---
 drivers/regulator/qcom-rpmh-regulator.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/drivers/regulator/qcom-rpmh-regulator.c b/drivers/regulator/qcom-rpmh-regulator.c
index 756a4201225e..73856e3df337 100644
--- a/drivers/regulator/qcom-rpmh-regulator.c
+++ b/drivers/regulator/qcom-rpmh-regulator.c
@@ -1269,6 +1269,11 @@ static const struct rpmh_vreg_init_data pm8350_vreg_data[] = {
 	{}
 };
 
+static const struct rpmh_vreg_init_data pm8350b_vreg_data[] = {
+	RPMH_VREG("ldo1",   LDO,  1,  &pmic5_nldo,      "vdd-l1"),
+	{}
+};
+
 static const struct rpmh_vreg_init_data pm8350c_vreg_data[] = {
 	RPMH_VREG("smps1",  SMPS, 1,  &pmic5_hfsmps515, "vdd-s1"),
 	RPMH_VREG("smps2",  SMPS, 2,  &pmic5_ftsmps510, "vdd-s2"),
@@ -1868,6 +1873,10 @@ static const struct of_device_id __maybe_unused rpmh_regulator_match_table[] = {
 		.compatible = "qcom,pm8350-rpmh-regulators",
 		.data = pm8350_vreg_data,
 	},
+	{
+		.compatible = "qcom,pm8350b-rpmh-regulators",
+		.data = pm8350b_vreg_data,
+	},
 	{
 		.compatible = "qcom,pm8350c-rpmh-regulators",
 		.data = pm8350c_vreg_data,

-- 
2.55.0



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/2] regulator: dt-bindings: qcom,rpmh: Add support for PM8350B
  2026-07-23 14:53 ` [PATCH 1/2] regulator: dt-bindings: qcom,rpmh: Add support for PM8350B Esteban Urrutia via B4 Relay
@ 2026-07-24  9:55   ` Krzysztof Kozlowski
  0 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2026-07-24  9:55 UTC (permalink / raw)
  To: Esteban Urrutia
  Cc: Liam Girdwood, Mark Brown, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Bjorn Andersson, linux-arm-msm, linux-kernel,
	devicetree, phone-devel

On Thu, Jul 23, 2026 at 10:53:52AM -0400, Esteban Urrutia wrote:
> The PM8350B has only one LDO, which gets its power from a dedicated input.
> Add support for it.
> 
> Signed-off-by: Esteban Urrutia <esteuwu@proton.me>
> ---
>  .../devicetree/bindings/regulator/qcom,rpmh-regulator.yaml    | 11 +++++++++++
>  1 file changed, 11 insertions(+)

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 2/2] regulator: qcom-rpmh: Add support for PM8350B
  2026-07-23 14:53 ` [PATCH 2/2] regulator: qcom-rpmh: " Esteban Urrutia via B4 Relay
@ 2026-07-24 11:57   ` Konrad Dybcio
  0 siblings, 0 replies; 6+ messages in thread
From: Konrad Dybcio @ 2026-07-24 11:57 UTC (permalink / raw)
  To: esteuwu, Liam Girdwood, Mark Brown, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson
  Cc: Krzysztof Kozlowski, linux-arm-msm, linux-kernel, devicetree,
	phone-devel

On 7/23/26 4:53 PM, Esteban Urrutia via B4 Relay wrote:
> From: Esteban Urrutia <esteuwu@proton.me>
> 
> The PM8350B has only one LDO, which gets its power from a dedicated input.
> Add support for it.
> 
> Signed-off-by: Esteban Urrutia <esteuwu@proton.me>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 0/2] PM8350B LDO support
  2026-07-23 14:53 [PATCH 0/2] PM8350B LDO support Esteban Urrutia via B4 Relay
  2026-07-23 14:53 ` [PATCH 1/2] regulator: dt-bindings: qcom,rpmh: Add support for PM8350B Esteban Urrutia via B4 Relay
  2026-07-23 14:53 ` [PATCH 2/2] regulator: qcom-rpmh: " Esteban Urrutia via B4 Relay
@ 2026-07-28 18:56 ` Mark Brown
  2 siblings, 0 replies; 6+ messages in thread
From: Mark Brown @ 2026-07-28 18:56 UTC (permalink / raw)
  To: Liam Girdwood, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Bjorn Andersson, Esteban Urrutia
  Cc: Krzysztof Kozlowski, linux-arm-msm, linux-kernel, devicetree,
	phone-devel

On Thu, 23 Jul 2026 10:53:51 -0400, Esteban Urrutia wrote:
> PM8350B LDO support
> 
> The PM8350B PMIC has an LDO regulator which seems to be mostly used for
> powering display driver ICs.
> On my device's schematics, vdd-l1-supply is represented as VIN_DDIC, and
> vdd-l1 is represented as VREG_DDIC.
> Downstream this LDO is of type pmic5-ldo and I assume it should be of
> type pmic5_nldo upstream, since this is the type of regulator with the
> least margin error for the reference voltage, which is 1250-1296mV for
> my device.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-7.2

Thanks!

[1/2] regulator: dt-bindings: qcom,rpmh: Add support for PM8350B
      https://git.kernel.org/broonie/regulator/c/90b5df5bf0a1
[2/2] regulator: qcom-rpmh: Add support for PM8350B
      https://git.kernel.org/broonie/regulator/c/6753251cfc96

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2026-07-29 13:32 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-07-23 14:53 [PATCH 0/2] PM8350B LDO support Esteban Urrutia via B4 Relay
2026-07-23 14:53 ` [PATCH 1/2] regulator: dt-bindings: qcom,rpmh: Add support for PM8350B Esteban Urrutia via B4 Relay
2026-07-24  9:55   ` Krzysztof Kozlowski
2026-07-23 14:53 ` [PATCH 2/2] regulator: qcom-rpmh: " Esteban Urrutia via B4 Relay
2026-07-24 11:57   ` Konrad Dybcio
2026-07-28 18:56 ` [PATCH 0/2] PM8350B LDO support Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®