mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: David Frey <dpfrey@gmail.com>,
	linux kernel <linux-kernel@vger.kernel.org>
Subject: Re: Seeking guidance on spelling fixes
Date: Sun, 18 Feb 2018 09:00:25 -0800	[thread overview]
Message-ID: <b94c703e-fd4c-0273-cdff-391f99ded3ee@infradead.org> (raw)
In-Reply-To: <7912182.YNFVRYok70@roach>

On 02/18/2018 07:34 AM, David Frey wrote:
> I noticed a common spelling mistake in some Linux kernel code that I was
> reading the other day and it made me wonder how prevalent common spelling
> mistakes are in the kernel.  I did some grepping and it seems that there
> are a large number of spelling mistakes.  I did a bit of searching and I
> found (http://www.kegel.com/kerspell/) which includes some comments/tools
> relating to spelling and the Linux kernel.
> 
> I have gone ahead and corrected about 100 total instances based on 25
> common misspellings.  There are many, many more common misspellings that I
> could check, but I don't want to sink more time into this if the changes
> won't be accepted.
> 
> Is this type of change likely to be accepted?  Right now I am making
> individual git commits for each correction.  For example "aditional ->
> additional".  I figured that it would be easier to review the list of
> replacements rather than a mega-patch which fixes many different errors.
> This way if any of the changes are controversial, I can easily rebase them
> out.
> 
> I am trying to only correct true misspellings.  I'm not trying to choose
> the "most correct" spelling for cases where there are acceptable alternate
> spellings.
> 
> I've pushed the changes I have made so far to a "spelling_fixes" branch
> here: https://github.com/dpfrey/linux/commits/spelling_fixes just in case
> there is any question about what I am doing based on the above description.
> 
> Just to be clear, I'm not trying to get this portion of the work merged at
> this point.  I'm trying to get a feel for whether I should keep working on
> this.

I can't answer for others, of course, but fixing spelling in user-visible
messages will usually be accepted/merged (e.g., error messages or Kconfig
help text).  I looked at a few of the commits and they are fixes in comments.
I would accept them, but I'm not a maintainer, just a contributor.

thanks,
-- 
~Randy

  reply	other threads:[~2018-02-18 17:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-18 15:34 David Frey
2018-02-18 17:00 ` Randy Dunlap [this message]
2018-02-18 17:15 ` Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b94c703e-fd4c-0273-cdff-391f99ded3ee@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=dpfrey@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®