[PATCH v2] clk: qcom: Fix error checking for devm_clk_hw_get_clk()

[PATCH v2] clk: qcom: Fix error checking for devm_clk_hw_get_clk()

[Yan Zhen]

The devm_clk_hw_get_clk() function returns error pointers.
It never returns NULL.  Update the check accordingly.


Signed-off-by: Yan Zhen <yanzhen@vivo.com>
---

Changes in v2:
- Return PTR_ERR(icd[i].clk) instead of -ENOENT.

 drivers/clk/qcom/common.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/clk/qcom/common.c b/drivers/clk/qcom/common.c
index 33cc1f73c69d..5a9e653916ea 100644
--- a/drivers/clk/qcom/common.c
+++ b/drivers/clk/qcom/common.c
@@ -273,8 +273,8 @@ static int qcom_cc_icc_register(struct device *dev,
 		icd[i].slave_id = desc->icc_hws[i].slave_id;
 		hws = &desc->clks[desc->icc_hws[i].clk_id]->hw;
 		icd[i].clk = devm_clk_hw_get_clk(dev, hws, "icc");
-		if (!icd[i].clk)
-			return dev_err_probe(dev, -ENOENT,
+		if (IS_ERR(icd[i].clk))
+			return dev_err_probe(dev, PTR_ERR(icd[i].clk),
 					     "(%d) clock entry is null\n", i);
 		icd[i].name = clk_hw_get_name(hws);
 	}
-- 
2.34.1

Re: [PATCH v2] clk: qcom: Fix error checking for devm_clk_hw_get_clk()

[Markus Elfring]

> The devm_clk_hw_get_clk() function returns error pointers.
> It never returns NULL.  Update the check accordingly.

Would you like to add any tags (like “Fixes” and “Cc”)?

Regards,
Markus

Re: [PATCH v2] clk: qcom: Fix error checking for devm_clk_hw_get_clk()

[Dmitry Baryshkov]

On Mon, Aug 26, 2024 at 02:17:17PM GMT, Yan Zhen wrote:
> The devm_clk_hw_get_clk() function returns error pointers.
> It never returns NULL.  Update the check accordingly.
> 
> 
> Signed-off-by: Yan Zhen <yanzhen@vivo.com>
> ---
> 
> Changes in v2:
> - Return PTR_ERR(icd[i].clk) instead of -ENOENT.
> 


Fixes: 8737ec830ee3 ("clk: qcom: common: Add interconnect clocks support")
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>


-- 
With best wishes
Dmitry