* [PATCH] rpmsg: qcom_smd: Fix irq_of_parse_and_map() return value
@ 2022-04-22 10:53 Krzysztof Kozlowski
2022-04-23 3:46 ` (subset) " Bjorn Andersson
0 siblings, 1 reply; 3+ messages in thread
From: Krzysztof Kozlowski @ 2022-04-22 10:53 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Mathieu Poirier, linux-arm-msm,
linux-remoteproc, linux-kernel
Cc: Krzysztof Kozlowski
The irq_of_parse_and_map() returns 0 on failure, not a negative ERRNO.
Fixes: 53e2822e56c7 ("rpmsg: Introduce Qualcomm SMD backend")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
drivers/rpmsg/qcom_smd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/rpmsg/qcom_smd.c b/drivers/rpmsg/qcom_smd.c
index 764c980507be..6ccfa12abd10 100644
--- a/drivers/rpmsg/qcom_smd.c
+++ b/drivers/rpmsg/qcom_smd.c
@@ -1407,7 +1407,7 @@ static int qcom_smd_parse_edge(struct device *dev,
edge->name = node->name;
irq = irq_of_parse_and_map(node, 0);
- if (irq < 0) {
+ if (!irq) {
dev_err(dev, "required smd interrupt missing\n");
ret = irq;
goto put_node;
--
2.32.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: (subset) [PATCH] rpmsg: qcom_smd: Fix irq_of_parse_and_map() return value
2022-04-22 10:53 [PATCH] rpmsg: qcom_smd: Fix irq_of_parse_and_map() return value Krzysztof Kozlowski
@ 2022-04-23 3:46 ` Bjorn Andersson
2022-04-23 9:30 ` Krzysztof Kozlowski
0 siblings, 1 reply; 3+ messages in thread
From: Bjorn Andersson @ 2022-04-23 3:46 UTC (permalink / raw)
To: linux-kernel, Krzysztof Kozlowski, linux-arm-msm, Andy Gross,
Mathieu Poirier, linux-remoteproc
On Fri, 22 Apr 2022 12:53:26 +0200, Krzysztof Kozlowski wrote:
> The irq_of_parse_and_map() returns 0 on failure, not a negative ERRNO.
>
>
Applied, thanks!
[1/1] rpmsg: qcom_smd: Fix irq_of_parse_and_map() return value
commit: 1a358d35066487d228a68303d808bc4721c6b1b9
Best regards,
--
Bjorn Andersson <bjorn.andersson@linaro.org>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: (subset) [PATCH] rpmsg: qcom_smd: Fix irq_of_parse_and_map() return value
2022-04-23 3:46 ` (subset) " Bjorn Andersson
@ 2022-04-23 9:30 ` Krzysztof Kozlowski
0 siblings, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2022-04-23 9:30 UTC (permalink / raw)
To: Bjorn Andersson, linux-kernel, linux-arm-msm, Andy Gross,
Mathieu Poirier, linux-remoteproc
On 23/04/2022 05:46, Bjorn Andersson wrote:
> On Fri, 22 Apr 2022 12:53:26 +0200, Krzysztof Kozlowski wrote:
>> The irq_of_parse_and_map() returns 0 on failure, not a negative ERRNO.
>>
>>
>
> Applied, thanks!
>
> [1/1] rpmsg: qcom_smd: Fix irq_of_parse_and_map() return value
> commit: 1a358d35066487d228a68303d808bc4721c6b1b9
Thanks, unfortunately Jakub Kicinski pointed out issue with returning 0
later, which needs a fix. I'll send a fix which can be squashed.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-04-23 9:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-22 10:53 [PATCH] rpmsg: qcom_smd: Fix irq_of_parse_and_map() return value Krzysztof Kozlowski
2022-04-23 3:46 ` (subset) " Bjorn Andersson
2022-04-23 9:30 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®