From: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
Andrzej Hajda <andrzej.hajda@intel.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Robert Foss <rfoss@kernel.org>, Jonas Karlman <jonas@kwiboo.se>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Magnus Damm <magnus.damm@gmail.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
LUU HOAI <hoai.luu.ub@renesas.com>,
Jagan Teki <jagan@amarulasolutions.com>,
Sam Ravnborg <sam@ravnborg.org>,
Biju Das <biju.das.jz@bp.renesas.com>,
dri-devel@lists.freedesktop.org,
linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com>
Subject: Re: [PATCH 8/9] arm64: dts: renesas: r8a779h0: Add display support
Date: Wed, 4 Dec 2024 18:04:50 +0200 [thread overview]
Message-ID: <b9a07779-34c3-496f-ac04-d7f6e1e61d82@ideasonboard.com> (raw)
In-Reply-To: <20241203093703.GL10736@pendragon.ideasonboard.com>
Hi,
On 03/12/2024 11:37, Laurent Pinchart wrote:
> Hi Tomi,
>
> Thank you for the patch.
>
> On Tue, Dec 03, 2024 at 10:01:42AM +0200, Tomi Valkeinen wrote:
>> From: Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com>
>>
>> Add the device nodes for supporting DU and DSI.
>>
>> Signed-off-by: Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com>
>> ---
>> arch/arm64/boot/dts/renesas/r8a779h0.dtsi | 77 +++++++++++++++++++++++++++++++
>> 1 file changed, 77 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/renesas/r8a779h0.dtsi b/arch/arm64/boot/dts/renesas/r8a779h0.dtsi
>> index 12d8be3fd579..82df6ee98afb 100644
>> --- a/arch/arm64/boot/dts/renesas/r8a779h0.dtsi
>> +++ b/arch/arm64/boot/dts/renesas/r8a779h0.dtsi
>> @@ -1828,6 +1828,54 @@ csi41isp1: endpoint {
>> };
>> };
>>
>> + fcpvd0: fcp@fea10000 {
>> + compatible = "renesas,fcpv";
>> + reg = <0 0xfea10000 0 0x200>;
>> + clocks = <&cpg CPG_MOD 508>;
>> + power-domains = <&sysc R8A779H0_PD_C4>;
>> + resets = <&cpg 508>;
>> + };
>> +
>> + vspd0: vsp@fea20000 {
>> + compatible = "renesas,vsp2";
>> + reg = <0 0xfea20000 0 0x8000>;
>> + interrupts = <GIC_SPI 546 IRQ_TYPE_LEVEL_HIGH>;
>
> The documentation lists this interrupt as being LevelSensitive and
> Negative. I wouldn't expect the VSP to work at all with a wrong polarity
> in DT, so the level may get inverted somewhere.
Indeed... It's the same for V4H. And it also has IRQ_TYPE_LEVEL_HIGH in
the dts. I tried changing it to LOW on V4H, but:
genirq: Setting trigger mode 8 for irq 91 failed
vsp1 fea20000.vsp: failed to request IRQ
I didn't dig further yet.
>> + clocks = <&cpg CPG_MOD 830>;
>> + power-domains = <&sysc R8A779H0_PD_C4>;
>> + resets = <&cpg 830>;
>> + renesas,fcp = <&fcpvd0>;
>> + };
>> +
>> + du: display@feb00000 {
>> + compatible = "renesas,du-r8a779h0";
>> + reg = <0 0xfeb00000 0 0x40000>;
>> + interrupts = <GIC_SPI 523 IRQ_TYPE_LEVEL_HIGH>;
>> + clocks = <&cpg CPG_MOD 411>;
>> + clock-names = "du.0";
>> + power-domains = <&sysc R8A779H0_PD_C4>;
>> + resets = <&cpg 411>;
>> + reset-names = "du.0";
>> + renesas,vsps = <&vspd0 0>;
>> +
>> + status = "disabled";
>> +
>> + ports {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + port@0 {
>> + reg = <0>;
>> + du_out_dsi0: endpoint {
>> + remote-endpoint = <&dsi0_in>;
>> + };
>> + };
>> +
>> + port@1 {
>> + reg = <1>;
>> + };
>
> On V4M the DU has a single channel, so there should be a single port.
Yep, I'll drop.
Tomi
> Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
>
>> + };
>> + };
>> +
>> isp0: isp@fed00000 {
>> compatible = "renesas,r8a779h0-isp",
>> "renesas,rcar-gen4-isp";
>> @@ -1996,6 +2044,35 @@ isp1vin15: endpoint {
>> };
>> };
>>
>> + dsi0: dsi-encoder@fed80000 {
>> + compatible = "renesas,r8a779h0-dsi-csi2-tx";
>> + reg = <0 0xfed80000 0 0x10000>;
>> + clocks = <&cpg CPG_MOD 415>,
>> + <&cpg CPG_CORE R8A779H0_CLK_DSIEXT>,
>> + <&cpg CPG_CORE R8A779H0_CLK_DSIREF>;
>> + clock-names = "fck", "dsi", "pll";
>> + power-domains = <&sysc R8A779H0_PD_C4>;
>> + resets = <&cpg 415>;
>> +
>> + status = "disabled";
>> +
>> + ports {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + port@0 {
>> + reg = <0>;
>> + dsi0_in: endpoint {
>> + remote-endpoint = <&du_out_dsi0>;
>> + };
>> + };
>> +
>> + port@1 {
>> + reg = <1>;
>> + };
>> + };
>> + };
>> +
>> prr: chipid@fff00044 {
>> compatible = "renesas,prr";
>> reg = <0 0xfff00044 0 4>;
>
next prev parent reply other threads:[~2024-12-04 16:04 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-03 8:01 [PATCH 0/9] drm: Add DSI/DP support for Renesas r8a779h0 V4M and grey-hawk board Tomi Valkeinen
2024-12-03 8:01 ` [PATCH 1/9] dt-bindings: display: bridge: renesas,dsi-csi2-tx: Add r8a779h0 Tomi Valkeinen
2024-12-03 8:17 ` Laurent Pinchart
2024-12-04 8:32 ` Krzysztof Kozlowski
2024-12-03 8:01 ` [PATCH 2/9] dt-bindings: display: renesas,du: " Tomi Valkeinen
2024-12-03 8:19 ` Laurent Pinchart
2024-12-03 8:23 ` Tomi Valkeinen
2024-12-03 8:38 ` Geert Uytterhoeven
2024-12-03 8:50 ` Laurent Pinchart
2024-12-03 8:01 ` [PATCH 3/9] clk: renesas: r8a779h0: Add display clocks Tomi Valkeinen
2024-12-03 8:37 ` Laurent Pinchart
2024-12-03 8:01 ` [PATCH 4/9] drm/rcar-du: dsi: Fix PHY lock bit check Tomi Valkeinen
2024-12-03 8:48 ` Laurent Pinchart
2024-12-03 8:01 ` [PATCH 5/9] drm/rcar-du: dsi: Add r8a779h0 support Tomi Valkeinen
2024-12-03 8:51 ` Laurent Pinchart
2024-12-03 8:01 ` [PATCH 6/9] drm/rcar-du: Add support for r8a779h0 Tomi Valkeinen
2024-12-03 8:56 ` Laurent Pinchart
2024-12-03 9:22 ` Tomi Valkeinen
2024-12-03 10:48 ` Laurent Pinchart
2024-12-05 5:41 ` Tomi Valkeinen
2024-12-05 8:48 ` Laurent Pinchart
2024-12-03 8:01 ` [PATCH 7/9] arm64: dts: renesas: gray-hawk-single: Fix indentation Tomi Valkeinen
2024-12-03 8:57 ` Laurent Pinchart
2024-12-03 8:01 ` [PATCH 8/9] arm64: dts: renesas: r8a779h0: Add display support Tomi Valkeinen
2024-12-03 9:37 ` Laurent Pinchart
2024-12-04 16:04 ` Tomi Valkeinen [this message]
2024-12-04 19:20 ` Geert Uytterhoeven
2024-12-03 8:01 ` [PATCH 9/9] arm64: dts: renesas: gray-hawk-single: Add DisplayPort support Tomi Valkeinen
2024-12-03 10:40 ` Laurent Pinchart
2024-12-04 8:00 ` [PATCH 0/9] drm: Add DSI/DP support for Renesas r8a779h0 V4M and grey-hawk board Geert Uytterhoeven
2024-12-04 8:30 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9a07779-34c3-496f-ac04-d7f6e1e61d82@ideasonboard.com \
--to=tomi.valkeinen@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=andrzej.hajda@intel.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert+renesas@glider.be \
--cc=hoai.luu.ub@renesas.com \
--cc=jagan@amarulasolutions.com \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=krzk+dt@kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=magnus.damm@gmail.com \
--cc=mripard@kernel.org \
--cc=mturquette@baylibre.com \
--cc=neil.armstrong@linaro.org \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=sam@ravnborg.org \
--cc=sboyd@kernel.org \
--cc=simona@ffwll.ch \
--cc=tomi.valkeinen+renesas@ideasonboard.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®