mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] ASoC: Intel: SST: Publish the PCI module aliases
@ 2026-09-05 13:31 hpp.iscas
  2026-09-07 16:49 ` Mark Brown
  2026-09-08 17:39 ` Cezary Rojewski
  0 siblings, 2 replies; 3+ messages in thread
From: hpp.iscas @ 2026-09-05 13:31 UTC (permalink / raw)
  To: Cezary Rojewski
  Cc: hpp.iscas, Liam Girdwood, Peter Ujfalusi, Bard Liao,
	Kai Vehmanen, Pierre-Louis Bossart, Mark Brown, Jaroslav Kysela,
	Takashi Iwai, linux-sound, linux-kernel, Vinod Koul

The legacy SST PCI driver matches Intel Tangier devices using
intel_sst_ids, but its only explicit module alias is "sst". That alias
does not match PCI modalias events when this driver is built as a module.

Publish its PCI table. The independently configurable SOF driver does
not provide aliases for the legacy SST module.

Fixes: f533a035e4da ("ASoC: Intel: mrfld - create separate module for pci part")
Signed-off-by: hpp.iscas <hppiscas@163.com>
---
 sound/soc/intel/atom/sst/sst_pci.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/soc/intel/atom/sst/sst_pci.c b/sound/soc/intel/atom/sst/sst_pci.c
index 44bb11c..1a53c99 100644
--- a/sound/soc/intel/atom/sst/sst_pci.c
+++ b/sound/soc/intel/atom/sst/sst_pci.c
@@ -167,6 +167,7 @@ static const struct pci_device_id intel_sst_ids[] = {
 	{ PCI_DEVICE_DATA(INTEL, SST_TNG, 0) },
 	{ 0, }
 };
+MODULE_DEVICE_TABLE(pci, intel_sst_ids);
 
 static struct pci_driver sst_driver = {
 	.name = SST_DRV_NAME,


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ASoC: Intel: SST: Publish the PCI module aliases
  2026-09-05 13:31 [PATCH] ASoC: Intel: SST: Publish the PCI module aliases hpp.iscas
@ 2026-09-07 16:49 ` Mark Brown
  2026-09-08 17:39 ` Cezary Rojewski
  1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2026-09-07 16:49 UTC (permalink / raw)
  To: Cezary Rojewski, hpp.iscas
  Cc: Liam Girdwood, Peter Ujfalusi, Bard Liao, Kai Vehmanen,
	Pierre-Louis Bossart, Jaroslav Kysela, Takashi Iwai, linux-sound,
	linux-kernel, Vinod Koul

On Sat, 05 Sep 2026 21:31:33 +0800, hpp.iscas wrote:
> ASoC: Intel: SST: Publish the PCI module aliases

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-7.3

Thanks!

[1/1] ASoC: Intel: SST: Publish the PCI module aliases
      https://git.kernel.org/broonie/sound/c/d112159df5c6

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ASoC: Intel: SST: Publish the PCI module aliases
  2026-09-05 13:31 [PATCH] ASoC: Intel: SST: Publish the PCI module aliases hpp.iscas
  2026-09-07 16:49 ` Mark Brown
@ 2026-09-08 17:39 ` Cezary Rojewski
  1 sibling, 0 replies; 3+ messages in thread
From: Cezary Rojewski @ 2026-09-08 17:39 UTC (permalink / raw)
  To: hpp.iscas
  Cc: Liam Girdwood, Peter Ujfalusi, Bard Liao, Kai Vehmanen,
	Pierre-Louis Bossart, Mark Brown, Jaroslav Kysela, Takashi Iwai,
	linux-sound, linux-kernel, Vinod Koul

On 9/5/2026 3:31 PM, hpp.iscas wrote:
> The legacy SST PCI driver matches Intel Tangier devices using
> 
> intel_sst_ids, but its only explicit module alias is "sst". That alias
> 
> does not match PCI modalias events when this driver is built as a module.
> 
> 
> 
> Publish its PCI table. The independently configurable SOF driver does
> 
> not provide aliases for the legacy SST module.
> 
> 
> 
> Fixes: f533a035e4da ("ASoC: Intel: mrfld - create separate module for pci part")
> 
> Signed-off-by: hpp.iscas <hppiscas@163.com>
At least on my side the entire patch is weirdly spaced. Also, I'd expect
'Name Surname <email>' format in the Signed-off-by tag. "hpp.iscas"
looks more like a nickname.

Kind regards,
Czarek

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-09-08 17:39 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-05 13:31 [PATCH] ASoC: Intel: SST: Publish the PCI module aliases hpp.iscas
2026-09-07 16:49 ` Mark Brown
2026-09-08 17:39 ` Cezary Rojewski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®