mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] platform/x86/amd/pmc: Add LG Ultra PC 16U70Q to quirks list
@ 2026-10-29 23:24 Carlos Baiget Orts via B4 Relay
  2026-10-30 14:13 ` Mario Limonciello
  0 siblings, 1 reply; 2+ messages in thread
From: Carlos Baiget Orts via B4 Relay @ 2026-10-29 23:24 UTC (permalink / raw)
  To: Shyam Sundar S K, Hans de Goede, Ilpo Järvinen
  Cc: platform-driver-x86, linux-kernel, Mario Limonciello, Carlos Baiget Orts

From: Carlos Baiget Orts <asinfreedom@gmail.com>

The LG Ultra PC 16U70Q (Ryzen 7 5825U) spends ~5 seconds in the noirq
resume phase on every s2idle resume. This is the same NVMe SMI handler
issue seen on other Cezanne systems. Skipping it with s2idle_bug_mmio
brings it down to ~32 ms.

As on the other Cezanne systems, the entry must also keep the spurious
IRQ1 (8042) wakeup workaround. Otherwise the system wakes up immediately
from s2idle, so use quirk_s2idle_spurious_8042.

Link: https://gitlab.freedesktop.org/drm/amd/-/issues/6021
Cc: Mario Limonciello <mario.limonciello@amd.com>
Assisted-by: Claude:claude-opus-5-5
Signed-off-by: Carlos Baiget Orts <asinfreedom@gmail.com>
---
Tested on the 16U70Q (BIOS L2UG0160) with a locally built amd_pmc
carrying this entry: noirq resume drops from ~5.2 s to ~32 ms, and
s2idle no longer wakes up immediately from spurious IRQ1 events.
---
 drivers/platform/x86/amd/pmc/pmc-quirks.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/drivers/platform/x86/amd/pmc/pmc-quirks.c b/drivers/platform/x86/amd/pmc/pmc-quirks.c
index fed6c51879..ca188d815c 100644
--- a/drivers/platform/x86/amd/pmc/pmc-quirks.c
+++ b/drivers/platform/x86/amd/pmc/pmc-quirks.c
@@ -386,6 +386,15 @@ static const struct dmi_system_id fwbug_list[] = {
 			DMI_MATCH(DMI_BOARD_NAME, "WUJIE Series-X5SP4NAG"),
 		}
 	},
+	/* https://gitlab.freedesktop.org/drm/amd/-/issues/6021 */
+	{
+		.ident = "LG Ultra PC 16U70Q",
+		.driver_data = &quirk_s2idle_spurious_8042,
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "LG Electronics"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "16U70Q"),
+		}
+	},
 	{}
 };
 

---
base-commit: c339f4010dea8b0d754f84ace70cd1b089878ef8
change-id: 20261029-lg-16u70q-quirk-fae864db4054

Best regards,
-- 
Carlos Baiget Orts <asinfreedom@gmail.com>



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] platform/x86/amd/pmc: Add LG Ultra PC 16U70Q to quirks list
  2026-10-29 23:24 [PATCH] platform/x86/amd/pmc: Add LG Ultra PC 16U70Q to quirks list Carlos Baiget Orts via B4 Relay
@ 2026-10-30 14:13 ` Mario Limonciello
  0 siblings, 0 replies; 2+ messages in thread
From: Mario Limonciello @ 2026-10-30 14:13 UTC (permalink / raw)
  To: asinfreedom, Shyam Sundar S K, Hans de Goede, Ilpo Järvinen
  Cc: platform-driver-x86, linux-kernel



On 10/29/26 18:24, Carlos Baiget Orts via B4 Relay wrote:
> From: Carlos Baiget Orts <asinfreedom@gmail.com>
> 
> The LG Ultra PC 16U70Q (Ryzen 7 5825U) spends ~5 seconds in the noirq
> resume phase on every s2idle resume. This is the same NVMe SMI handler
> issue seen on other Cezanne systems. Skipping it with s2idle_bug_mmio
> brings it down to ~32 ms.
> 
> As on the other Cezanne systems, the entry must also keep the spurious
> IRQ1 (8042) wakeup workaround. Otherwise the system wakes up immediately
> from s2idle, so use quirk_s2idle_spurious_8042.
> 
> Link: https://gitlab.freedesktop.org/drm/amd/-/issues/6021
> Cc: Mario Limonciello <mario.limonciello@amd.com>
> Assisted-by: Claude:claude-opus-5-5
> Signed-off-by: Carlos Baiget Orts <asinfreedom@gmail.com>
> ---

Reviewed-by: Mario Limonciello (AMD) <superm1@kernel.org>

> Tested on the 16U70Q (BIOS L2UG0160) with a locally built amd_pmc
> carrying this entry: noirq resume drops from ~5.2 s to ~32 ms, and
> s2idle no longer wakes up immediately from spurious IRQ1 events.
> ---
>   drivers/platform/x86/amd/pmc/pmc-quirks.c | 9 +++++++++
>   1 file changed, 9 insertions(+)
> 
> diff --git a/drivers/platform/x86/amd/pmc/pmc-quirks.c b/drivers/platform/x86/amd/pmc/pmc-quirks.c
> index fed6c51879..ca188d815c 100644
> --- a/drivers/platform/x86/amd/pmc/pmc-quirks.c
> +++ b/drivers/platform/x86/amd/pmc/pmc-quirks.c
> @@ -386,6 +386,15 @@ static const struct dmi_system_id fwbug_list[] = {
>   			DMI_MATCH(DMI_BOARD_NAME, "WUJIE Series-X5SP4NAG"),
>   		}
>   	},
> +	/* https://gitlab.freedesktop.org/drm/amd/-/issues/6021 */
> +	{
> +		.ident = "LG Ultra PC 16U70Q",
> +		.driver_data = &quirk_s2idle_spurious_8042,
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "LG Electronics"),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "16U70Q"),
> +		}
> +	},
>   	{}
>   };
>   
> 
> ---
> base-commit: c339f4010dea8b0d754f84ace70cd1b089878ef8
> change-id: 20261029-lg-16u70q-quirk-fae864db4054
> 
> Best regards,


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-10-30 14:13 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-10-29 23:24 [PATCH] platform/x86/amd/pmc: Add LG Ultra PC 16U70Q to quirks list Carlos Baiget Orts via B4 Relay
2026-10-30 14:13 ` Mario Limonciello

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®