mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH 1/2] x86: Fixing __cpuinit/__init tangle.
@ 2008-11-20 13:08 Rakib Mullick
  2008-11-20 15:43 ` Ingo Molnar
  0 siblings, 1 reply; 2+ messages in thread
From: Rakib Mullick @ 2008-11-20 13:08 UTC (permalink / raw)
  To: Linux-kernel Mailing List; +Cc: Ingo Molnar, Andrew Morton

Impact:	 Fixing __cpuinit/__init tangle.

This patch removes the following section mismatch warning. A patch set
was send previously (http://lkml.org/lkml/2008/11/10/407). But
introduce some other problem, reported by Rufus
(http://lkml.org/lkml/2008/11/11/46). Then Ingo Molnar suggest that,
it's best to remove __init from xsave_cntxt_init(void). Which is the
second patch in this series. Now, this one removes the following
warning.

WARNING: arch/x86/kernel/built-in.o(.cpuinit.text+0x2237): Section
mismatch in reference from the function cpu_init() to the function
.init.text:init_thread_xstate()
The function __cpuinit cpu_init() references
a function __init init_thread_xstate().
If init_thread_xstate is only used by cpu_init then
annotate init_thread_xstate with a matching annotation.

Thanks.

Signed-off-by: Rakib Mullick <rakib.mullick@gmail.com>

--- linux-2.6-orig/arch/x86/kernel/i387.c	2008-11-17 20:30:12.000000000 +0600
+++ linux-2.6/arch/x86/kernel/i387.c	2008-11-19 05:44:48.000000000 +0600
@@ -58,7 +58,7 @@ void __cpuinit mxcsr_feature_mask_init(v
 	stts();
 }

-void __init init_thread_xstate(void)
+void __cpuinit init_thread_xstate(void)
 {
 	if (!HAVE_HWFP) {
 		xstate_size = sizeof(struct i387_soft_struct);

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH 1/2] x86: Fixing __cpuinit/__init tangle.
  2008-11-20 13:08 [PATCH 1/2] x86: Fixing __cpuinit/__init tangle Rakib Mullick
@ 2008-11-20 15:43 ` Ingo Molnar
  0 siblings, 0 replies; 2+ messages in thread
From: Ingo Molnar @ 2008-11-20 15:43 UTC (permalink / raw)
  To: Rakib Mullick; +Cc: Linux-kernel Mailing List, Andrew Morton


* Rakib Mullick <rakib.mullick@gmail.com> wrote:

> Impact:	 Fixing __cpuinit/__init tangle.
> 
> This patch removes the following section mismatch warning. A patch set
> was send previously (http://lkml.org/lkml/2008/11/10/407). But
> introduce some other problem, reported by Rufus
> (http://lkml.org/lkml/2008/11/11/46). Then Ingo Molnar suggest that,
> it's best to remove __init from xsave_cntxt_init(void). Which is the
> second patch in this series. Now, this one removes the following
> warning.
> 
> WARNING: arch/x86/kernel/built-in.o(.cpuinit.text+0x2237): Section
> mismatch in reference from the function cpu_init() to the function
> .init.text:init_thread_xstate()
> The function __cpuinit cpu_init() references
> a function __init init_thread_xstate().
> If init_thread_xstate is only used by cpu_init then
> annotate init_thread_xstate with a matching annotation.
> 
> Thanks.

applied to tip/x86/urgent, thanks Rakib!

	Ingo

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-11-20 15:44 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-11-20 13:08 [PATCH 1/2] x86: Fixing __cpuinit/__init tangle Rakib Mullick
2008-11-20 15:43 ` Ingo Molnar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®