From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Jan Beulich <JBeulich@suse.com>, Paul Durrant <paul.durrant@citrix.com>
Cc: xen-devel@lists.xenproject.org, Juergen Gross <JGross@suse.com>,
linux-kernel@vger.kernel.org
Subject: Re: [Xen-devel] [PATCH 1/3] xen/privcmd: return -ENOSYS for unimplemented IOCTLs
Date: Thu, 9 Feb 2017 10:26:19 -0500 [thread overview]
Message-ID: <b9ee6ba2-4266-772a-430e-b36cf9b1b832@oracle.com> (raw)
In-Reply-To: <589C8D610200007800138429@prv-mh.provo.novell.com>
On 02/09/2017 09:40 AM, Jan Beulich wrote:
>>>> On 09.02.17 at 15:17, <paul.durrant@citrix.com> wrote:
>> The code goes so far as to set the default return code to -ENOSYS but
>> then overrides this to -EINVAL in the switch() statement's default
>> case.
>
> If you already change this, isn't -ENOTTY the traditional way of
> indicating unsupported ioctls?
In fact, a while ago David submitted a patch to do just that:
https://lists.xenproject.org/archives/html/xen-devel/2016-08/msg00744.html
but it never went anywhere.
My question is whether anyone might be relying on current error return
behavior.
-boris
next prev parent reply other threads:[~2017-02-09 19:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-09 14:17 [PATCH 0/3] xen/privcmd: support for dm_op and restriction Paul Durrant
2017-02-09 14:17 ` [PATCH 1/3] xen/privcmd: return -ENOSYS for unimplemented IOCTLs Paul Durrant
2017-02-09 14:40 ` [Xen-devel] " Jan Beulich
2017-02-09 15:26 ` Boris Ostrovsky [this message]
2017-02-09 15:28 ` Paul Durrant
2017-02-09 14:17 ` [PATCH 2/3] xen/privcmd: Add IOCTL_PRIVCMD_DM_OP Paul Durrant
2017-02-09 14:27 ` Paul Durrant
2017-02-09 15:50 ` Boris Ostrovsky
2017-02-09 15:56 ` [Xen-devel] " Andrew Cooper
2017-02-09 16:03 ` Jan Beulich
2017-02-09 16:08 ` Andrew Cooper
2017-02-09 16:45 ` Paul Durrant
2017-02-09 14:17 ` [PATCH 3/3] xen/privcmd: add IOCTL_PRIVCMD_RESTRICT Paul Durrant
2017-02-09 14:43 ` [Xen-devel] " Jan Beulich
2017-02-09 14:45 ` Paul Durrant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9ee6ba2-4266-772a-430e-b36cf9b1b832@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=JBeulich@suse.com \
--cc=JGross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.durrant@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®