From: Paul Durrant <Paul.Durrant@citrix.com>
To: "'Jan Beulich'" <JBeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
"Boris Ostrovsky" <boris.ostrovsky@oracle.com>,
Juergen Gross <JGross@suse.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [Xen-devel] [PATCH 3/3] xen/privcmd: add IOCTL_PRIVCMD_RESTRICT
Date: Thu, 9 Feb 2017 14:45:45 +0000 [thread overview]
Message-ID: <e8491e0d1fcb43beb0f17b1f47f73f84@AMSPEX02CL03.citrite.net> (raw)
In-Reply-To: <589C8E1D0200007800138448@prv-mh.provo.novell.com>
> -----Original Message-----
> From: Jan Beulich [mailto:JBeulich@suse.com]
> Sent: 09 February 2017 14:43
> To: Paul Durrant <Paul.Durrant@citrix.com>
> Cc: xen-devel@lists.xenproject.org; Boris Ostrovsky
> <boris.ostrovsky@oracle.com>; Juergen Gross <JGross@suse.com>; linux-
> kernel@vger.kernel.org
> Subject: Re: [Xen-devel] [PATCH 3/3] xen/privcmd: add
> IOCTL_PRIVCMD_RESTRICT
>
> >>> On 09.02.17 at 15:17, <paul.durrant@citrix.com> wrote:
> > @@ -666,6 +680,20 @@ static long privcmd_ioctl_dm_op(void __user
> *udata)
> > return rc;
> > }
> >
> > +static long privcmd_ioctl_restrict(struct file *file, void __user *udata)
> > +{
> > + struct privcmd_data *data = file->private_data;
> > + domid_t dom;
> > +
> > + if (copy_from_user(&dom, udata, sizeof(dom)))
> > + return -EFAULT;
> > +
> > + /* Set restriction to the specified domain */
> > + data->domid = dom;
> > +
> > + return 0;
> > +}
>
> Is it really intended for the caller to be able to undo this, by passing
> in DOMID_INVALID?
Good point. I was intending to fix that, but forgot.
Paul
>
> Jan
prev parent reply other threads:[~2017-02-09 14:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-09 14:17 [PATCH 0/3] xen/privcmd: support for dm_op and restriction Paul Durrant
2017-02-09 14:17 ` [PATCH 1/3] xen/privcmd: return -ENOSYS for unimplemented IOCTLs Paul Durrant
2017-02-09 14:40 ` [Xen-devel] " Jan Beulich
2017-02-09 15:26 ` Boris Ostrovsky
2017-02-09 15:28 ` Paul Durrant
2017-02-09 14:17 ` [PATCH 2/3] xen/privcmd: Add IOCTL_PRIVCMD_DM_OP Paul Durrant
2017-02-09 14:27 ` Paul Durrant
2017-02-09 15:50 ` Boris Ostrovsky
2017-02-09 15:56 ` [Xen-devel] " Andrew Cooper
2017-02-09 16:03 ` Jan Beulich
2017-02-09 16:08 ` Andrew Cooper
2017-02-09 16:45 ` Paul Durrant
2017-02-09 14:17 ` [PATCH 3/3] xen/privcmd: add IOCTL_PRIVCMD_RESTRICT Paul Durrant
2017-02-09 14:43 ` [Xen-devel] " Jan Beulich
2017-02-09 14:45 ` Paul Durrant [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e8491e0d1fcb43beb0f17b1f47f73f84@AMSPEX02CL03.citrite.net \
--to=paul.durrant@citrix.com \
--cc=JBeulich@suse.com \
--cc=JGross@suse.com \
--cc=boris.ostrovsky@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®