* [PATCH] crypto: powerpc/vmx - clean up includes, metadata, and p8_init()
@ 2026-09-14 8:15 Thorsten Blum
2026-09-14 8:49 ` Breno Leitao
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Thorsten Blum @ 2026-09-14 8:15 UTC (permalink / raw)
To: Breno Leitão, Nayna Jain, Paulo Flabiano Smorigo,
Herbert Xu, David S. Miller, Madhavan Srinivasan,
Michael Ellerman, Nicholas Piggin, Christophe Leroy (CS GROUP),
Ritesh Harjani (IBM),
Shrikanth Hegde
Cc: Thorsten Blum, linux-crypto, linuxppc-dev, linux-kernel
In p8_init(), remove the goto statement and return ret directly.
Remove any redundant includes, add a missing space in MODULE_AUTHOR(),
and join the MODULE_DESCRIPTION() strings for better grepability.
Also remove MODULE_VERSION(). It has never been updated and the kernel
release better reflects the module version.
Signed-off-by: Thorsten Blum <blum@kernel.org>
---
arch/powerpc/crypto/vmx.c | 14 +++-----------
1 file changed, 3 insertions(+), 11 deletions(-)
diff --git a/arch/powerpc/crypto/vmx.c b/arch/powerpc/crypto/vmx.c
index 08da5311dfdf..8abc4db8ee4e 100644
--- a/arch/powerpc/crypto/vmx.c
+++ b/arch/powerpc/crypto/vmx.c
@@ -8,12 +8,7 @@
*/
#include <linux/module.h>
-#include <linux/moduleparam.h>
-#include <linux/types.h>
-#include <linux/err.h>
#include <linux/cpufeature.h>
-#include <linux/crypto.h>
-#include <asm/cputable.h>
#include <crypto/internal/skcipher.h>
#include "aesp8-ppc.h"
@@ -24,7 +19,7 @@ static int __init p8_init(void)
ret = crypto_register_skcipher(&p8_aes_cbc_alg);
if (ret)
- goto err;
+ return ret;
ret = crypto_register_skcipher(&p8_aes_ctr_alg);
if (ret)
@@ -40,7 +35,6 @@ static int __init p8_init(void)
crypto_unregister_skcipher(&p8_aes_ctr_alg);
err_unregister_aes_cbc:
crypto_unregister_skcipher(&p8_aes_cbc_alg);
-err:
return ret;
}
@@ -54,8 +48,6 @@ static void __exit p8_exit(void)
module_cpu_feature_match(PPC_MODULE_FEATURE_VEC_CRYPTO, p8_init);
module_exit(p8_exit);
-MODULE_AUTHOR("Marcelo Cerri<mhcerri@br.ibm.com>");
-MODULE_DESCRIPTION("IBM VMX cryptographic acceleration instructions "
- "support on Power 8");
+MODULE_AUTHOR("Marcelo Cerri <mhcerri@br.ibm.com>");
+MODULE_DESCRIPTION("IBM VMX cryptographic acceleration instructions support on Power 8");
MODULE_LICENSE("GPL");
-MODULE_VERSION("1.0.0");
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] crypto: powerpc/vmx - clean up includes, metadata, and p8_init()
2026-09-14 8:15 [PATCH] crypto: powerpc/vmx - clean up includes, metadata, and p8_init() Thorsten Blum
@ 2026-09-14 8:49 ` Breno Leitao
2026-09-14 13:19 ` Srish Srinivasan
2026-09-15 6:58 ` Sudhakar Kuppusamy
2 siblings, 0 replies; 4+ messages in thread
From: Breno Leitao @ 2026-09-14 8:49 UTC (permalink / raw)
To: Thorsten Blum
Cc: Nayna Jain, Paulo Flabiano Smorigo, Herbert Xu, David S. Miller,
Madhavan Srinivasan, Michael Ellerman, Nicholas Piggin,
Christophe Leroy (CS GROUP), Ritesh Harjani (IBM),
Shrikanth Hegde, linux-crypto, linuxppc-dev, linux-kernel
On Mon, Sep 14, 2026 at 10:15:01AM +0200, Thorsten Blum wrote:
> In p8_init(), remove the goto statement and return ret directly.
>
> Remove any redundant includes, add a missing space in MODULE_AUTHOR(),
> and join the MODULE_DESCRIPTION() strings for better grepability.
>
> Also remove MODULE_VERSION(). It has never been updated and the kernel
> release better reflects the module version.
>
> Signed-off-by: Thorsten Blum <blum@kernel.org>
Reviewed-by: Breno Leitao <leitao@debian.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] crypto: powerpc/vmx - clean up includes, metadata, and p8_init()
2026-09-14 8:15 [PATCH] crypto: powerpc/vmx - clean up includes, metadata, and p8_init() Thorsten Blum
2026-09-14 8:49 ` Breno Leitao
@ 2026-09-14 13:19 ` Srish Srinivasan
2026-09-15 6:58 ` Sudhakar Kuppusamy
2 siblings, 0 replies; 4+ messages in thread
From: Srish Srinivasan @ 2026-09-14 13:19 UTC (permalink / raw)
To: Thorsten Blum, Breno Leitão, Nayna Jain,
Paulo Flabiano Smorigo, Herbert Xu, David S. Miller,
Madhavan Srinivasan, Michael Ellerman, Nicholas Piggin,
Christophe Leroy (CS GROUP), Ritesh Harjani (IBM),
Shrikanth Hegde
Cc: linux-crypto, linuxppc-dev, linux-kernel
On 9/14/26 1:45 PM, Thorsten Blum wrote:
> In p8_init(), remove the goto statement and return ret directly.
>
> Remove any redundant includes, add a missing space in MODULE_AUTHOR(),
> and join the MODULE_DESCRIPTION() strings for better grepability.
>
> Also remove MODULE_VERSION(). It has never been updated and the kernel
> release better reflects the module version.
>
> Signed-off-by: Thorsten Blum <blum@kernel.org>
Tested-by: Srish Srinivasan <ssrish@linux.ibm.com>
> ---
> arch/powerpc/crypto/vmx.c | 14 +++-----------
> 1 file changed, 3 insertions(+), 11 deletions(-)
>
> diff --git a/arch/powerpc/crypto/vmx.c b/arch/powerpc/crypto/vmx.c
> index 08da5311dfdf..8abc4db8ee4e 100644
> --- a/arch/powerpc/crypto/vmx.c
> +++ b/arch/powerpc/crypto/vmx.c
> @@ -8,12 +8,7 @@
> */
>
> #include <linux/module.h>
> -#include <linux/moduleparam.h>
> -#include <linux/types.h>
> -#include <linux/err.h>
> #include <linux/cpufeature.h>
> -#include <linux/crypto.h>
> -#include <asm/cputable.h>
> #include <crypto/internal/skcipher.h>
>
> #include "aesp8-ppc.h"
> @@ -24,7 +19,7 @@ static int __init p8_init(void)
>
> ret = crypto_register_skcipher(&p8_aes_cbc_alg);
> if (ret)
> - goto err;
> + return ret;
>
> ret = crypto_register_skcipher(&p8_aes_ctr_alg);
> if (ret)
> @@ -40,7 +35,6 @@ static int __init p8_init(void)
> crypto_unregister_skcipher(&p8_aes_ctr_alg);
> err_unregister_aes_cbc:
> crypto_unregister_skcipher(&p8_aes_cbc_alg);
> -err:
> return ret;
> }
>
> @@ -54,8 +48,6 @@ static void __exit p8_exit(void)
> module_cpu_feature_match(PPC_MODULE_FEATURE_VEC_CRYPTO, p8_init);
> module_exit(p8_exit);
>
> -MODULE_AUTHOR("Marcelo Cerri<mhcerri@br.ibm.com>");
> -MODULE_DESCRIPTION("IBM VMX cryptographic acceleration instructions "
> - "support on Power 8");
> +MODULE_AUTHOR("Marcelo Cerri <mhcerri@br.ibm.com>");
> +MODULE_DESCRIPTION("IBM VMX cryptographic acceleration instructions support on Power 8");
> MODULE_LICENSE("GPL");
> -MODULE_VERSION("1.0.0");
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] crypto: powerpc/vmx - clean up includes, metadata, and p8_init()
2026-09-14 8:15 [PATCH] crypto: powerpc/vmx - clean up includes, metadata, and p8_init() Thorsten Blum
2026-09-14 8:49 ` Breno Leitao
2026-09-14 13:19 ` Srish Srinivasan
@ 2026-09-15 6:58 ` Sudhakar Kuppusamy
2 siblings, 0 replies; 4+ messages in thread
From: Sudhakar Kuppusamy @ 2026-09-15 6:58 UTC (permalink / raw)
To: Thorsten Blum
Cc: Breno Leitão, Nayna Jain, Paulo Flabiano Smorigo,
Herbert Xu, David S. Miller, Madhavan Srinivasan,
Michael Ellerman, Nicholas Piggin, Christophe Leroy (CS GROUP),
Ritesh Harjani (IBM),
Shrikanth Hegde, linux-crypto, linuxppc-dev, linux-kernel
> On 14 Sep 2026, at 1:45 PM, Thorsten Blum <blum@kernel.org> wrote:
>
> In p8_init(), remove the goto statement and return ret directly.
>
> Remove any redundant includes, add a missing space in MODULE_AUTHOR(),
> and join the MODULE_DESCRIPTION() strings for better grepability.
>
> Also remove MODULE_VERSION(). It has never been updated and the kernel
> release better reflects the module version.
>
> Signed-off-by: Thorsten Blum <blum@kernel.org>
Reviewed-by: Sudhakar Kuppusamy <sudhakar@linux.ibm.com>
Thanks,
Sudhakar
> ---
> arch/powerpc/crypto/vmx.c | 14 +++-----------
> 1 file changed, 3 insertions(+), 11 deletions(-)
>
> diff --git a/arch/powerpc/crypto/vmx.c b/arch/powerpc/crypto/vmx.c
> index 08da5311dfdf..8abc4db8ee4e 100644
> --- a/arch/powerpc/crypto/vmx.c
> +++ b/arch/powerpc/crypto/vmx.c
> @@ -8,12 +8,7 @@
> */
>
> #include <linux/module.h>
> -#include <linux/moduleparam.h>
> -#include <linux/types.h>
> -#include <linux/err.h>
> #include <linux/cpufeature.h>
> -#include <linux/crypto.h>
> -#include <asm/cputable.h>
> #include <crypto/internal/skcipher.h>
>
> #include "aesp8-ppc.h"
> @@ -24,7 +19,7 @@ static int __init p8_init(void)
>
> ret = crypto_register_skcipher(&p8_aes_cbc_alg);
> if (ret)
> - goto err;
> + return ret;
>
> ret = crypto_register_skcipher(&p8_aes_ctr_alg);
> if (ret)
> @@ -40,7 +35,6 @@ static int __init p8_init(void)
> crypto_unregister_skcipher(&p8_aes_ctr_alg);
> err_unregister_aes_cbc:
> crypto_unregister_skcipher(&p8_aes_cbc_alg);
> -err:
> return ret;
> }
>
> @@ -54,8 +48,6 @@ static void __exit p8_exit(void)
> module_cpu_feature_match(PPC_MODULE_FEATURE_VEC_CRYPTO, p8_init);
> module_exit(p8_exit);
>
> -MODULE_AUTHOR("Marcelo Cerri<mhcerri@br.ibm.com>");
> -MODULE_DESCRIPTION("IBM VMX cryptographic acceleration instructions "
> - "support on Power 8");
> +MODULE_AUTHOR("Marcelo Cerri <mhcerri@br.ibm.com>");
> +MODULE_DESCRIPTION("IBM VMX cryptographic acceleration instructions support on Power 8");
> MODULE_LICENSE("GPL");
> -MODULE_VERSION("1.0.0");
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-09-15 6:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-14 8:15 [PATCH] crypto: powerpc/vmx - clean up includes, metadata, and p8_init() Thorsten Blum
2026-09-14 8:49 ` Breno Leitao
2026-09-14 13:19 ` Srish Srinivasan
2026-09-15 6:58 ` Sudhakar Kuppusamy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®