From: "Arnd Bergmann" <arnd@arndb.de>
To: "Arnaud POULIQUEN" <arnaud.pouliquen@foss.st.com>,
"Arnd Bergmann" <arnd@kernel.org>,
"Bjorn Andersson" <andersson@kernel.org>,
"Mathieu Poirier" <mathieu.poirier@linaro.org>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Alexandre Torgue" <alexandre.torgue@foss.st.com>
Cc: "Ben Levinsky" <ben.levinsky@amd.com>,
"Tanmay Shah" <tanmay.shah@amd.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Dan Carpenter" <dan.carpenter@linaro.org>,
linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] remoteproc: stm32: use correct format strings on 64-bit
Date: Mon, 12 Jun 2023 16:17:19 +0200 [thread overview]
Message-ID: <ba58f0cb-3683-4aae-8c10-2fad2e701501@app.fastmail.com> (raw)
In-Reply-To: <7846c69b-5c2d-16d3-6079-d11a60171a69@foss.st.com>
On Mon, Jun 12, 2023, at 16:10, Arnaud POULIQUEN wrote:
>> ddata->rsc_va = devm_ioremap_wc(dev, rsc_pa, RSC_TBL_SIZE);
>> if (IS_ERR_OR_NULL(ddata->rsc_va)) {
>> - dev_err(dev, "Unable to map memory region: %pa+%zx\n",
>> + dev_err(dev, "Unable to map memory region: %pa+%x\n",
>> &rsc_pa, RSC_TBL_SIZE);
>
> What about cast the RSC_TBL_SIZE define instead to ensure to be independent from
> the arch and to match with the use of RSC_TBL_SIZE?
>
> #define RSC_TBL_SIZE ((size_t)1024)
I have no objection to that, but I don't see it doing anything good either,
as this is a constant value that will always work.
Arnd
next prev parent reply other threads:[~2023-06-12 14:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-09 12:05 Arnd Bergmann
2023-06-12 14:10 ` Arnaud POULIQUEN
2023-06-12 14:17 ` Arnd Bergmann [this message]
2023-06-13 10:05 ` Arnaud POULIQUEN
2023-06-13 10:05 ` Alexandre TORGUE
2023-06-15 22:40 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba58f0cb-3683-4aae-8c10-2fad2e701501@app.fastmail.com \
--to=arnd@arndb.de \
--cc=alexandre.torgue@foss.st.com \
--cc=andersson@kernel.org \
--cc=arnaud.pouliquen@foss.st.com \
--cc=arnd@kernel.org \
--cc=ben.levinsky@amd.com \
--cc=dan.carpenter@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mathieu.poirier@linaro.org \
--cc=mcoquelin.stm32@gmail.com \
--cc=tanmay.shah@amd.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®