[PATCH net-next v2 1/2] dt-bindings: net: rfkill-gpio: enable booting in blocked state

[PATCH net-next v2 1/2] dt-bindings: net: rfkill-gpio: enable booting in blocked state

[Catalin Popescu]

By default, rfkill state is set to unblocked. Sometimes, we want to boot
in blocked state and let the application unblock the rfkill.

Signed-off-by: Catalin Popescu <catalin.popescu@leica-geosystems.com>
---
Changes in v2:
 - change "default-blocked" type from boolean to flag
---
 Documentation/devicetree/bindings/net/rfkill-gpio.yaml | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/Documentation/devicetree/bindings/net/rfkill-gpio.yaml b/Documentation/devicetree/bindings/net/rfkill-gpio.yaml
index 9630c8466fac..4a706a41ab38 100644
--- a/Documentation/devicetree/bindings/net/rfkill-gpio.yaml
+++ b/Documentation/devicetree/bindings/net/rfkill-gpio.yaml
@@ -32,6 +32,10 @@ properties:
   shutdown-gpios:
     maxItems: 1
 
+  default-blocked:
+    $ref: /schemas/types.yaml#/definitions/flag
+    description: configure rfkill state as blocked at boot
+
 required:
   - compatible
   - radio-type
@@ -48,4 +52,5 @@ examples:
         label = "rfkill-pcie-wlan";
         radio-type = "wlan";
         shutdown-gpios = <&gpio2 25 GPIO_ACTIVE_HIGH>;
+        default-blocked;
     };

base-commit: 25cc469d6d344f5772e9fb6a5cf9d82a690afe68
prerequisite-patch-id: 0000000000000000000000000000000000000000
-- 
2.34.1

[PATCH net-next v2 2/2] net: rfkill: gpio: allow booting in blocked state

[Catalin Popescu]

By default, rfkill state is unblocked and this behavior is not
configurable. Add support for booting in blocked state based on the
presence of a devicetree property.

Signed-off-by: Catalin Popescu <catalin.popescu@leica-geosystems.com>
---
 net/rfkill/rfkill-gpio.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/net/rfkill/rfkill-gpio.c b/net/rfkill/rfkill-gpio.c
index 9fa019e0dcad..41e657e97761 100644
--- a/net/rfkill/rfkill-gpio.c
+++ b/net/rfkill/rfkill-gpio.c
@@ -162,6 +162,9 @@ static int rfkill_gpio_probe(struct platform_device *pdev)
 	if (!rfkill->rfkill_dev)
 		return -ENOMEM;
 
+	if (device_property_present(&pdev->dev, "default-blocked"))
+		rfkill_init_sw_state(rfkill->rfkill_dev, true);
+
 	ret = rfkill_register(rfkill->rfkill_dev);
 	if (ret < 0)
 		goto err_destroy;
-- 
2.34.1

Re: [PATCH net-next v2 1/2] dt-bindings: net: rfkill-gpio: enable booting in blocked state

[Krzysztof Kozlowski]

On Thu, Jan 16, 2025 at 09:47:01AM +0100, Catalin Popescu wrote:
> By default, rfkill state is set to unblocked. Sometimes, we want to boot
> in blocked state and let the application unblock the rfkill.
> 
> Signed-off-by: Catalin Popescu <catalin.popescu@leica-geosystems.com>
> ---
> Changes in v2:
>  - change "default-blocked" type from boolean to flag
> ---
>  Documentation/devicetree/bindings/net/rfkill-gpio.yaml | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/rfkill-gpio.yaml b/Documentation/devicetree/bindings/net/rfkill-gpio.yaml
> index 9630c8466fac..4a706a41ab38 100644
> --- a/Documentation/devicetree/bindings/net/rfkill-gpio.yaml
> +++ b/Documentation/devicetree/bindings/net/rfkill-gpio.yaml
> @@ -32,6 +32,10 @@ properties:
>    shutdown-gpios:
>      maxItems: 1
>  
> +  default-blocked:
> +    $ref: /schemas/types.yaml#/definitions/flag
> +    description: configure rfkill state as blocked at boot

I am assuming rfkill does not have third state possible, so it is only
off or on.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

Re: [PATCH net-next v2 1/2] dt-bindings: net: rfkill-gpio: enable booting in blocked state

[POPESCU Catalin]

On 17/01/2025 09:56, Krzysztof Kozlowski wrote:
> This email is not from Hexagon’s Office 365 instance. Please be careful while clicking links, opening attachments, or replying to this email.
>
>
> On Thu, Jan 16, 2025 at 09:47:01AM +0100, Catalin Popescu wrote:
>> By default, rfkill state is set to unblocked. Sometimes, we want to boot
>> in blocked state and let the application unblock the rfkill.
>>
>> Signed-off-by: Catalin Popescu <catalin.popescu@leica-geosystems.com>
>> ---
>> Changes in v2:
>>   - change "default-blocked" type from boolean to flag
>> ---
>>   Documentation/devicetree/bindings/net/rfkill-gpio.yaml | 5 +++++
>>   1 file changed, 5 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/net/rfkill-gpio.yaml b/Documentation/devicetree/bindings/net/rfkill-gpio.yaml
>> index 9630c8466fac..4a706a41ab38 100644
>> --- a/Documentation/devicetree/bindings/net/rfkill-gpio.yaml
>> +++ b/Documentation/devicetree/bindings/net/rfkill-gpio.yaml
>> @@ -32,6 +32,10 @@ properties:
>>     shutdown-gpios:
>>       maxItems: 1
>>
>> +  default-blocked:
>> +    $ref: /schemas/types.yaml#/definitions/flag
>> +    description: configure rfkill state as blocked at boot
> I am assuming rfkill does not have third state possible, so it is only
> off or on.
Indeed, only on/off.
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Thanks!

BR,
Catalin

>
> Best regards,
> Krzysztof
>