* [PATCH] sched/fair: Add stats update for cfs_rq->exec_clock in update_curr() again
@ 2024-05-03 10:46 Dietmar Eggemann
2024-05-04 12:17 ` Madadi Vineeth Reddy
0 siblings, 1 reply; 2+ messages in thread
From: Dietmar Eggemann @ 2024-05-03 10:46 UTC (permalink / raw)
To: Ingo Molnar, Peter Zijlstra, Juri Lelli, Vincent Guittot
Cc: Steven Rostedt, Ben Segall, Mel Gorman,
Daniel Bristot de Oliveira, Valentin Schneider, linux-kernel
Commit 5d69eca542ee ("sched: Unify runtime accounting across classes")
removed it and since then:
echo 1 > /proc/sys/kernel/sched_schedstats
cat /sys/kernel/debug/sched/debug | grep exec_clock
returns:
.exec_clock : 0.000000
for all cfs_rq's.
Put the schedstat_add() back to be able to watch the cfs_rq runtime
statistic.
Signed-off-by: Dietmar Eggemann <dietmar.eggemann@arm.com>
---
kernel/sched/fair.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 9eb63573110c..37bb3cee6fec 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -1158,6 +1158,7 @@ static void update_curr(struct cfs_rq *cfs_rq)
delta_exec = update_curr_se(rq_of(cfs_rq), curr);
if (unlikely(delta_exec <= 0))
return;
+ schedstat_add(cfs_rq->exec_clock, delta_exec);
curr->vruntime += calc_delta_fair(delta_exec, curr);
update_deadline(cfs_rq, curr);
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] sched/fair: Add stats update for cfs_rq->exec_clock in update_curr() again
2024-05-03 10:46 [PATCH] sched/fair: Add stats update for cfs_rq->exec_clock in update_curr() again Dietmar Eggemann
@ 2024-05-04 12:17 ` Madadi Vineeth Reddy
0 siblings, 0 replies; 2+ messages in thread
From: Madadi Vineeth Reddy @ 2024-05-04 12:17 UTC (permalink / raw)
To: Dietmar Eggemann
Cc: Steven Rostedt, Ben Segall, Mel Gorman,
Daniel Bristot de Oliveira, Valentin Schneider, linux-kernel,
Ingo Molnar, Peter Zijlstra, Juri Lelli, Vincent Guittot,
Madadi Vineeth Reddy
Hi Dietmar Eggemann,
On 03/05/24 16:16, Dietmar Eggemann wrote:
> Commit 5d69eca542ee ("sched: Unify runtime accounting across classes")
> removed it and since then:
>
> echo 1 > /proc/sys/kernel/sched_schedstats
> cat /sys/kernel/debug/sched/debug | grep exec_clock
>
> returns:
>
> .exec_clock : 0.000000
>
> for all cfs_rq's.
>
> Put the schedstat_add() back to be able to watch the cfs_rq runtime
> statistic.
>
> Signed-off-by: Dietmar Eggemann <dietmar.eggemann@arm.com>
> ---
> kernel/sched/fair.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index 9eb63573110c..37bb3cee6fec 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -1158,6 +1158,7 @@ static void update_curr(struct cfs_rq *cfs_rq)
> delta_exec = update_curr_se(rq_of(cfs_rq), curr);
> if (unlikely(delta_exec <= 0))
> return;
> + schedstat_add(cfs_rq->exec_clock, delta_exec);
>
> curr->vruntime += calc_delta_fair(delta_exec, curr);
> update_deadline(cfs_rq, curr);
Able to see the stats now with the patch.
Tested-by: Madadi Vineeth Reddy <vineethr@linux.ibm.com>
Thanks and Regards
Madadi Vineeth Reddy
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-05-04 12:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-05-03 10:46 [PATCH] sched/fair: Add stats update for cfs_rq->exec_clock in update_curr() again Dietmar Eggemann
2024-05-04 12:17 ` Madadi Vineeth Reddy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®