* [RESEND PATCH] drm/mipi-dsi: Fix error handling in mipi_dsi_device_register_full
@ 2022-06-01 12:40 Miaoqian Lin
2022-06-02 7:11 ` Andrzej Hajda
0 siblings, 1 reply; 2+ messages in thread
From: Miaoqian Lin @ 2022-06-01 12:40 UTC (permalink / raw)
To: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
David Airlie, Daniel Vetter, Kyungmin Park, Thierry Reding,
Andrzej Hajda, dri-devel, linux-kernel
Cc: linmq006
In mipi_dsi_device_alloc(), it calls device_initialize(&dsi->dev);
We need to use put_device() instead freeing directly.
Fixes: 068a002 ("drm: Add MIPI DSI bus support")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
drivers/gpu/drm/drm_mipi_dsi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_mipi_dsi.c b/drivers/gpu/drm/drm_mipi_dsi.c
index c40bde96cfdf..8cc8deca006f 100644
--- a/drivers/gpu/drm/drm_mipi_dsi.c
+++ b/drivers/gpu/drm/drm_mipi_dsi.c
@@ -228,7 +228,7 @@ mipi_dsi_device_register_full(struct mipi_dsi_host *host,
ret = mipi_dsi_device_add(dsi);
if (ret) {
drm_err(host, "failed to add DSI device %d\n", ret);
- kfree(dsi);
+ put_device(&dsi->dev);
return ERR_PTR(ret);
}
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [RESEND PATCH] drm/mipi-dsi: Fix error handling in mipi_dsi_device_register_full
2022-06-01 12:40 [RESEND PATCH] drm/mipi-dsi: Fix error handling in mipi_dsi_device_register_full Miaoqian Lin
@ 2022-06-02 7:11 ` Andrzej Hajda
0 siblings, 0 replies; 2+ messages in thread
From: Andrzej Hajda @ 2022-06-02 7:11 UTC (permalink / raw)
To: Miaoqian Lin, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Daniel Vetter, Kyungmin Park,
Thierry Reding, dri-devel, linux-kernel
On 01.06.2022 14:40, Miaoqian Lin wrote:
> In mipi_dsi_device_alloc(), it calls device_initialize(&dsi->dev);
> We need to use put_device() instead freeing directly.
>
> Fixes: 068a002 ("drm: Add MIPI DSI bus support")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Looks correct.
Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com>
Regards
Andrzej
> ---
> drivers/gpu/drm/drm_mipi_dsi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_mipi_dsi.c b/drivers/gpu/drm/drm_mipi_dsi.c
> index c40bde96cfdf..8cc8deca006f 100644
> --- a/drivers/gpu/drm/drm_mipi_dsi.c
> +++ b/drivers/gpu/drm/drm_mipi_dsi.c
> @@ -228,7 +228,7 @@ mipi_dsi_device_register_full(struct mipi_dsi_host *host,
> ret = mipi_dsi_device_add(dsi);
> if (ret) {
> drm_err(host, "failed to add DSI device %d\n", ret);
> - kfree(dsi);
> + put_device(&dsi->dev);
> return ERR_PTR(ret);
> }
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-06-02 7:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-01 12:40 [RESEND PATCH] drm/mipi-dsi: Fix error handling in mipi_dsi_device_register_full Miaoqian Lin
2022-06-02 7:11 ` Andrzej Hajda
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®