From: Nikolay Borisov <nborisov@suse.com>
To: YueHaibing <yuehaibing@huawei.com>,
clm@fb.com, josef@toxicpanda.com, dsterba@suse.com
Cc: linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] btrfs: Make init_tree_roots static
Date: Fri, 18 Oct 2019 15:09:58 +0300 [thread overview]
Message-ID: <bab47b8e-d35f-a769-a703-4dcfe1a17980@suse.com> (raw)
In-Reply-To: <20191018120604.29508-1-yuehaibing@huawei.com>
On 18.10.19 г. 15:06 ч., YueHaibing wrote:
> Fix sparse warning:
>
> fs/btrfs/disk-io.c:2534:12: warning:
> symbol 'init_tree_roots' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Huhz, I thought I had added static... Anyway this could be folded in the
original patch. Thanks for the report.
> ---
> fs/btrfs/disk-io.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c
> index d078276..cb187f5 100644
> --- a/fs/btrfs/disk-io.c
> +++ b/fs/btrfs/disk-io.c
> @@ -2531,7 +2531,7 @@ static int btrfs_validate_write_super(struct btrfs_fs_info *fs_info,
> return ret;
> }
>
> -int __cold init_tree_roots(struct btrfs_fs_info *fs_info)
> +static int __cold init_tree_roots(struct btrfs_fs_info *fs_info)
> {
> int backup_index = find_newest_super_backup(fs_info);
> struct btrfs_super_block *sb = fs_info->super_copy;
>
next prev parent reply other threads:[~2019-10-18 12:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-18 12:06 YueHaibing
2019-10-18 12:09 ` Nikolay Borisov [this message]
2019-10-21 13:17 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bab47b8e-d35f-a769-a703-4dcfe1a17980@suse.com \
--to=nborisov@suse.com \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®