* [PATCH -next] btrfs: Make init_tree_roots static
@ 2019-10-18 12:06 YueHaibing
2019-10-18 12:09 ` Nikolay Borisov
0 siblings, 1 reply; 3+ messages in thread
From: YueHaibing @ 2019-10-18 12:06 UTC (permalink / raw)
To: clm, josef, dsterba; +Cc: linux-btrfs, linux-kernel, YueHaibing
Fix sparse warning:
fs/btrfs/disk-io.c:2534:12: warning:
symbol 'init_tree_roots' was not declared. Should it be static?
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
fs/btrfs/disk-io.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c
index d078276..cb187f5 100644
--- a/fs/btrfs/disk-io.c
+++ b/fs/btrfs/disk-io.c
@@ -2531,7 +2531,7 @@ static int btrfs_validate_write_super(struct btrfs_fs_info *fs_info,
return ret;
}
-int __cold init_tree_roots(struct btrfs_fs_info *fs_info)
+static int __cold init_tree_roots(struct btrfs_fs_info *fs_info)
{
int backup_index = find_newest_super_backup(fs_info);
struct btrfs_super_block *sb = fs_info->super_copy;
--
2.7.4
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] btrfs: Make init_tree_roots static
2019-10-18 12:06 [PATCH -next] btrfs: Make init_tree_roots static YueHaibing
@ 2019-10-18 12:09 ` Nikolay Borisov
2019-10-21 13:17 ` David Sterba
0 siblings, 1 reply; 3+ messages in thread
From: Nikolay Borisov @ 2019-10-18 12:09 UTC (permalink / raw)
To: YueHaibing, clm, josef, dsterba; +Cc: linux-btrfs, linux-kernel
On 18.10.19 г. 15:06 ч., YueHaibing wrote:
> Fix sparse warning:
>
> fs/btrfs/disk-io.c:2534:12: warning:
> symbol 'init_tree_roots' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Huhz, I thought I had added static... Anyway this could be folded in the
original patch. Thanks for the report.
> ---
> fs/btrfs/disk-io.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c
> index d078276..cb187f5 100644
> --- a/fs/btrfs/disk-io.c
> +++ b/fs/btrfs/disk-io.c
> @@ -2531,7 +2531,7 @@ static int btrfs_validate_write_super(struct btrfs_fs_info *fs_info,
> return ret;
> }
>
> -int __cold init_tree_roots(struct btrfs_fs_info *fs_info)
> +static int __cold init_tree_roots(struct btrfs_fs_info *fs_info)
> {
> int backup_index = find_newest_super_backup(fs_info);
> struct btrfs_super_block *sb = fs_info->super_copy;
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] btrfs: Make init_tree_roots static
2019-10-18 12:09 ` Nikolay Borisov
@ 2019-10-21 13:17 ` David Sterba
0 siblings, 0 replies; 3+ messages in thread
From: David Sterba @ 2019-10-21 13:17 UTC (permalink / raw)
To: Nikolay Borisov
Cc: YueHaibing, clm, josef, dsterba, linux-btrfs, linux-kernel
On Fri, Oct 18, 2019 at 03:09:58PM +0300, Nikolay Borisov wrote:
>
>
> On 18.10.19 г. 15:06 ч., YueHaibing wrote:
> > Fix sparse warning:
> >
> > fs/btrfs/disk-io.c:2534:12: warning:
> > symbol 'init_tree_roots' was not declared. Should it be static?
> >
> > Reported-by: Hulk Robot <hulkci@huawei.com>
> > Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>
> Huhz, I thought I had added static... Anyway this could be folded in the
> original patch. Thanks for the report.
Folded.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-10-21 13:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-18 12:06 [PATCH -next] btrfs: Make init_tree_roots static YueHaibing
2019-10-18 12:09 ` Nikolay Borisov
2019-10-21 13:17 ` David Sterba
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®