mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Zhu Yanjun <yanjun.zhu@linux.dev>
To: Minjie Du <duminjie@vivo.com>,
	Mustafa Ismail <mustafa.ismail@intel.com>,
	Shiraz Saleem <shiraz.saleem@intel.com>,
	Jason Gunthorpe <jgg@ziepe.ca>, Leon Romanovsky <leon@kernel.org>,
	"open list:INTEL ETHERNET PROTOCOL DRIVER FOR RDMA" 
	<linux-rdma@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>
Cc: opensource.kernel@vivo.com
Subject: Re: [PATCH v1] infiniband: irdma: Remove a duplicate assignment in irdma_query_ah()
Date: Thu, 6 Jul 2023 15:46:23 +0800	[thread overview]
Message-ID: <babbab54-f8b3-24a4-56b6-95d8a0db6307@linux.dev> (raw)
In-Reply-To: <20230706022704.1260-1-duminjie@vivo.com>

在 2023/7/6 10:27, Minjie Du 写道:
> Delete a duplicate statement from this function implementation.
> 

Please add "Fixes ".

Zhu Yanjun

> Signed-off-by: Minjie Du <duminjie@vivo.com>
> ---
>   drivers/infiniband/hw/irdma/verbs.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/infiniband/hw/irdma/verbs.c b/drivers/infiniband/hw/irdma/verbs.c
> index 9c4fe4fa9..a8326a95d 100644
> --- a/drivers/infiniband/hw/irdma/verbs.c
> +++ b/drivers/infiniband/hw/irdma/verbs.c
> @@ -4424,7 +4424,6 @@ static int irdma_query_ah(struct ib_ah *ibah, struct rdma_ah_attr *ah_attr)
>   		ah_attr->grh.traffic_class = ah->sc_ah.ah_info.tc_tos;
>   		ah_attr->grh.hop_limit = ah->sc_ah.ah_info.hop_ttl;
>   		ah_attr->grh.sgid_index = ah->sgid_index;
> -		ah_attr->grh.sgid_index = ah->sgid_index;
>   		memcpy(&ah_attr->grh.dgid, &ah->dgid,
>   		       sizeof(ah_attr->grh.dgid));
>   	}


  reply	other threads:[~2023-07-06  7:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-06  2:27 Minjie Du
2023-07-06  7:46 ` Zhu Yanjun [this message]
2023-07-12 12:10 ` Leon Romanovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=babbab54-f8b3-24a4-56b6-95d8a0db6307@linux.dev \
    --to=yanjun.zhu@linux.dev \
    --cc=duminjie@vivo.com \
    --cc=jgg@ziepe.ca \
    --cc=leon@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=mustafa.ismail@intel.com \
    --cc=opensource.kernel@vivo.com \
    --cc=shiraz.saleem@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®