mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hannes Reinecke <hare@suse.de>
To: Johannes Thumshirn <jthumshirn@suse.de>,
	"Martin K . Petersen" <martin.petersen@oracle.com>
Cc: Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>,
	Linux SCSI Mailinglist <linux-scsi@vger.kernel.org>,
	Bart Van Assche <Bart.VanAssche@sandisk.com>,
	Himanshu Madhani <himanshu.madhani@cavium.com>
Subject: Re: [PATCH] scsi: qla2xxx: Correct setting of SAM_STAT_CHECK_CONDITION
Date: Mon, 9 Apr 2018 15:56:45 +0200	[thread overview]
Message-ID: <bac29060-8106-fe43-21b4-dabd6e5f5ab2@suse.de> (raw)
In-Reply-To: <20180409123922.854-1-jthumshirn@suse.de>

On 04/09/2018 02:39 PM, Johannes Thumshirn wrote:
> Bart reports that in qla_isr.c's qla2x00_handle_dif_error we're
> wrongly shifting the SAM_STAT_CHECK_CONDITION by one instead of
> directly ORing it onto the SCSI command's result.
> 
> Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>
> Reported-by: Bart Van Assche <Bart.VanAssche@wdc.com>
> Cc: Himanshu Madhani <himanshu.madhani@cavium.com>
> ---
>  drivers/scsi/qla2xxx/qla_isr.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c
> index 49d67e1d571f..ed6cdfea00b4 100644
> --- a/drivers/scsi/qla2xxx/qla_isr.c
> +++ b/drivers/scsi/qla2xxx/qla_isr.c
> @@ -2195,7 +2195,7 @@ qla2x00_handle_dif_error(srb_t *sp, struct sts_entry_24xx *sts24)
>  		    0x10, 0x1);
>  		set_driver_byte(cmd, DRIVER_SENSE);
>  		set_host_byte(cmd, DID_ABORT);
> -		cmd->result |= SAM_STAT_CHECK_CONDITION << 1;
> +		cmd->result |= SAM_STAT_CHECK_CONDITION;
>  		return 1;
>  	}
>  
> @@ -2205,7 +2205,7 @@ qla2x00_handle_dif_error(srb_t *sp, struct sts_entry_24xx *sts24)
>  		    0x10, 0x3);
>  		set_driver_byte(cmd, DRIVER_SENSE);
>  		set_host_byte(cmd, DID_ABORT);
> -		cmd->result |= SAM_STAT_CHECK_CONDITION << 1;
> +		cmd->result |= SAM_STAT_CHECK_CONDITION;
>  		return 1;
>  	}
>  
> @@ -2215,7 +2215,7 @@ qla2x00_handle_dif_error(srb_t *sp, struct sts_entry_24xx *sts24)
>  		    0x10, 0x2);
>  		set_driver_byte(cmd, DRIVER_SENSE);
>  		set_host_byte(cmd, DID_ABORT);
> -		cmd->result |= SAM_STAT_CHECK_CONDITION << 1;
> +		cmd->result |= SAM_STAT_CHECK_CONDITION;
>  		return 1;
>  	}
>  
> 
Reviewed-by: Hannes Reinecke <hare@suse.com>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		   Teamlead Storage & Networking
hare@suse.de			               +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)

  reply	other threads:[~2018-04-09 13:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-09 12:39 Johannes Thumshirn
2018-04-09 13:56 ` Hannes Reinecke [this message]
2018-04-09 14:14 ` Bart Van Assche
2018-04-10  1:18 ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bac29060-8106-fe43-21b4-dabd6e5f5ab2@suse.de \
    --to=hare@suse.de \
    --cc=Bart.VanAssche@sandisk.com \
    --cc=himanshu.madhani@cavium.com \
    --cc=jthumshirn@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®