* [PATCH] gpu: display: remove unnecessary braces to fix coding style
@ 2023-11-21 4:36 RutingZhang
2023-11-21 9:17 ` Christian König
0 siblings, 1 reply; 3+ messages in thread
From: RutingZhang @ 2023-11-21 4:36 UTC (permalink / raw)
To: Harry Wentland, Leo Li, Rodrigo Siqueira, Alex Deucher,
Christian König, Pan, Xinhui, David Airlie, Daniel Vetter
Cc: hust-os-kernel-patches, RutingZhang, Dongliang Mu, amd-gfx,
dri-devel, linux-kernel
checkpatch complains that:
WARNING: braces {} are not necessary for single statement blocks
+ if (pool->base.irqs != NULL) {
+ dal_irq_service_destroy(&pool->base.irqs);
+ }
Fixed it by removing unnecessary braces to fix the coding style issue.
Signed-off-by: RutingZhang <u202112078@hust.edu.cn>
Reviewed-by: Dongliang Mu <dzm91@hust.edu.cn>
---
drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c b/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c
index 447de8492594..6835dbb733a2 100644
--- a/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c
+++ b/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c
@@ -713,9 +713,8 @@ static void dcn21_resource_destruct(struct dcn21_resource_pool *pool)
pool->base.hubps[i] = NULL;
}
- if (pool->base.irqs != NULL) {
+ if (pool->base.irqs != NULL)
dal_irq_service_destroy(&pool->base.irqs);
- }
}
for (i = 0; i < pool->base.res_cap->num_ddc; i++) {
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gpu: display: remove unnecessary braces to fix coding style
2023-11-21 4:36 [PATCH] gpu: display: remove unnecessary braces to fix coding style RutingZhang
@ 2023-11-21 9:17 ` Christian König
2023-11-21 18:52 ` Alex Deucher
0 siblings, 1 reply; 3+ messages in thread
From: Christian König @ 2023-11-21 9:17 UTC (permalink / raw)
To: RutingZhang, Harry Wentland, Leo Li, Rodrigo Siqueira,
Alex Deucher, Pan, Xinhui, David Airlie, Daniel Vetter
Cc: hust-os-kernel-patches, Dongliang Mu, amd-gfx, dri-devel, linux-kernel
Am 21.11.23 um 05:36 schrieb RutingZhang:
> checkpatch complains that:
>
> WARNING: braces {} are not necessary for single statement blocks
> + if (pool->base.irqs != NULL) {
> + dal_irq_service_destroy(&pool->base.irqs);
> + }
>
> Fixed it by removing unnecessary braces to fix the coding style issue.
>
> Signed-off-by: RutingZhang <u202112078@hust.edu.cn>
> Reviewed-by: Dongliang Mu <dzm91@hust.edu.cn>
Subject line prefix should be "drm/amdgpu".
Apart from this nit it looks good to me, but might be already fixed
internally.
Regards,
Christian.
> ---
> drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c b/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c
> index 447de8492594..6835dbb733a2 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c
> @@ -713,9 +713,8 @@ static void dcn21_resource_destruct(struct dcn21_resource_pool *pool)
> pool->base.hubps[i] = NULL;
> }
>
> - if (pool->base.irqs != NULL) {
> + if (pool->base.irqs != NULL)
> dal_irq_service_destroy(&pool->base.irqs);
> - }
> }
>
> for (i = 0; i < pool->base.res_cap->num_ddc; i++) {
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gpu: display: remove unnecessary braces to fix coding style
2023-11-21 9:17 ` Christian König
@ 2023-11-21 18:52 ` Alex Deucher
0 siblings, 0 replies; 3+ messages in thread
From: Alex Deucher @ 2023-11-21 18:52 UTC (permalink / raw)
To: Christian König
Cc: RutingZhang, Harry Wentland, Leo Li, Rodrigo Siqueira,
Alex Deucher, Pan, Xinhui, David Airlie, Daniel Vetter,
hust-os-kernel-patches, Dongliang Mu, dri-devel, amd-gfx,
linux-kernel
On Tue, Nov 21, 2023 at 4:27 AM Christian König
<christian.koenig@amd.com> wrote:
>
> Am 21.11.23 um 05:36 schrieb RutingZhang:
> > checkpatch complains that:
> >
> > WARNING: braces {} are not necessary for single statement blocks
> > + if (pool->base.irqs != NULL) {
> > + dal_irq_service_destroy(&pool->base.irqs);
> > + }
> >
> > Fixed it by removing unnecessary braces to fix the coding style issue.
> >
> > Signed-off-by: RutingZhang <u202112078@hust.edu.cn>
> > Reviewed-by: Dongliang Mu <dzm91@hust.edu.cn>
>
> Subject line prefix should be "drm/amdgpu".
>
> Apart from this nit it looks good to me, but might be already fixed
> internally.
Applied. Thanks!
Alex
>
> Regards,
> Christian.
>
> > ---
> > drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c b/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c
> > index 447de8492594..6835dbb733a2 100644
> > --- a/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c
> > +++ b/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c
> > @@ -713,9 +713,8 @@ static void dcn21_resource_destruct(struct dcn21_resource_pool *pool)
> > pool->base.hubps[i] = NULL;
> > }
> >
> > - if (pool->base.irqs != NULL) {
> > + if (pool->base.irqs != NULL)
> > dal_irq_service_destroy(&pool->base.irqs);
> > - }
> > }
> >
> > for (i = 0; i < pool->base.res_cap->num_ddc; i++) {
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-11-21 18:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-21 4:36 [PATCH] gpu: display: remove unnecessary braces to fix coding style RutingZhang
2023-11-21 9:17 ` Christian König
2023-11-21 18:52 ` Alex Deucher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®