From: "Nikunj A. Dadhania" <nikunj@amd.com>
To: Tom Lendacky <thomas.lendacky@amd.com>,
linux-kernel@vger.kernel.org, x86@kernel.org,
kvm@vger.kernel.org, bp@alien8.de
Cc: mingo@redhat.com, tglx@linutronix.de,
dave.hansen@linux.intel.com, seanjc@google.com,
pbonzini@redhat.com, michael.roth@amd.com,
David Rientjes <rientjes@google.com>,
stable@kernel.org
Subject: Re: [PATCH v5] x86/sev: Add SEV-SNP guest feature negotiation support
Date: Fri, 13 Jan 2023 10:59:01 +0530 [thread overview]
Message-ID: <bac878be-acaa-e373-f5fc-fb6b35964eb5@amd.com> (raw)
In-Reply-To: <4cf6a6aa-81f9-4fae-2a39-1825433f9ee4@amd.com>
On 12/01/23 20:12, Tom Lendacky wrote:
> On 1/12/23 02:41, Nikunj A Dadhania wrote:
>> +
>> + if (sev_es_get_ghcb_version() < 2 ||
>
> I would just use ghcb_version directly here.
Right, that will work.
> But if you really want a function, that should be a pre-patch that also updates the other areas that directly use ghcb_version.
There is only one such reference other than this one, will use ghcb_version directly.
Regards
Nikunj
next prev parent reply other threads:[~2023-01-13 5:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-12 8:41 Nikunj A Dadhania
2023-01-12 14:42 ` Tom Lendacky
2023-01-13 5:29 ` Nikunj A. Dadhania [this message]
2023-01-13 11:53 ` Zhi Wang
2023-01-16 5:38 ` Nikunj A. Dadhania
2023-01-16 8:23 ` Nikunj A. Dadhania
2023-01-16 11:39 ` Zhi Wang
2023-01-16 11:43 ` Nikunj A. Dadhania
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bac878be-acaa-e373-f5fc-fb6b35964eb5@amd.com \
--to=nikunj@amd.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.roth@amd.com \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=rientjes@google.com \
--cc=seanjc@google.com \
--cc=stable@kernel.org \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®