mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH 2.6.16-rc2-git2-gkh] aoe [2/3]: don't request ATA device ID on ATA error
       [not found] <E1F6Vgr-0005nf-02@kokone>
@ 2006-02-07 16:37 ` Ed L. Cashin
  2006-02-07 16:37 ` [PATCH 2.6.16-rc2-git2-gkh] aoe [3/3]: update version to 22 Ed L. Cashin
  1 sibling, 0 replies; 2+ messages in thread
From: Ed L. Cashin @ 2006-02-07 16:37 UTC (permalink / raw)
  To: linux-kernel; +Cc: ecashin, Greg K-H

Signed-off-by: "Ed L. Cashin" <ecashin@coraid.com>

On an ATA error response, take the device down instead of
sending another ATA device identify command.

diff -upr 2.6.16-rc2-git2-gkh-orig/drivers/block/aoe/aoecmd.c 2.6.16-rc2-git2-gkh-aoe/drivers/block/aoe/aoecmd.c
--- 2.6.16-rc2-git2-gkh-orig/drivers/block/aoe/aoecmd.c	2006-02-06 17:41:05.000000000 -0500
+++ 2.6.16-rc2-git2-gkh-aoe/drivers/block/aoe/aoecmd.c	2006-02-06 17:56:59.000000000 -0500
@@ -517,6 +517,8 @@ aoecmd_ata_rsp(struct sk_buff *skb)
 	ahout = (struct aoe_atahdr *) (f->data + sizeof(struct aoe_hdr));
 	buf = f->buf;
 
+	if (ahout->cmdstat == WIN_IDENTIFY)
+		d->flags &= ~DEVFL_PAUSE;
 	if (ahin->cmdstat & 0xa9) {	/* these bits cleared on success */
 		printk(KERN_CRIT "aoe: aoecmd_ata_rsp: ata error cmd=%2.2Xh "
 			"stat=%2.2Xh from e%ld.%ld\n", 
@@ -549,7 +551,6 @@ aoecmd_ata_rsp(struct sk_buff *skb)
 				return;
 			}
 			ataid_complete(d, (char *) (ahin+1));
-			d->flags &= ~DEVFL_PAUSE;
 			break;
 		default:
 			printk(KERN_INFO "aoe: aoecmd_ata_rsp: unrecognized "


-- 
  "Ed L. Cashin" <ecashin@coraid.com>

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [PATCH 2.6.16-rc2-git2-gkh] aoe [3/3]: update version to 22
       [not found] <E1F6Vgr-0005nf-02@kokone>
  2006-02-07 16:37 ` [PATCH 2.6.16-rc2-git2-gkh] aoe [2/3]: don't request ATA device ID on ATA error Ed L. Cashin
@ 2006-02-07 16:37 ` Ed L. Cashin
  1 sibling, 0 replies; 2+ messages in thread
From: Ed L. Cashin @ 2006-02-07 16:37 UTC (permalink / raw)
  To: linux-kernel; +Cc: ecashin, Greg K-H

Signed-off-by: "Ed L. Cashin" <ecashin@coraid.com>

Increase version number to 22.

diff -upr 2.6.16-rc2-git2-gkh-orig/drivers/block/aoe/aoe.h 2.6.16-rc2-git2-gkh-aoe/drivers/block/aoe/aoe.h
--- 2.6.16-rc2-git2-gkh-orig/drivers/block/aoe/aoe.h	2006-02-06 17:41:05.000000000 -0500
+++ 2.6.16-rc2-git2-gkh-aoe/drivers/block/aoe/aoe.h	2006-02-06 17:56:59.000000000 -0500
@@ -1,5 +1,5 @@
 /* Copyright (c) 2004 Coraid, Inc.  See COPYING for GPL terms. */
-#define VERSION "21"
+#define VERSION "22"
 #define AOE_MAJOR 152
 #define DEVICE_NAME "aoe"
 


-- 
  "Ed L. Cashin" <ecashin@coraid.com>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2006-02-07 16:46 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <E1F6Vgr-0005nf-02@kokone>
2006-02-07 16:37 ` [PATCH 2.6.16-rc2-git2-gkh] aoe [2/3]: don't request ATA device ID on ATA error Ed L. Cashin
2006-02-07 16:37 ` [PATCH 2.6.16-rc2-git2-gkh] aoe [3/3]: update version to 22 Ed L. Cashin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome