mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: aspeed: anacapa: name EDSFF and thermtrip SGPIO lines
@ 2026-04-30  5:44 Rex Fu via B4 Relay
  2026-05-18  6:47 ` Andrew Jeffery
  0 siblings, 1 reply; 3+ messages in thread
From: Rex Fu via B4 Relay @ 2026-04-30  5:44 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Joel Stanley,
	Andrew Jeffery
  Cc: devicetree, linux-arm-kernel, linux-aspeed, linux-kernel, Rex Fu

From: Rex Fu <Rex.Fu@amd.com>

Name the Anacapa SGPIO lines used for EDSFF power-good and thermtrip
assertion signals.

The affected lines replace legacy or unused CPU-related names with the
platform signal names used by userspace monitoring.

Signed-off-by: Rex Fu <Rex.Fu@amd.com>
---
 arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-anacapa.dts | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-anacapa.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-anacapa.dts
index 2cb7bd128d24..fe960bb7bc27 100644
--- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-anacapa.dts
+++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-anacapa.dts
@@ -912,7 +912,7 @@ &sgpiom0 {
 	"PWRGD_PVDDIO_P0", "",
 	"PWRGD_PVDDIO_MEM_S3_P0", "",
 	"PWRGD_CHMP_CPU0_FPGA", "",
-	"PWRGD_CHIL_CPU0_FPGA", "",
+	"HPM_EDSFF_PG", "",
 	"PWRGD_CHEH_CPU0_FPGA", "",
 	"PWRGD_CHAD_CPU0_FPGA", "FM_BMC_READY_PLD",
 	"", "",
@@ -957,8 +957,8 @@ &sgpiom0 {
 	"PDB_ALERT_R_N", "",
 
 	/* L0-L7 line 176-191 */
-	"CPU0_SP7R1", "", "CPU0_SP7R2", "",
-	"CPU0_SP7R3", "", "CPU0_SP7R4", "",
+	"L_EDSFF2_PG", "", "L_EDSFF3_PG", "",
+	"R_EDSFF2_PG", "", "R_EDSFF3_PG", "",
 	"CPU0_CORETYPE0", "", "CPU0_CORETYPE1", "",
 	"CPU0_CORETYPE2", "", "FM_BIOS_POST_CMPLT_R_N", "",
 
@@ -984,8 +984,8 @@ &sgpiom0 {
 	"HPM_PWR_FAIL", "Port80_b0",
 	"FM_DIMM_IP_FAIL", "Port80_b1",
 	"FM_DIMM_AH_FAIL", "Port80_b2",
-	"HPM_AMC_THERMTRIP_R_L", "Port80_b3",
-	"FM_CPU0_THERMTRIP_N", "Port80_b4",
+	"AMC_THERMTRIP_ASSERT", "Port80_b3",
+	"CPU_THERMTRIP_ASSERT", "Port80_b4",
 	"PVDDCR_SOC_P0_OCP_L", "Port80_b5",
 	"CPLD_SGPIO_RDY", "Port80_b6",
 	"", "Port80_b7",

---
base-commit: 9974969c14031a097d6b45bcb7a06bb4aa525c40
change-id: 20260430-anacapa-sgpio-edsff-thermtrip-acb228bf61be

Best regards,
--  
Rex Fu <Rex.Fu@amd.com>



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ARM: dts: aspeed: anacapa: name EDSFF and thermtrip SGPIO lines
  2026-04-30  5:44 [PATCH] ARM: dts: aspeed: anacapa: name EDSFF and thermtrip SGPIO lines Rex Fu via B4 Relay
@ 2026-05-18  6:47 ` Andrew Jeffery
  2026-05-18  9:01   ` Fu, Rex
  0 siblings, 1 reply; 3+ messages in thread
From: Andrew Jeffery @ 2026-05-18  6:47 UTC (permalink / raw)
  To: Rex.Fu, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Joel Stanley
  Cc: devicetree, linux-arm-kernel, linux-aspeed, linux-kernel

Hello Rex,

On Thu, 2026-04-30 at 13:44 +0800, Rex Fu via B4 Relay wrote:
> From: Rex Fu <Rex.Fu@amd.com>
> 
> Name the Anacapa SGPIO lines used for EDSFF power-good and thermtrip
> assertion signals.
> 
> The affected lines replace legacy
> 

Which are legacy?

>  or unused 
> 

Which are unused?

> CPU-related names with the
> platform signal names used by userspace monitoring.

This is the kind of change that has the potential to break old
userspace. Why is it appropriate? I'd like a more precise discussion in
the commit message.

Was there some other underlying change (e.g. a new revision of the
platform design)?

Andrew

> 
> Signed-off-by: Rex Fu <Rex.Fu@amd.com>
> ---
>  arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-anacapa.dts | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-anacapa.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-anacapa.dts
> index 2cb7bd128d24..fe960bb7bc27 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-anacapa.dts
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-anacapa.dts
> @@ -912,7 +912,7 @@ &sgpiom0 {
>  	"PWRGD_PVDDIO_P0", "",
>  	"PWRGD_PVDDIO_MEM_S3_P0", "",
>  	"PWRGD_CHMP_CPU0_FPGA", "",
> -	"PWRGD_CHIL_CPU0_FPGA", "",
> +	"HPM_EDSFF_PG", "",
>  	"PWRGD_CHEH_CPU0_FPGA", "",
>  	"PWRGD_CHAD_CPU0_FPGA", "FM_BMC_READY_PLD",
>  	"", "",
> @@ -957,8 +957,8 @@ &sgpiom0 {
>  	"PDB_ALERT_R_N", "",
>  
>  	/* L0-L7 line 176-191 */
> -	"CPU0_SP7R1", "", "CPU0_SP7R2", "",
> -	"CPU0_SP7R3", "", "CPU0_SP7R4", "",
> +	"L_EDSFF2_PG", "", "L_EDSFF3_PG", "",
> +	"R_EDSFF2_PG", "", "R_EDSFF3_PG", "",
>  	"CPU0_CORETYPE0", "", "CPU0_CORETYPE1", "",
>  	"CPU0_CORETYPE2", "", "FM_BIOS_POST_CMPLT_R_N", "",
>  
> @@ -984,8 +984,8 @@ &sgpiom0 {
>  	"HPM_PWR_FAIL", "Port80_b0",
>  	"FM_DIMM_IP_FAIL", "Port80_b1",
>  	"FM_DIMM_AH_FAIL", "Port80_b2",
> -	"HPM_AMC_THERMTRIP_R_L", "Port80_b3",
> -	"FM_CPU0_THERMTRIP_N", "Port80_b4",
> +	"AMC_THERMTRIP_ASSERT", "Port80_b3",
> +	"CPU_THERMTRIP_ASSERT", "Port80_b4",
>  	"PVDDCR_SOC_P0_OCP_L", "Port80_b5",
>  	"CPLD_SGPIO_RDY", "Port80_b6",
>  	"", "Port80_b7",
> 
> ---
> base-commit: 9974969c14031a097d6b45bcb7a06bb4aa525c40
> change-id: 20260430-anacapa-sgpio-edsff-thermtrip-acb228bf61be
> 
> Best regards,
> --  
> Rex Fu <Rex.Fu@amd.com>
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* RE: [PATCH] ARM: dts: aspeed: anacapa: name EDSFF and thermtrip SGPIO lines
  2026-05-18  6:47 ` Andrew Jeffery
@ 2026-05-18  9:01   ` Fu, Rex
  0 siblings, 0 replies; 3+ messages in thread
From: Fu, Rex @ 2026-05-18  9:01 UTC (permalink / raw)
  To: Andrew Jeffery, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Joel Stanley
  Cc: devicetree, linux-arm-kernel, linux-aspeed, linux-kernel

AMD General

Hi Andrew,

Thanks for the review.

I agree that the original commit message was too vague, especially since these GPIO line names are visible to userspace.

There is no new board revision or underlying hardware change involved. This is a naming correction for the existing Anacapa hardware design.

I will remove the "legacy or unused" wording. The previous names do not match the actual Anacapa usage: some lines were named as CPU-related signals but are used for EDSFF power-good monitoring, and the thermtrip lines used raw active-low signal names while userspace monitors the asserted condition.

Changing these names is appropriate because the userspace monitoring configuration is based on the platform signal names. Keeping the old names would make the DTS inconsistent with the hardware design and userspace configuration.

I will send a v2 with the exact old-to-new mappings and a more precise explanation in the commit message.

Best regards,
Rex Fu
BMC Engineer  |  AMD
Data Center Platform Engineering Group
O +886 (2) 2655-8885
----------------------------------------------------------------------------------------------------------------------------------
3F, No. 3-2 Yuanqu Street, Nangang District, Taipei 115, Taiwan
LinkedIn  |  Instagram  |  X  |  amd.com


-----Original Message-----
From: Andrew Jeffery <andrew@codeconstruct.com.au>
Sent: Monday, May 18, 2026 2:48 PM
To: Fu, Rex <Rex.Fu@amd.com>; Rob Herring <robh@kernel.org>; Krzysztof Kozlowski <krzk+dt@kernel.org>; Conor Dooley <conor+dt@kernel.org>; Joel Stanley <joel@jms.id.au>
Cc: devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-aspeed@lists.ozlabs.org; linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: aspeed: anacapa: name EDSFF and thermtrip SGPIO lines

[You don't often get email from andrew@codeconstruct.com.au. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]

Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.


Hello Rex,

On Thu, 2026-04-30 at 13:44 +0800, Rex Fu via B4 Relay wrote:
> From: Rex Fu <Rex.Fu@amd.com>
>
> Name the Anacapa SGPIO lines used for EDSFF power-good and thermtrip
> assertion signals.
>
> The affected lines replace legacy
>

Which are legacy?

>  or unused
>

Which are unused?

> CPU-related names with the
> platform signal names used by userspace monitoring.

This is the kind of change that has the potential to break old userspace. Why is it appropriate? I'd like a more precise discussion in the commit message.

Was there some other underlying change (e.g. a new revision of the platform design)?

Andrew

>
> Signed-off-by: Rex Fu <Rex.Fu@amd.com>
> ---
>  arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-anacapa.dts | 10
> +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-anacapa.dts
> b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-anacapa.dts
> index 2cb7bd128d24..fe960bb7bc27 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-anacapa.dts
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-anacapa.dts
> @@ -912,7 +912,7 @@ &sgpiom0 {
>       "PWRGD_PVDDIO_P0", "",
>       "PWRGD_PVDDIO_MEM_S3_P0", "",
>       "PWRGD_CHMP_CPU0_FPGA", "",
> -     "PWRGD_CHIL_CPU0_FPGA", "",
> +     "HPM_EDSFF_PG", "",
>       "PWRGD_CHEH_CPU0_FPGA", "",
>       "PWRGD_CHAD_CPU0_FPGA", "FM_BMC_READY_PLD",
>       "", "",
> @@ -957,8 +957,8 @@ &sgpiom0 {
>       "PDB_ALERT_R_N", "",
>
>       /* L0-L7 line 176-191 */
> -     "CPU0_SP7R1", "", "CPU0_SP7R2", "",
> -     "CPU0_SP7R3", "", "CPU0_SP7R4", "",
> +     "L_EDSFF2_PG", "", "L_EDSFF3_PG", "",
> +     "R_EDSFF2_PG", "", "R_EDSFF3_PG", "",
>       "CPU0_CORETYPE0", "", "CPU0_CORETYPE1", "",
>       "CPU0_CORETYPE2", "", "FM_BIOS_POST_CMPLT_R_N", "",
>
> @@ -984,8 +984,8 @@ &sgpiom0 {
>       "HPM_PWR_FAIL", "Port80_b0",
>       "FM_DIMM_IP_FAIL", "Port80_b1",
>       "FM_DIMM_AH_FAIL", "Port80_b2",
> -     "HPM_AMC_THERMTRIP_R_L", "Port80_b3",
> -     "FM_CPU0_THERMTRIP_N", "Port80_b4",
> +     "AMC_THERMTRIP_ASSERT", "Port80_b3",
> +     "CPU_THERMTRIP_ASSERT", "Port80_b4",
>       "PVDDCR_SOC_P0_OCP_L", "Port80_b5",
>       "CPLD_SGPIO_RDY", "Port80_b6",
>       "", "Port80_b7",
>
> ---
> base-commit: 9974969c14031a097d6b45bcb7a06bb4aa525c40
> change-id: 20260430-anacapa-sgpio-edsff-thermtrip-acb228bf61be
>
> Best regards,
> --
> Rex Fu <Rex.Fu@amd.com>
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-05-18  9:01 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-04-30  5:44 [PATCH] ARM: dts: aspeed: anacapa: name EDSFF and thermtrip SGPIO lines Rex Fu via B4 Relay
2026-05-18  6:47 ` Andrew Jeffery
2026-05-18  9:01   ` Fu, Rex

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®