From: linux-kernel-dev@aliel.fr
To: Neil Armstrong <neil.armstrong@linaro.org>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-phy@lists.infradead.org, dri-devel@lists.freedesktop.org,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Vinod Koul <vkoul@kernel.org>,
Manivannan Sadhasivam <mani@kernel.org>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>
Subject: Re: [PATCH 00/10] phy/drm: amlogic: Extract Meson HDMI TX PHY into a dedicated driver
Date: Wed, 18 Nov 2026 20:35:26 +0100 [thread overview]
Message-ID: <bb027d3b-6a43-4dd3-9771-3448c86996b5@aliel.fr> (raw)
In-Reply-To: <51831581-525f-418c-86ea-3b5c6a80709b@linaro.org>
On 11/18/26 13:38, Neil Armstrong wrote:
> Hi,
>
> On 11/17/26 20:33, Ronald Claveau via B4 Relay wrote:
>> This series moves the Amlogic Meson HDMI TX PHY handling (covering GXBB,
>> GXL, GXM, and G12A SoCs) out of the meson_dw_hdmi DRM driver and into a
>> dedicated generic PHY driver.
>>
>> Until now, meson_dw_hdmi directly manipulated the HHI system controller
>> registers (HHI_HDMI_PHY_CNTL0..5) to configure analog parameters, toggle
>> resets, and manage power states, as well as manually ungating HDMI
>> clocks and power domains already described in the DT.
>>
>> By extracting this logic into a standalone PHY driver under
>> drivers/phy/amlogic/:
>> - Hardware representation in the DT is cleaner, modeling the HDMI TX PHY
>> as a child node of the HHI syscon referenced via standard "phys" and
>> "phy-names" properties.
>> - The DRM bridge driver relies on the standard generic PHY API
>> (phy_init, phy_configure, phy_power_on/off, phy_exit) rather than
>> touching syscon registers directly.
>> - Legacy DTs lacking the "phys" property remain supported via a
>> temporary fallback helper (meson_hdmi_phy_create_legacy) to preserve
>> backward compatibility to be removed on next phase of component
>> removal.
>>
>> Overview of the series:
>> - Patches 1-3: Fix compatible matching in meson-gx-hhi-sysctrl bindings,
>> add the new amlogic,meson-hdmi-tx-phy DT schema, and allow the
>> "hdmi-phy" child node under the HHI syscon.
>> - Patch 4: Add the new Meson HDMI TX PHY driver implementing the HDMI
>> PHY configuration ops, along with the temporary legacy creation
>> helper.
>> - Patch 5: Document the optional "phys" and "phy-names" properties in
>> the amlogic,meson-dw-hdmi binding.
>> - Patches 6-7: Clean up manual HHI clock/power-domain writes in
>> meson_dw_hdmi (relying on runtime PM instead) and convert the driver
>> to use the generic PHY framework.
>> - Patches 8-10: Add the "hdmi-phy" child node and wire up the "phys"
>> phandle for G12, GXBB, and GXL Device Trees.
>>
>> Tested on:
>> - Khadas VIM1 (GXL)
>> - dtbs_check and dt_binding_check run cleanly with no new warnings.
>>
>> Signed-off-by: Ronald Claveau <linux-kernel-dev@aliel.fr>
>> ---
>> Ronald Claveau (10):
>> dt-bindings: soc: amlogic: meson-gx-hhi-sysctrl: Fix compatible
>> matching in conditionals
>> dt-bindings: phy: amlogic: Add Meson HDMI TX PHY binding
>> dt-bindings: soc: amlogic: meson-gx-hhi-sysctrl: Add hdmi-phy
>> child node
>> phy: amlogic: Add Meson HDMI TX PHY driver
>> dt-bindings: display: amlogic,meson-dw-hdmi: Add phys and phy-
>> names
>> drm/meson: dw-hdmi: Drop manual HHI clock and memory PD setup
>> drm/meson: dw-hdmi: Use the generic PHY framework for the HDMI
>> TX PHY
>> arm64: dts: amlogic: Add HDMI TX PHY node for G12
>> arm64: dts: amlogic: Add HDMI TX PHY node for GXBB
>> arm64: dts: amlogic: Add HDMI TX PHY node for GXL
>>
>> .../bindings/display/amlogic,meson-dw-hdmi.yaml | 8 +
>> .../bindings/phy/amlogic,meson-hdmi-tx-phy.yaml | 33 +++
>> .../soc/amlogic/amlogic,meson-gx-hhi-sysctrl.yaml | 43 ++-
>> arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi | 7 +
>> arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 7 +
>> arch/arm64/boot/dts/amlogic/meson-gxl.dtsi | 7 +
>> drivers/gpu/drm/meson/Kconfig | 1 +
>> drivers/gpu/drm/meson/meson_dw_hdmi.c | 203 ++++++--------
>> drivers/phy/amlogic/Kconfig | 11 +
>> drivers/phy/amlogic/Makefile | 1 +
>> drivers/phy/amlogic/phy-meson-hdmi-tx.c | 309 +++++++++++
>> ++++++++++
>> include/linux/phy/phy-meson-hdmi-tx.h | 19 ++
>> 12 files changed, 513 insertions(+), 136 deletions(-)
>> ---
>> base-commit: 6d582d78fad9d828e575ca0cdcff8ea47a77220b
>> change-id: 20261115-meson-drm-create-hdmitx-phy-4ac40a654d09
>>
>> Best regards,
>> --
>> Ronald Claveau <linux-kernel-dev@aliel.fr>
>
> Overall it's very good, but I would've prefered a more sequencial move
> to the PHY driver, with an exact copy of the code and simplification
> towards the current PHY code.
>
> Anyway, the sashiko review comments are good, especially the one on
> patch 6 to keep the driver working on old DTs, sorry my bad...
>
> Neil
Thanks for your feedback, I am analyzing/testing sashiko feedback.
About the suspend/resume unbind/bind, I do not have any issue on my
side, but I can change the orders.
About patch 6 and the old DTs, I will reintroduce them with the legacy
check. Do you know what would be a good timeline to add a require on
those elements and drop the fallback code ?
--
Best regards,
Ronald
next prev parent reply other threads:[~2026-11-18 19:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 19:33 Ronald Claveau via B4 Relay
2026-11-17 19:33 ` [PATCH 01/10] dt-bindings: soc: amlogic: meson-gx-hhi-sysctrl: Fix compatible matching in conditionals Ronald Claveau via B4 Relay
2026-11-17 19:33 ` [PATCH 02/10] dt-bindings: phy: amlogic: Add Meson HDMI TX PHY binding Ronald Claveau via B4 Relay
2026-11-17 19:33 ` [PATCH 03/10] dt-bindings: soc: amlogic: meson-gx-hhi-sysctrl: Add hdmi-phy child node Ronald Claveau via B4 Relay
2026-11-17 19:33 ` [PATCH 04/10] phy: amlogic: Add Meson HDMI TX PHY driver Ronald Claveau via B4 Relay
2026-11-17 19:33 ` [PATCH 05/10] dt-bindings: display: amlogic,meson-dw-hdmi: Add phys and phy-names Ronald Claveau via B4 Relay
2026-11-18 12:34 ` Neil Armstrong
2026-11-18 19:10 ` linux-kernel-dev
2026-11-17 19:33 ` [PATCH 06/10] drm/meson: dw-hdmi: Drop manual HHI clock and memory PD setup Ronald Claveau via B4 Relay
2026-11-17 19:33 ` [PATCH 07/10] drm/meson: dw-hdmi: Use the generic PHY framework for the HDMI TX PHY Ronald Claveau via B4 Relay
2026-11-17 19:33 ` [PATCH 08/10] arm64: dts: amlogic: Add HDMI TX PHY node for G12 Ronald Claveau via B4 Relay
2026-11-17 19:33 ` [PATCH 09/10] arm64: dts: amlogic: Add HDMI TX PHY node for GXBB Ronald Claveau via B4 Relay
2026-11-17 19:33 ` [PATCH 10/10] arm64: dts: amlogic: Add HDMI TX PHY node for GXL Ronald Claveau via B4 Relay
2026-11-18 12:38 ` [PATCH 00/10] phy/drm: amlogic: Extract Meson HDMI TX PHY into a dedicated driver Neil Armstrong
2026-11-18 19:35 ` linux-kernel-dev [this message]
2026-11-19 7:58 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb027d3b-6a43-4dd3-9771-3448c86996b5@aliel.fr \
--to=linux-kernel-dev@aliel.fr \
--cc=airlied@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mani@kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=robh@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®