* [PATCH] net/mlx5: Add NULL check in mlx5e_tc_nic_create_miss_table
@ 2025-05-19 11:27 Charles Han
2025-05-20 11:14 ` Tariq Toukan
0 siblings, 1 reply; 2+ messages in thread
From: Charles Han @ 2025-05-19 11:27 UTC (permalink / raw)
To: saeedm, tariqt, leon, andrew+netdev, davem, edumazet, kuba,
pabeni, roid, jianbol
Cc: linux-rdma, linux-kernel, Charles Han
The mlx5e_tc_nic_create_miss_table() function did not check the
return value of mlx5_get_flow_namespace(). This could lead to
subsequent code using an invalid flow namespace pointer,
potentially causing crashes or undefined behavior.
Fixes: 794131c40850 ("net/mlx5: E-Switch, Return EBUSY if can't get mode lock")
Signed-off-by: Charles Han <hanchunchao@inspur.com>
---
drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
index f1d908f61134..81f0db29a2bb 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
@@ -5213,6 +5213,10 @@ static int mlx5e_tc_nic_create_miss_table(struct mlx5e_priv *priv)
ft_attr.level = MLX5E_TC_MISS_LEVEL;
ft_attr.prio = 0;
ns = mlx5_get_flow_namespace(priv->mdev, MLX5_FLOW_NAMESPACE_KERNEL);
+ if (!ns) {
+ mlx5_core_err(priv->mdev, "Failed to get flow namespace\n");
+ return -EOPNOTSUPP;
+ }
*ft = mlx5_create_auto_grouped_flow_table(ns, &ft_attr);
if (IS_ERR(*ft)) {
--
2.43.0
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] net/mlx5: Add NULL check in mlx5e_tc_nic_create_miss_table
2025-05-19 11:27 [PATCH] net/mlx5: Add NULL check in mlx5e_tc_nic_create_miss_table Charles Han
@ 2025-05-20 11:14 ` Tariq Toukan
0 siblings, 0 replies; 2+ messages in thread
From: Tariq Toukan @ 2025-05-20 11:14 UTC (permalink / raw)
To: Charles Han, saeedm, leon, andrew+netdev, davem, edumazet, kuba,
pabeni, roid, jianbol
Cc: linux-rdma, linux-kernel, Tariq Toukan
For EN driver changes, please use net/mlx5e prefix.
On 19/05/2025 14:27, Charles Han wrote:
> The mlx5e_tc_nic_create_miss_table() function did not check the
> return value of mlx5_get_flow_namespace(). This could lead to
> subsequent code using an invalid flow namespace pointer,
> potentially causing crashes or undefined behavior.
>
> Fixes: 794131c40850 ("net/mlx5: E-Switch, Return EBUSY if can't get mode lock")
Tagged commit doesn't seem related.
> Signed-off-by: Charles Han <hanchunchao@inspur.com>
> ---
Explicitly mention target branch, and add the netdev mailing list.
> drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
> index f1d908f61134..81f0db29a2bb 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
> @@ -5213,6 +5213,10 @@ static int mlx5e_tc_nic_create_miss_table(struct mlx5e_priv *priv)
> ft_attr.level = MLX5E_TC_MISS_LEVEL;
> ft_attr.prio = 0;
> ns = mlx5_get_flow_namespace(priv->mdev, MLX5_FLOW_NAMESPACE_KERNEL);
> + if (!ns) {
> + mlx5_core_err(priv->mdev, "Failed to get flow namespace\n");
> + return -EOPNOTSUPP;
> + }
>
> *ft = mlx5_create_auto_grouped_flow_table(ns, &ft_attr);
> if (IS_ERR(*ft)) {
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-05-20 11:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-05-19 11:27 [PATCH] net/mlx5: Add NULL check in mlx5e_tc_nic_create_miss_table Charles Han
2025-05-20 11:14 ` Tariq Toukan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®