From: Yongbang Shi <shiyongbang@huawei.com>
To: Thomas Zimmermann <tzimmermann@suse.de>,
"dmitry.baryshkov@oss.qualcomm.com"
<dmitry.baryshkov@oss.qualcomm.com>,
"tiantao (H)" <tiantao6@hisilicon.com>,
"maarten.lankhorst@linux.intel.com"
<maarten.lankhorst@linux.intel.com>,
"mripard@kernel.org" <mripard@kernel.org>,
"airlied@gmail.com" <airlied@gmail.com>,
"daniel@ffwll.ch" <daniel@ffwll.ch>,
"kongxinwei (A)" <kong.kongxinwei@hisilicon.com>
Cc: "Liangjian(Jim,Kunpeng Solution Development Dept)"
<liangjian010@huawei.com>,
"Shuliubin(Turing&Kunpeng)" <shuliubin@huawei.com>,
Chenjianmin <chenjianmin@huawei.com>,
"helin (T)" <helin52@h-partners.com>,
"shenjian (K)" <shenjian15@huawei.com>,
shaojijie <shaojijie@huawei.com>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
<shiyongbang@huawei.com>
Subject: Re: [PATCH for drm-misc-fixes v5 0/2] Fix some bugs in the hibmc DP
Date: Sat, 21 Nov 2026 17:38:53 +0800 [thread overview]
Message-ID: <bb394ba3-180c-4f6c-8040-045afbfaaecd@huawei.com> (raw)
In-Reply-To: <5418426d-2dfc-4dbe-a74c-47275c1fbbc0@suse.de>
> Hi
>
> Am 17.11.26 um 14:00 schrieb Yongbang Shi:
>> From: Lin He <helin52@huawei.com>
>>
>> Fix some bugs in the hibmc DP driver.
>
> I can't really comment on the hardware details, so
>
> Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
>
> for the patch set. Please see my comments on using lock guards before
> merging the series.
>
Thanks for the Acked-by. I'll fix the lock-guard usage as commented and
send a v6 before merging.
Thanks,
Yongbang
> Best regards
> Thomas
>
>>
>> ---
>> ChangeLog:
>> v4 -> v5:
>> - Invalidate the link in the hardirq when an unplug is sampled, and
>> stop clearing the latched HPD status in hibmc_dp_hpd_cfg().
>> (sashiko-bot)
>> - Serialize a whole AUX transfer with hibmc_dp_hpd_cfg().
>> (sashiko-bot)
>> - Append HIBMC_HPD_UNKNOWN to the enum instead of prepending it, so
>> the existing HIBMC_HPD_OUT/HIBMC_HPD_IN values do not change.
>> - Only set the enable flag when DP was initialized, clear it only when
>> it was set, and do not request the DP interrupt if DP initialization
>> failed. (sashiko-bot)
>> v3 -> v4:
>> - Fix the data race on hpd_status between hardirq and process
>> contexts with WRITE_ONCE()/READ_ONCE(). (sashiko-bot)
>> - Delete the HPD_IN early return in encoder_enable that breaks KMS
>> forced modesets. (sashiko-bot)
>> v2 -> v3:
>> - Delete irq_status and use hpd_status directly for hotplug
>> detection. (sashiko-bot)
>> - Add debug logs when hpd_status is not HPD_IN in detect and
>> encoder_enable.
>> - Move hibmc_set_enable_flag() before drm_dev_register() and
>> hibmc_set_disable_flag() after drm_dev_unregister() to narrow the
>> race window. (sashiko-bot)
>> - Add spinlock_t gpio_lock to hibmc_drm_private to protect all
>> operations on 0x0802A4. (sashiko-bot)
>> v1 -> v2:
>> - More states in HIBMC_DP_HPD_STATUS are added to the
>> 'hibmc_dp_get_hpd_status'.
>> - The call to `hibmc_set_enable_flag()` has been moved before
>> `drm_client_setup()`, specifically before the connector detection
>> triggers the I2C bit operation. (sashiko-bot)
>> - A read-modify-write operation has been implemented instead of directly
>> writing to prevent clearing the I2C mask bits. (sashiko-bot)
>> ---
>>
>> Lin He (2):
>> drm/hisilicon/hibmc: Modify the method of obtaining the hpd_status
>> drm/hisilicon/hibmc: Add a flag to indicate whether the OS-side driver
>> has been loaded
>>
>> drivers/gpu/drm/hisilicon/hibmc/dp/dp_aux.c | 11 +++-
>> drivers/gpu/drm/hisilicon/hibmc/dp/dp_comm.h | 2 +-
>> drivers/gpu/drm/hisilicon/hibmc/dp/dp_hw.c | 40 +++++++++-----
>> drivers/gpu/drm/hisilicon/hibmc/dp/dp_hw.h | 6 ++-
>> .../gpu/drm/hisilicon/hibmc/hibmc_drm_dp.c | 32 +++++------
>> .../gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 54 +++++++++++++++++--
>> .../gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h | 2 +
>> .../gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c | 19 +++++--
>> .../gpu/drm/hisilicon/hibmc/hibmc_drm_regs.h | 3 ++
>> 9 files changed, 129 insertions(+), 40 deletions(-)
>>
>
prev parent reply other threads:[~2026-11-21 9:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 13:00 Yongbang Shi
2026-11-17 13:00 ` [PATCH for drm-misc-fixes v5 1/2] drm/hisilicon/hibmc: Modify the method of obtaining the hpd_status Yongbang Shi
2026-11-17 14:12 ` Thomas Zimmermann
2026-11-21 9:35 ` Yongbang Shi
2026-11-17 13:00 ` [PATCH for drm-misc-fixes v5 2/2] drm/hisilicon/hibmc: Add a flag to indicate whether the OS-side driver has been loaded Yongbang Shi
2026-11-17 14:15 ` Thomas Zimmermann
2026-11-21 9:36 ` Yongbang Shi
2026-11-17 14:16 ` [PATCH for drm-misc-fixes v5 0/2] Fix some bugs in the hibmc DP Thomas Zimmermann
2026-11-21 9:38 ` Yongbang Shi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb394ba3-180c-4f6c-8040-045afbfaaecd@huawei.com \
--to=shiyongbang@huawei.com \
--cc=airlied@gmail.com \
--cc=chenjianmin@huawei.com \
--cc=daniel@ffwll.ch \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=helin52@h-partners.com \
--cc=kong.kongxinwei@hisilicon.com \
--cc=liangjian010@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=shaojijie@huawei.com \
--cc=shenjian15@huawei.com \
--cc=shuliubin@huawei.com \
--cc=tiantao6@hisilicon.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®