From: Andrew Lunn <andrew@lunn.ch>
To: Furong Xu <0x1207@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <joabreu@synopsys.com>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Joao Pinto <jpinto@synopsys.com>,
netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, xfr@outlook.com, rock.xu@nio.com
Subject: Re: [PATCH net-next v1 2/7] net: stmmac: gmac4: drop FPE implementation for refactoring
Date: Tue, 9 Jul 2024 15:24:20 +0200 [thread overview]
Message-ID: <bb6398ca-9e03-486f-bcec-5b7a07367261@lunn.ch> (raw)
In-Reply-To: <98183e72d59cc8ce71dd9fd25a65983ff69dfcd1.1720512888.git.0x1207@gmail.com>
On Tue, Jul 09, 2024 at 04:21:20PM +0800, Furong Xu wrote:
> The FPE support for gmac4 is complete, still drop it temporarily.
> Once FPE implementation is refactored, gmac4 support will be added.
So you say this implementation does work. So sorry, no.
NACK.
What we want is lots of small patches which are obviously correct. If
this code is correct, you could simply move it to a shared
location. Code which disappears from one file and reappears in another
file, no other changes, is obviously correct. You can make this clear
in the commit message: Moving code into a shared location. No
functional changes intended.
Once moved, you can then do refactoring changes, which when combined
with a good commit message should be obviously correct.
In linux, you do not throw code away and replace it with a new
implementation. You step by step transform it.
Andrew
---
pw-bot: cr
next prev parent reply other threads:[~2024-07-09 13:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-09 8:21 [PATCH net-next v1 0/7] net: stmmac: refactor FPE for gmac4 and xgmac Furong Xu
2024-07-09 8:21 ` [PATCH net-next v1 1/7] net: stmmac: xgmac: drop incomplete FPE implementation Furong Xu
2024-07-09 13:16 ` Andrew Lunn
2024-07-09 17:10 ` Vladimir Oltean
2024-07-10 7:57 ` Furong Xu
2024-07-09 8:21 ` [PATCH net-next v1 2/7] net: stmmac: gmac4: drop FPE implementation for refactoring Furong Xu
2024-07-09 13:24 ` Andrew Lunn [this message]
2024-07-09 8:21 ` [PATCH net-next v1 3/7] net: stmmac: refactor Frame Preemption(FPE) implementation Furong Xu
2024-07-09 8:21 ` [PATCH net-next v1 4/7] net: stmmac: gmac4: complete FPE support Furong Xu
2024-07-09 8:21 ` [PATCH net-next v1 5/7] net: stmmac: xgmac: rename XGMAC_RQ to XGMAC_FPRQ Furong Xu
2024-07-09 8:21 ` [PATCH net-next v1 6/7] net: stmmac: xgmac: complete FPE support Furong Xu
2024-07-09 8:21 ` [PATCH net-next v1 7/7] net: stmmac: xgmac: enable Frame Preemption Interrupt by default Furong Xu
2024-07-09 13:31 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb6398ca-9e03-486f-bcec-5b7a07367261@lunn.ch \
--to=andrew@lunn.ch \
--cc=0x1207@gmail.com \
--cc=alexandre.torgue@foss.st.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=joabreu@synopsys.com \
--cc=jpinto@synopsys.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rock.xu@nio.com \
--cc=xfr@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®