From: Andrew Lunn <andrew@lunn.ch>
To: Furong Xu <0x1207@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <joabreu@synopsys.com>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Joao Pinto <jpinto@synopsys.com>,
netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, xfr@outlook.com, rock.xu@nio.com
Subject: Re: [PATCH net-next v1 7/7] net: stmmac: xgmac: enable Frame Preemption Interrupt by default
Date: Tue, 9 Jul 2024 15:31:21 +0200 [thread overview]
Message-ID: <28ddf3e2-be4e-437a-b872-5ba07659e40e@lunn.ch> (raw)
In-Reply-To: <fc69b94aad4bbe568dcf9ef7aa73f9bac685142c.1720512888.git.0x1207@gmail.com>
On Tue, Jul 09, 2024 at 04:21:25PM +0800, Furong Xu wrote:
> Frame Preemption Interrupt is required to finish FPE handshake.
>
> XGMAC_FPEIE is read-only reserved if FPE is not supported by HW.
> There is no harm that we always set XGMAC_FPEIE bit.
This is better, it explains what is going on, why the change is being
made. But when i see this, i think about the interrupt handler. You
don't just enable a new interrupt, you also need to handle the
interrupt. Where is that handler code?
The commit message is the place you try to answer the questions
reviewers are going to ask. So if the interrupt handler already looks
for this interrupt cause and handles it, add a statement to the commit
message explaining it.
Andrew
prev parent reply other threads:[~2024-07-09 13:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-09 8:21 [PATCH net-next v1 0/7] net: stmmac: refactor FPE for gmac4 and xgmac Furong Xu
2024-07-09 8:21 ` [PATCH net-next v1 1/7] net: stmmac: xgmac: drop incomplete FPE implementation Furong Xu
2024-07-09 13:16 ` Andrew Lunn
2024-07-09 17:10 ` Vladimir Oltean
2024-07-10 7:57 ` Furong Xu
2024-07-09 8:21 ` [PATCH net-next v1 2/7] net: stmmac: gmac4: drop FPE implementation for refactoring Furong Xu
2024-07-09 13:24 ` Andrew Lunn
2024-07-09 8:21 ` [PATCH net-next v1 3/7] net: stmmac: refactor Frame Preemption(FPE) implementation Furong Xu
2024-07-09 8:21 ` [PATCH net-next v1 4/7] net: stmmac: gmac4: complete FPE support Furong Xu
2024-07-09 8:21 ` [PATCH net-next v1 5/7] net: stmmac: xgmac: rename XGMAC_RQ to XGMAC_FPRQ Furong Xu
2024-07-09 8:21 ` [PATCH net-next v1 6/7] net: stmmac: xgmac: complete FPE support Furong Xu
2024-07-09 8:21 ` [PATCH net-next v1 7/7] net: stmmac: xgmac: enable Frame Preemption Interrupt by default Furong Xu
2024-07-09 13:31 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28ddf3e2-be4e-437a-b872-5ba07659e40e@lunn.ch \
--to=andrew@lunn.ch \
--cc=0x1207@gmail.com \
--cc=alexandre.torgue@foss.st.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=joabreu@synopsys.com \
--cc=jpinto@synopsys.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rock.xu@nio.com \
--cc=xfr@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®