From: Andrew Lunn <andrew@lunn.ch>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
kernel@pengutronix.de, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next v2 2/3] phy: Add Open Alliance helpers for the PHY framework
Date: Sat, 10 Aug 2024 17:46:14 +0200 [thread overview]
Message-ID: <bb73ca0f-145c-4900-b077-e4d654dc1a0c@lunn.ch> (raw)
In-Reply-To: <ZrcLpXS5dd_rZq6F@pengutronix.de>
> > > 6.4 Polarity Detection and Correction (POL)
> > > 6.4.1 Polarity Detection (DET)
> > > 6.4.2 Polarity Correction (COR)
> >
> > Could these be mapped to ETH_TP_MDI* ?
>
> Yes, but it will look confusing in the user space. To make better
> representation in ethtool we will probably need a new port type. For
> example instead of PORT_TP it will be PORT_STP (single twiste pair) or
> PORT_SPE (single pair ethernet). What do you think?
Thinking about this some more....
The Marvell PHYs can indicate per pair if the polarity is wrong and
has been corrected, for 10BaseT and 1000BaseT. The datasheet indicates
that for 100BaseTX polarity does not matter.
So i agree, MDI crossover is the wrong way to indicate this. We should
add polarity indication, for up to 4 pairs.
Andrew
next prev parent reply other threads:[~2024-08-10 15:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-08 13:08 [PATCH net-next v2 1/3] ethtool: Add new result codes for TDR diagnostics Oleksij Rempel
2024-08-08 13:08 ` [PATCH net-next v2 2/3] phy: Add Open Alliance helpers for the PHY framework Oleksij Rempel
2024-08-08 13:11 ` Marc Kleine-Budde
2024-08-08 13:33 ` Russell King (Oracle)
2024-08-08 13:54 ` Andrew Lunn
2024-08-09 5:17 ` Oleksij Rempel
2024-08-09 14:00 ` Andrew Lunn
2024-08-10 6:41 ` Oleksij Rempel
2024-08-10 15:46 ` Andrew Lunn [this message]
2024-08-08 13:08 ` [PATCH net-next v2 3/3] net: phy: dp83tg720: Add cable testing support Oleksij Rempel
2024-08-08 23:28 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb73ca0f-145c-4900-b077-e4d654dc1a0c@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®