From: Chanwoo Choi <cwchoi00@gmail.com>
To: Aidan MacDonald <aidanmacdonald.0x0@gmail.com>,
cw00.choi@samsung.com, krzysztof.kozlowski@linaro.org,
myungjoo.ham@samsung.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] extcon: max77843: Replace irqchip mask_invert with unmask_base
Date: Sun, 20 Nov 2022 20:57:44 +0900 [thread overview]
Message-ID: <bb94bd7d-0b65-a832-48e9-b1518719db51@gmail.com> (raw)
In-Reply-To: <20221112152446.41690-1-aidanmacdonald.0x0@gmail.com>
On 22. 11. 13. 00:24, Aidan MacDonald wrote:
> Remove use of the deprecated mask_invert flag. Inverted mask
> registers (where a '1' bit enables an IRQ) can be described more
> directly as an unmask register.
>
> Signed-off-by: Aidan MacDonald <aidanmacdonald.0x0@gmail.com>
> ---
> drivers/extcon/extcon-max77843.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/extcon/extcon-max77843.c b/drivers/extcon/extcon-max77843.c
> index 8e6e97ec65a8..1bc0426ce3f1 100644
> --- a/drivers/extcon/extcon-max77843.c
> +++ b/drivers/extcon/extcon-max77843.c
> @@ -189,8 +189,7 @@ static const struct regmap_irq max77843_muic_irq[] = {
> static const struct regmap_irq_chip max77843_muic_irq_chip = {
> .name = "max77843-muic",
> .status_base = MAX77843_MUIC_REG_INT1,
> - .mask_base = MAX77843_MUIC_REG_INTMASK1,
> - .mask_invert = true,
> + .unmask_base = MAX77843_MUIC_REG_INTMASK1,
> .num_regs = 3,
> .irqs = max77843_muic_irq,
> .num_irqs = ARRAY_SIZE(max77843_muic_irq),
Applied it. Thanks.
--
Best Regards,
Samsung Electronics
Chanwoo Choi
prev parent reply other threads:[~2022-11-20 11:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-12 15:24 Aidan MacDonald
2022-11-14 8:03 ` Krzysztof Kozlowski
2022-11-15 14:37 ` Aidan MacDonald
2022-11-20 11:57 ` Chanwoo Choi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb94bd7d-0b65-a832-48e9-b1518719db51@gmail.com \
--to=cwchoi00@gmail.com \
--cc=aidanmacdonald.0x0@gmail.com \
--cc=cw00.choi@samsung.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®