* [PATCH] extcon: max77843: Replace irqchip mask_invert with unmask_base
@ 2022-11-12 15:24 Aidan MacDonald
2022-11-14 8:03 ` Krzysztof Kozlowski
2022-11-20 11:57 ` Chanwoo Choi
0 siblings, 2 replies; 4+ messages in thread
From: Aidan MacDonald @ 2022-11-12 15:24 UTC (permalink / raw)
To: cw00.choi, krzysztof.kozlowski, myungjoo.ham; +Cc: linux-kernel
Remove use of the deprecated mask_invert flag. Inverted mask
registers (where a '1' bit enables an IRQ) can be described more
directly as an unmask register.
Signed-off-by: Aidan MacDonald <aidanmacdonald.0x0@gmail.com>
---
drivers/extcon/extcon-max77843.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/extcon/extcon-max77843.c b/drivers/extcon/extcon-max77843.c
index 8e6e97ec65a8..1bc0426ce3f1 100644
--- a/drivers/extcon/extcon-max77843.c
+++ b/drivers/extcon/extcon-max77843.c
@@ -189,8 +189,7 @@ static const struct regmap_irq max77843_muic_irq[] = {
static const struct regmap_irq_chip max77843_muic_irq_chip = {
.name = "max77843-muic",
.status_base = MAX77843_MUIC_REG_INT1,
- .mask_base = MAX77843_MUIC_REG_INTMASK1,
- .mask_invert = true,
+ .unmask_base = MAX77843_MUIC_REG_INTMASK1,
.num_regs = 3,
.irqs = max77843_muic_irq,
.num_irqs = ARRAY_SIZE(max77843_muic_irq),
--
2.38.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] extcon: max77843: Replace irqchip mask_invert with unmask_base
2022-11-12 15:24 [PATCH] extcon: max77843: Replace irqchip mask_invert with unmask_base Aidan MacDonald
@ 2022-11-14 8:03 ` Krzysztof Kozlowski
2022-11-15 14:37 ` Aidan MacDonald
2022-11-20 11:57 ` Chanwoo Choi
1 sibling, 1 reply; 4+ messages in thread
From: Krzysztof Kozlowski @ 2022-11-14 8:03 UTC (permalink / raw)
To: Aidan MacDonald, cw00.choi, myungjoo.ham; +Cc: linux-kernel
On 12/11/2022 16:24, Aidan MacDonald wrote:
> Remove use of the deprecated mask_invert flag. Inverted mask
> registers (where a '1' bit enables an IRQ) can be described more
> directly as an unmask register.
>
> Signed-off-by: Aidan MacDonald <aidanmacdonald.0x0@gmail.com>
This is a resend? Or v2?
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] extcon: max77843: Replace irqchip mask_invert with unmask_base
2022-11-14 8:03 ` Krzysztof Kozlowski
@ 2022-11-15 14:37 ` Aidan MacDonald
0 siblings, 0 replies; 4+ messages in thread
From: Aidan MacDonald @ 2022-11-15 14:37 UTC (permalink / raw)
To: Krzysztof Kozlowski; +Cc: cw00.choi, myungjoo.ham, linux-kernel
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> writes:
> On 12/11/2022 16:24, Aidan MacDonald wrote:
>> Remove use of the deprecated mask_invert flag. Inverted mask
>> registers (where a '1' bit enables an IRQ) can be described more
>> directly as an unmask register.
>>
>> Signed-off-by: Aidan MacDonald <aidanmacdonald.0x0@gmail.com>
>
> This is a resend? Or v2?
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> Best regards,
> Krzysztof
It's a resend. The last submission couldn't be applied at the time
because of dependency troubles.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] extcon: max77843: Replace irqchip mask_invert with unmask_base
2022-11-12 15:24 [PATCH] extcon: max77843: Replace irqchip mask_invert with unmask_base Aidan MacDonald
2022-11-14 8:03 ` Krzysztof Kozlowski
@ 2022-11-20 11:57 ` Chanwoo Choi
1 sibling, 0 replies; 4+ messages in thread
From: Chanwoo Choi @ 2022-11-20 11:57 UTC (permalink / raw)
To: Aidan MacDonald, cw00.choi, krzysztof.kozlowski, myungjoo.ham
Cc: linux-kernel
On 22. 11. 13. 00:24, Aidan MacDonald wrote:
> Remove use of the deprecated mask_invert flag. Inverted mask
> registers (where a '1' bit enables an IRQ) can be described more
> directly as an unmask register.
>
> Signed-off-by: Aidan MacDonald <aidanmacdonald.0x0@gmail.com>
> ---
> drivers/extcon/extcon-max77843.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/extcon/extcon-max77843.c b/drivers/extcon/extcon-max77843.c
> index 8e6e97ec65a8..1bc0426ce3f1 100644
> --- a/drivers/extcon/extcon-max77843.c
> +++ b/drivers/extcon/extcon-max77843.c
> @@ -189,8 +189,7 @@ static const struct regmap_irq max77843_muic_irq[] = {
> static const struct regmap_irq_chip max77843_muic_irq_chip = {
> .name = "max77843-muic",
> .status_base = MAX77843_MUIC_REG_INT1,
> - .mask_base = MAX77843_MUIC_REG_INTMASK1,
> - .mask_invert = true,
> + .unmask_base = MAX77843_MUIC_REG_INTMASK1,
> .num_regs = 3,
> .irqs = max77843_muic_irq,
> .num_irqs = ARRAY_SIZE(max77843_muic_irq),
Applied it. Thanks.
--
Best Regards,
Samsung Electronics
Chanwoo Choi
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-11-20 11:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-12 15:24 [PATCH] extcon: max77843: Replace irqchip mask_invert with unmask_base Aidan MacDonald
2022-11-14 8:03 ` Krzysztof Kozlowski
2022-11-15 14:37 ` Aidan MacDonald
2022-11-20 11:57 ` Chanwoo Choi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®