mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Mayank Rungta <mrungta@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Wim Van Sebroeck <wim@linux-watchdog.org>,
	Tzung-Bi Shih <tzungbi@kernel.org>,
	Douglas Anderson <dianders@chromium.org>,
	linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org
Subject: Re: [PATCH 2/2] watchdog: pretimeout: Convert dump pretimeout governor to tristate
Date: Thu, 6 Aug 2026 14:41:54 -0700	[thread overview]
Message-ID: <bba685f6-5497-46bf-b4b0-b35829f74edd@roeck-us.net> (raw)
In-Reply-To: <20260730-export-cpu-backtrace-apis-v1-2-bace8e1cb817@google.com>

On Thu, Jul 30, 2026 at 03:00:22PM -0700, Mayank Rungta wrote:
> From: Mayank Rungta <mrungta@google.com>
> 
> Commit 645ad41da8b2 ("watchdog: pretimeout: Add "dump" pretimeout
> governor") added the "dump" watchdog pretimeout governor, but restricted
> it to built-in code because trigger_all_cpu_backtrace() was not exported
> to loadable modules.
> 
> Now that CPU backtrace APIs are supported for loadable kernel modules
> via cpumask_backtrace(), convert WATCHDOG_PRETIMEOUT_GOV_DUMP to
> tristate. This allows kernels to deliver the pretimeout governor as a
> loadable kernel module.
> 
> Signed-off-by: Mayank Rungta <mrungta@google.com>
> Reviewed-by: Douglas Anderson <dianders@chromium.org>
> Reviewed-by: Tzung-Bi Shih <tzungbi@kernel.org>

As mentioned in the other patch, I can not apply the series without Ack
from a maintainer. In case someone else wants to pick it up instead:

Acked-by: Guenter Roeck <linux@roeck-us.net>

> ---
>  drivers/watchdog/Kconfig | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
> index 9f013d774897..922741dd837c 100644
> --- a/drivers/watchdog/Kconfig
> +++ b/drivers/watchdog/Kconfig
> @@ -99,8 +99,8 @@ config WATCHDOG_PRETIMEOUT_GOV_SEL
>  if WATCHDOG_PRETIMEOUT_GOV
>  
>  config WATCHDOG_PRETIMEOUT_GOV_DUMP
> -	bool "Dump watchdog pretimeout governor"
> -	depends on WATCHDOG_CORE=y
> +	tristate "Dump watchdog pretimeout governor"
> +	depends on WATCHDOG_CORE
>  	default WATCHDOG_CORE
>  	help
>  	  Dump watchdog pretimeout governor, all cpu backtrace is

  parent reply	other threads:[~2026-08-06 21:41 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-30 22:00 [PATCH 0/2] watchdog: pretimeout: Allow building dump governor as module Mayank Rungta via B4 Relay
2026-07-30 22:00 ` [PATCH 1/2] nmi: Export CPU backtrace APIs for loadable modules Mayank Rungta via B4 Relay
2026-07-31  1:54   ` Doug Anderson
2026-08-06 21:40   ` Guenter Roeck
2026-08-06 23:44   ` Andrew Morton
2026-08-07  3:50   ` Guenter Roeck
2026-07-30 22:00 ` [PATCH 2/2] watchdog: pretimeout: Convert dump pretimeout governor to tristate Mayank Rungta via B4 Relay
2026-07-31  1:55   ` Doug Anderson
2026-08-01 12:38   ` Tzung-Bi Shih
2026-08-06 21:41   ` Guenter Roeck [this message]
2026-08-06 23:44   ` Andrew Morton
2026-08-07  3:50   ` Guenter Roeck
2026-07-30 22:50 ` [PATCH 0/2] watchdog: pretimeout: Allow building dump governor as module Andrew Morton
2026-07-30 23:39   ` Mayank Rungta
2026-07-31 21:01     ` Andrew Morton
2026-07-31 21:19       ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bba685f6-5497-46bf-b4b0-b35829f74edd@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=akpm@linux-foundation.org \
    --cc=dianders@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=mrungta@google.com \
    --cc=tzungbi@kernel.org \
    --cc=wim@linux-watchdog.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®