From: Ge Yang <yangge1116@126.com>
To: Andrew Morton <akpm@linux-foundation.org>,
David Hildenbrand <david@redhat.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
21cnbao@gmail.com, baolin.wang@linux.alibaba.com,
liuzixing@hygon.cn
Subject: Re: [PATCH] mm/hugetlb: prevent reuse of isolated free hugepages
Date: Sat, 11 Jan 2025 16:00:59 +0800 [thread overview]
Message-ID: <bba76a37-3bcd-460b-964f-a58c2d49690e@126.com> (raw)
In-Reply-To: <20250110174541.bf22caf1afa227b9a76a7e4c@linux-foundation.org>
在 2025/1/11 9:45, Andrew Morton 写道:
> On Fri, 10 Jan 2025 09:14:47 +0100 David Hildenbrand <david@redhat.com> wrote:
>
>>> To migrate huge 0, we obtain huge x from the pool. After the migration
>>> is completed, we return the now-freed huge 0 back to the pool. When
>>> it's time to migrate huge 1, we can simply reuse the now-freed huge 0
>>> from the pool. As a result, when replace_free_hugepage_folios() is
>>> executed, it cannot release huge 0 back to the buddy system.
>>>
>>> To slove the proble above, we should prevent reuse of isolated free
>>> hugepages.
>>
>> s/slove/solve/
>> s/proble/problem/
>>
>>>
>>> Link: https://lore.kernel.org/lkml/1734503588-16254-1-git-send-email-yangge1116@126.com/
>>> Fixes: 08d312ee4c0a ("mm: replace free hugepage folios after migration")
>>
>> The commit id is not stable yet.
>>
>> $ git tag --contains 08d312ee4c0a
>> mm-everything-2025-01-09-06-44
>> next-20250110
>>
>>
>> We should squash this into the original fix. Can you resend the whole
>> thing and merge the patch descriptions?
>
> I queued this as
> replace-free-hugepage-folios-after-migration-fix-3.patch. But yes, a
> clean v4 with a redone changelog would be a nice thing to have.
ok, thanks.
next prev parent reply other threads:[~2025-01-11 8:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-10 2:56 yangge1116
2025-01-10 8:14 ` David Hildenbrand
2025-01-11 1:45 ` Andrew Morton
2025-01-11 8:00 ` Ge Yang [this message]
2025-01-11 8:00 ` Ge Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bba76a37-3bcd-460b-964f-a58c2d49690e@126.com \
--to=yangge1116@126.com \
--cc=21cnbao@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liuzixing@hygon.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®