Re: [PATCH 06/10] drm/panel/tdo-tl070wsh30: Use refcounted allocation in place of devm_kzalloc()

[Neil Armstrong <neil.armstrong@linaro.org>]

On 5/7/26 13:53, Albert Esteve wrote:
> Move to using the new API devm_drm_panel_alloc() to allocate the
> panel. In the call to the new API, avoid using explicit type and use
> __typeof() for more type safety.
> 
> Signed-off-by: Albert Esteve <aesteve@redhat.com>
> ---
>   drivers/gpu/drm/panel/panel-tdo-tl070wsh30.c | 14 +++++++-------
>   1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/gpu/drm/panel/panel-tdo-tl070wsh30.c b/drivers/gpu/drm/panel/panel-tdo-tl070wsh30.c
> index 227f97f9b136f..13cfe252a838d 100644
> --- a/drivers/gpu/drm/panel/panel-tdo-tl070wsh30.c
> +++ b/drivers/gpu/drm/panel/panel-tdo-tl070wsh30.c
> @@ -162,9 +162,6 @@ static int tdo_tl070wsh30_panel_add(struct tdo_tl070wsh30_panel *tdo_tl070wsh30)
>   		return err;
>   	}
>   
> -	drm_panel_init(&tdo_tl070wsh30->base, &tdo_tl070wsh30->link->dev,
> -		       &tdo_tl070wsh30_panel_funcs, DRM_MODE_CONNECTOR_DSI);
> -
>   	err = drm_panel_of_backlight(&tdo_tl070wsh30->base);
>   	if (err)
>   		return err;
> @@ -183,10 +180,13 @@ static int tdo_tl070wsh30_panel_probe(struct mipi_dsi_device *dsi)
>   	dsi->format = MIPI_DSI_FMT_RGB888;
>   	dsi->mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_BURST | MIPI_DSI_MODE_LPM;
>   
> -	tdo_tl070wsh30 = devm_kzalloc(&dsi->dev, sizeof(*tdo_tl070wsh30),
> -				    GFP_KERNEL);
> -	if (!tdo_tl070wsh30)
> -		return -ENOMEM;
> +	tdo_tl070wsh30 = devm_drm_panel_alloc(&dsi->dev,
> +					      __typeof(*tdo_tl070wsh30), base,
> +					      &tdo_tl070wsh30_panel_funcs,
> +					      DRM_MODE_CONNECTOR_DSI);
> +
> +	if (IS_ERR(tdo_tl070wsh30))
> +		return PTR_ERR(tdo_tl070wsh30);
>   
>   	mipi_dsi_set_drvdata(dsi, tdo_tl070wsh30);
>   	tdo_tl070wsh30->link = dsi;
> 

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>

Thanks,
Neil