* [REGRESSION] rtc: imx-sc: remove .read_alarm
@ 2023-02-08 15:06 Marcel Ziswiler
2023-02-14 20:01 ` Alexandre Belloni
0 siblings, 1 reply; 2+ messages in thread
From: Marcel Ziswiler @ 2023-02-08 15:06 UTC (permalink / raw)
To: alexandre.belloni
Cc: kernel, a.zummo, festevam, linux-rtc, linux-kernel, shawnguo,
linux-arm-kernel, s.hauer, linux-imx
Hi Alexandre
Were you aware that this breaks the sysfs use case? E.g. before we were able to suspend and resume 10 seconds
later as follows:
echo +10 > /sys/class/rtc/rtc1/wakealarm; echo mem > /sys/power/state
Since the removal of .read_alarm in commit 7942121b8ca0 ("rtc: imx-sc: remove .read_alarm") this no longer
seems to work.
This seems like a regression or is this not supposed to work?
Thanks for clarifying.
Cheers
Marcel
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [REGRESSION] rtc: imx-sc: remove .read_alarm
2023-02-08 15:06 [REGRESSION] rtc: imx-sc: remove .read_alarm Marcel Ziswiler
@ 2023-02-14 20:01 ` Alexandre Belloni
0 siblings, 0 replies; 2+ messages in thread
From: Alexandre Belloni @ 2023-02-14 20:01 UTC (permalink / raw)
To: Marcel Ziswiler
Cc: kernel, a.zummo, festevam, linux-rtc, linux-kernel, shawnguo,
linux-arm-kernel, s.hauer, linux-imx
Hello,
On 08/02/2023 15:06:28+0000, Marcel Ziswiler wrote:
> Hi Alexandre
>
> Were you aware that this breaks the sysfs use case? E.g. before we were able to suspend and resume 10 seconds
> later as follows:
>
> echo +10 > /sys/class/rtc/rtc1/wakealarm; echo mem > /sys/power/state
>
> Since the removal of .read_alarm in commit 7942121b8ca0 ("rtc: imx-sc: remove .read_alarm") this no longer
> seems to work.
>
> This seems like a regression or is this not supposed to work?
This seems like a regression and I think it was reported a while ago and
then again just after you. I believe there is something to do that is
smarter than reverting the patch, I need to check.
Regards
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-02-14 20:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-08 15:06 [REGRESSION] rtc: imx-sc: remove .read_alarm Marcel Ziswiler
2023-02-14 20:01 ` Alexandre Belloni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®