From: Logan Gunthorpe <logang@deltatee.com>
To: Serge Semin <fancer.lancer@gmail.com>
Cc: jdmason@kudzu.us, dave.jiang@intel.com, Allen.Hubbe@emc.com,
Shyam-sundar.S-k@amd.com, Xiangliang.Yu@amd.com,
Sergey.Semin@t-platforms.ru, linux-ntb@googlegroups.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 01/08] NTB: ntb_test: Safely use paths with whitespace
Date: Thu, 30 Nov 2017 15:26:39 -0700 [thread overview]
Message-ID: <bbe9343c-fb43-ce8d-a871-033f3556c222@deltatee.com> (raw)
In-Reply-To: <20171130221258.GA20562@mobilestation>
On 30/11/17 03:12 PM, Serge Semin wrote:
> In general the intention of the patchset was to update the ntb_test.sh script
> so one would be compatible with new NTB test drivers I've also sent. It was
> asked of me by the NTB core maintainers. Sorry for not mentioning it in the
> cover letter.
I understand that. But most importantly a series needs to say what it's
based off of and given than it clearly depends on the ntb_tool changes
(which I saw later) it was a bit confusing.
I think this should be in the same series as the ntb_tool changes as the
ntb_test changes depend on ntb_tool and we shouldn't merge the ntb_tool
changes without the ntb_test changes as it would break them.
Logan
prev parent reply other threads:[~2017-11-30 22:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-30 21:42 Serge Semin
2017-11-30 21:42 ` [PATCH 02/08] NTB: ntb_test: Add ntb_tool port tests Serge Semin
2017-11-30 22:37 ` Logan Gunthorpe
2017-11-30 21:42 ` [PATCH 03/08] NTB: ntb_test: Update ntb_tool link tests Serge Semin
2017-11-30 21:42 ` [PATCH 04/08] NTB: ntb_test: Update ntb_tool DB tests Serge Semin
2017-11-30 21:42 ` [PATCH 05/08] NTB: ntb_test: Update ntb_tool Scratchpad tests Serge Semin
2017-11-30 21:42 ` [PATCH 06/08] NTB: ntb_test: Add ntb_tool Message tests Serge Semin
2017-11-30 21:42 ` [PATCH 07/08] NTB: ntb_test: Update ntb_tool MW tests Serge Semin
2017-11-30 21:43 ` [PATCH 08/08] NTB: ntb_test: Update ntb_perf tests Serge Semin
2017-11-30 22:04 ` [PATCH 01/08] NTB: ntb_test: Safely use paths with whitespace Logan Gunthorpe
2017-11-30 22:12 ` Serge Semin
2017-11-30 22:26 ` Logan Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bbe9343c-fb43-ce8d-a871-033f3556c222@deltatee.com \
--to=logang@deltatee.com \
--cc=Allen.Hubbe@emc.com \
--cc=Sergey.Semin@t-platforms.ru \
--cc=Shyam-sundar.S-k@amd.com \
--cc=Xiangliang.Yu@amd.com \
--cc=dave.jiang@intel.com \
--cc=fancer.lancer@gmail.com \
--cc=jdmason@kudzu.us \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ntb@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®