From: Andrew Lunn <andrew@lunn.ch>
To: Milos Reljin <milos_reljin@outlook.com>
Cc: andrei.botila@oss.nxp.com, hkallweit1@gmail.com,
linux@armlinux.org.uk, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, milos.reljin@rt-rk.com
Subject: Re: [PATCH v2] net: phy: c45-tjaxx: add delay between MDIO write and read in soft_reset
Date: Thu, 23 Jan 2025 17:26:07 +0100 [thread overview]
Message-ID: <bbee969d-7464-497a-a98b-4e6055176fbc@lunn.ch> (raw)
In-Reply-To: <AM8P250MB0124B5051DF9B54EC325644CE1E02@AM8P250MB0124.EURP250.PROD.OUTLOOK.COM>
On Thu, Jan 23, 2025 at 03:43:46PM +0000, Milos Reljin wrote:
> In application note (AN13663) for TJA1120, on page 30, there's a figure
> with average PHY startup timing values following software reset.
> The time it takes for SMI to become operational after software reset
> ranges roughly from 500 us to 1500 us.
>
> This commit adds 2000 us delay after MDIO write which triggers software
> reset. Without this delay, soft_reset function returns an error and
> prevents successful PHY init.
Is this a fix? Should it be backported to stable? If so:
Fixes: b050f2f15e04 ("phy: nxp-c45: add driver for tja1103")
and it should really indicate the net tree in the Subject: line.
https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html
Otherwise the patch looks good. Thanks for the updated commit message.
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
prev parent reply other threads:[~2025-01-23 16:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-23 15:43 Milos Reljin
2025-01-23 16:26 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bbee969d-7464-497a-a98b-4e6055176fbc@lunn.ch \
--to=andrew@lunn.ch \
--cc=andrei.botila@oss.nxp.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=milos.reljin@rt-rk.com \
--cc=milos_reljin@outlook.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®