mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH v2] net: phy: c45-tjaxx: add delay between MDIO write and read in soft_reset
@ 2025-01-23 15:43 Milos Reljin
  2025-01-23 16:26 ` Andrew Lunn
  0 siblings, 1 reply; 2+ messages in thread
From: Milos Reljin @ 2025-01-23 15:43 UTC (permalink / raw)
  To: andrei.botila, andrew, hkallweit1, linux, davem, edumazet, kuba,
	pabeni, netdev, linux-kernel
  Cc: milos.reljin

In application note (AN13663) for TJA1120, on page 30, there's a figure
with average PHY startup timing values following software reset.
The time it takes for SMI to become operational after software reset
ranges roughly from 500 us to 1500 us.

This commit adds 2000 us delay after MDIO write which triggers software
reset. Without this delay, soft_reset function returns an error and
prevents successful PHY init.

Signed-off-by: Milos Reljin <milos_reljin@outlook.com>
---
Changes in v2:
 - Updated commit message to clear up where the delay value comes from.
 - Delay added with usleep_range instead of changing sleep_before_read
   parameter of phy_read_mmd_poll_timeout to avoid excessive delay.
---
 drivers/net/phy/nxp-c45-tja11xx.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/phy/nxp-c45-tja11xx.c b/drivers/net/phy/nxp-c45-tja11xx.c
index ade544bc007d..872e582b7e83 100644
--- a/drivers/net/phy/nxp-c45-tja11xx.c
+++ b/drivers/net/phy/nxp-c45-tja11xx.c
@@ -1297,6 +1297,8 @@ static int nxp_c45_soft_reset(struct phy_device *phydev)
 	if (ret)
 		return ret;
 
+	usleep_range(2000, 2050);
+
 	return phy_read_mmd_poll_timeout(phydev, MDIO_MMD_VEND1,
 					 VEND1_DEVICE_CONTROL, ret,
 					 !(ret & DEVICE_CONTROL_RESET), 20000,
-- 
2.34.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] net: phy: c45-tjaxx: add delay between MDIO write and read in soft_reset
  2025-01-23 15:43 [PATCH v2] net: phy: c45-tjaxx: add delay between MDIO write and read in soft_reset Milos Reljin
@ 2025-01-23 16:26 ` Andrew Lunn
  0 siblings, 0 replies; 2+ messages in thread
From: Andrew Lunn @ 2025-01-23 16:26 UTC (permalink / raw)
  To: Milos Reljin
  Cc: andrei.botila, hkallweit1, linux, davem, edumazet, kuba, pabeni,
	netdev, linux-kernel, milos.reljin

On Thu, Jan 23, 2025 at 03:43:46PM +0000, Milos Reljin wrote:
> In application note (AN13663) for TJA1120, on page 30, there's a figure
> with average PHY startup timing values following software reset.
> The time it takes for SMI to become operational after software reset
> ranges roughly from 500 us to 1500 us.
> 
> This commit adds 2000 us delay after MDIO write which triggers software
> reset. Without this delay, soft_reset function returns an error and
> prevents successful PHY init.

Is this a fix? Should it be backported to stable? If so:

Fixes: b050f2f15e04 ("phy: nxp-c45: add driver for tja1103")

and it should really indicate the net tree in the Subject: line.

https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html

Otherwise the patch looks good. Thanks for the updated commit message.

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-01-23 16:26 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-01-23 15:43 [PATCH v2] net: phy: c45-tjaxx: add delay between MDIO write and read in soft_reset Milos Reljin
2025-01-23 16:26 ` Andrew Lunn

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®